From c39506ef7de428fe35182a678fdf0159c9536e17 Mon Sep 17 00:00:00 2001 From: Prowler Bot Date: Wed, 5 Feb 2025 17:18:27 +0100 Subject: [PATCH] fix(aws) wording of report.status_extended in awslambda_function_not_publicly_accessible (#6831) Co-authored-by: Kay Agahd --- ...awslambda_function_not_publicly_accessible.py | 4 ++-- ...mbda_function_not_publicly_accessible_test.py | 16 ++++++++-------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/prowler/providers/aws/services/awslambda/awslambda_function_not_publicly_accessible/awslambda_function_not_publicly_accessible.py b/prowler/providers/aws/services/awslambda/awslambda_function_not_publicly_accessible/awslambda_function_not_publicly_accessible.py index 4ab57e0de8..86c3cbfec8 100644 --- a/prowler/providers/aws/services/awslambda/awslambda_function_not_publicly_accessible/awslambda_function_not_publicly_accessible.py +++ b/prowler/providers/aws/services/awslambda/awslambda_function_not_publicly_accessible/awslambda_function_not_publicly_accessible.py @@ -10,14 +10,14 @@ class awslambda_function_not_publicly_accessible(Check): report = Check_Report_AWS(metadata=self.metadata(), resource=function) report.status = "PASS" - report.status_extended = f"Lambda function {function.name} has a policy resource-based policy not public." + report.status_extended = f"Lambda function {function.name} has a resource-based policy without public access." if is_policy_public( function.policy, awslambda_client.audited_account, is_cross_account_allowed=True, ): report.status = "FAIL" - report.status_extended = f"Lambda function {function.name} has a policy resource-based policy with public access." + report.status_extended = f"Lambda function {function.name} has a resource-based policy with public access." findings.append(report) diff --git a/tests/providers/aws/services/awslambda/awslambda_function_not_publicly_accessible/awslambda_function_not_publicly_accessible_test.py b/tests/providers/aws/services/awslambda/awslambda_function_not_publicly_accessible/awslambda_function_not_publicly_accessible_test.py index d7f8d75a40..99aaec831a 100644 --- a/tests/providers/aws/services/awslambda/awslambda_function_not_publicly_accessible/awslambda_function_not_publicly_accessible_test.py +++ b/tests/providers/aws/services/awslambda/awslambda_function_not_publicly_accessible/awslambda_function_not_publicly_accessible_test.py @@ -107,7 +107,7 @@ class Test_awslambda_function_not_publicly_accessible: assert result[0].status == "FAIL" assert ( result[0].status_extended - == f"Lambda function {function_name} has a policy resource-based policy with public access." + == f"Lambda function {function_name} has a resource-based policy with public access." ) assert result[0].resource_tags == [{"tag1": "value1", "tag2": "value2"}] @@ -184,7 +184,7 @@ class Test_awslambda_function_not_publicly_accessible: assert result[0].status == "PASS" assert ( result[0].status_extended - == f"Lambda function {function_name} has a policy resource-based policy not public." + == f"Lambda function {function_name} has a resource-based policy without public access." ) assert result[0].resource_tags == [{"tag1": "value1", "tag2": "value2"}] @@ -260,7 +260,7 @@ class Test_awslambda_function_not_publicly_accessible: assert result[0].status == "PASS" assert ( result[0].status_extended - == f"Lambda function {function_name} has a policy resource-based policy not public." + == f"Lambda function {function_name} has a resource-based policy without public access." ) assert result[0].resource_tags == [{"tag1": "value1", "tag2": "value2"}] @@ -319,7 +319,7 @@ class Test_awslambda_function_not_publicly_accessible: assert result[0].status == "FAIL" assert ( result[0].status_extended - == f"Lambda function {function_name} has a policy resource-based policy with public access." + == f"Lambda function {function_name} has a resource-based policy with public access." ) assert result[0].resource_tags == [] @@ -492,7 +492,7 @@ class Test_awslambda_function_not_publicly_accessible: assert result[0].status == "FAIL" assert ( result[0].status_extended - == "Lambda function test-public-lambda has a policy resource-based policy with public access." + == "Lambda function test-public-lambda has a resource-based policy with public access." ) assert result[0].resource_tags == [{"tag1": "value1", "tag2": "value2"}] @@ -552,7 +552,7 @@ class Test_awslambda_function_not_publicly_accessible: assert result[0].status == "PASS" assert ( result[0].status_extended - == f"Lambda function {function_name} has a policy resource-based policy not public." + == f"Lambda function {function_name} has a resource-based policy without public access." ) assert result[0].resource_tags == [] @@ -612,7 +612,7 @@ class Test_awslambda_function_not_publicly_accessible: assert result[0].status == "PASS" assert ( result[0].status_extended - == f"Lambda function {function_name} has a policy resource-based policy not public." + == f"Lambda function {function_name} has a resource-based policy without public access." ) assert result[0].resource_tags == [] @@ -681,7 +681,7 @@ class Test_awslambda_function_not_publicly_accessible: assert result[0].status == "FAIL" assert ( result[0].status_extended - == f"Lambda function {function_name} has a policy resource-based policy with public access." + == f"Lambda function {function_name} has a resource-based policy with public access." ) assert result[0].resource_id == function_name assert result[0].resource_arn == function_arn