From c74b4adf2762488ea76e95c57d4ce6aec9e57d40 Mon Sep 17 00:00:00 2001 From: Acknosyn <8602276+acknosyn@users.noreply.github.com> Date: Thu, 15 Dec 2022 04:32:38 +1300 Subject: [PATCH] fix(): Fix CloudTrail trail S3 logging public bucket false positive result when trail bucket doesn't exist (#1505) Co-authored-by: Francesco Badraun --- checks/check23 | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/checks/check23 b/checks/check23 index 5bfe753c24..00ac5c4c0c 100644 --- a/checks/check23 +++ b/checks/check23 @@ -57,6 +57,11 @@ check23(){ textInfo "$regx: Trail ${TRAIL_NAME} with home region ${TRAIL_HOME_REGION} Access Denied getting bucket location for bucket $TRAIL_BUCKET" "$regx" "$TRAIL_NAME" continue fi + if [[ $(echo "$BUCKET_LOCATION" | grep NoSuchBucket) ]] + then + textInfo "$regx: Trail ${TRAIL_NAME} with home region ${TRAIL_HOME_REGION} S3 logging bucket $TRAIL_BUCKET does not exist" "$regx" "$TRAIL_NAME" + continue + fi if [[ $BUCKET_LOCATION == "None" ]]; then BUCKET_LOCATION="us-east-1" fi