ben.carrasco/prowler
1
0
Fork 0
mirror of https://github.com/prowler-cloud/prowler.git synced 2025-12-19 05:17:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(gcp): store Cloud Storage bucket regions as lowercase (#9567)

Browse Source
This commit is contained in:
lydiavilchez
2025-12-16 17:34:01 +01:00
committed by GitHub
parent c1e1fb00c6
commit c83374d4ed
3 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
prowler/CHANGELOG.md
View File

@@ -27,6 +27,7 @@ All notable changes to the **Prowler SDK** are documented in this file.
### Fixed ### Fixed
- Fix typo `trustboundaries` category to `trust-boundaries` [(#9536)](https://github.com/prowler-cloud/prowler/pull/9536) - Fix typo `trustboundaries` category to `trust-boundaries` [(#9536)](https://github.com/prowler-cloud/prowler/pull/9536)
- Store MongoDB Atlas provider regions as lowercase [(#9554)](https://github.com/prowler-cloud/prowler/pull/9554) - Store MongoDB Atlas provider regions as lowercase [(#9554)](https://github.com/prowler-cloud/prowler/pull/9554)
- Store GCP Cloud Storage bucket regions as lowercase [(#9567)](https://github.com/prowler-cloud/prowler/pull/9567)
--- ---

2
prowler/providers/gcp/services/cloudstorage/cloudstorage_service.py
View File

@@ -77,7 +77,7 @@ class CloudStorage(GCPService):
Bucket( Bucket(
name=bucket["name"], name=bucket["name"],
id=bucket["id"], id=bucket["id"],
region=bucket["location"], region=bucket["location"].lower(),
uniform_bucket_level_access=bucket["iamConfiguration"][ uniform_bucket_level_access=bucket["iamConfiguration"][
"uniformBucketLevelAccess" "uniformBucketLevelAccess"
]["enabled"], ]["enabled"],

4
tests/providers/gcp/services/cloudstorage/cloudstorage_service_test.py
View File

@@ -35,7 +35,7 @@ class TestCloudStorageService:
assert len(cloudstorage_client.buckets) == 2 assert len(cloudstorage_client.buckets) == 2
assert cloudstorage_client.buckets[0].name == "bucket1" assert cloudstorage_client.buckets[0].name == "bucket1"
assert cloudstorage_client.buckets[0].id.__class__.__name__ == "str" assert cloudstorage_client.buckets[0].id.__class__.__name__ == "str"
assert cloudstorage_client.buckets[0].region == "US" assert cloudstorage_client.buckets[0].region == "us"
assert cloudstorage_client.buckets[0].uniform_bucket_level_access assert cloudstorage_client.buckets[0].uniform_bucket_level_access
assert cloudstorage_client.buckets[0].public assert cloudstorage_client.buckets[0].public
@@ -53,7 +53,7 @@ class TestCloudStorageService:
assert cloudstorage_client.buckets[1].name == "bucket2" assert cloudstorage_client.buckets[1].name == "bucket2"
assert cloudstorage_client.buckets[1].id.__class__.__name__ == "str" assert cloudstorage_client.buckets[1].id.__class__.__name__ == "str"
assert cloudstorage_client.buckets[1].region == "EU" assert cloudstorage_client.buckets[1].region == "eu"
assert not cloudstorage_client.buckets[1].uniform_bucket_level_access assert not cloudstorage_client.buckets[1].uniform_bucket_level_access
assert not cloudstorage_client.buckets[1].public assert not cloudstorage_client.buckets[1].public
assert cloudstorage_client.buckets[1].retention_policy is None assert cloudstorage_client.buckets[1].retention_policy is None