ben.carrasco/prowler
1
0
Fork 0
mirror of https://github.com/prowler-cloud/prowler.git synced 2026-10-09 21:14:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(aws): raise ArgumentTypeError for parser (#4921)

Browse Source
This commit is contained in:
Pedro Martín
2024-09-03 13:47:43 +02:00
committed by GitHub
parent 989fce300d
commit cfd4019281
5 changed files with 89 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/lib/cli/parser_test.py
+3 -4
View File
@@ -6,7 +6,6 @@ from mock import patch
from prowler.lib.cli.parser import ProwlerArgumentParser
from prowler.providers.aws.config import ROLE_SESSION_NAME
from prowler.providers.aws.exceptions.exceptions import AWSArgumentTypeValidationError
from prowler.providers.aws.lib.arguments.arguments import (
validate_bucket,
validate_role_session_name,
@@ -1326,13 +1325,13 @@ class Test_Parser:
"role-name?",
]
for role_name in bad_role_names:
with pytest.raises(AWSArgumentTypeValidationError) as argument_error:
with pytest.raises(ArgumentTypeError) as argument_error:
validate_role_session_name(role_name)
assert argument_error.type == AWSArgumentTypeValidationError
assert argument_error.type == ArgumentTypeError
assert (
argument_error.value.args[0]
== "[1905] AWS argument type validation error - Role Session Name must be between 2 and 64 characters and may contain alphanumeric characters, periods, hyphens, and underscores."
== "Role session name must be between 2 and 64 characters long and may contain alphanumeric characters, hyphens, underscores, plus signs, equal signs, commas, periods, at signs, and tildes."
)
def test_validate_role_session_name_valid_role_names(self):