From dabb2acfcc5218ff07ee8b5672f29583dc469a9f Mon Sep 17 00:00:00 2001 From: Kay Agahd Date: Wed, 27 Mar 2024 12:03:04 +0000 Subject: [PATCH] fix(aws): break loop after FAIL in SQS and SNS checks (#3618) --- .../sns_topics_not_publicly_accessible.py | 1 + .../sqs_queues_not_publicly_accessible.py | 2 ++ 2 files changed, 3 insertions(+) diff --git a/prowler/providers/aws/services/sns/sns_topics_not_publicly_accessible/sns_topics_not_publicly_accessible.py b/prowler/providers/aws/services/sns/sns_topics_not_publicly_accessible/sns_topics_not_publicly_accessible.py index 91f2448212..6844206218 100644 --- a/prowler/providers/aws/services/sns/sns_topics_not_publicly_accessible/sns_topics_not_publicly_accessible.py +++ b/prowler/providers/aws/services/sns/sns_topics_not_publicly_accessible/sns_topics_not_publicly_accessible.py @@ -43,6 +43,7 @@ class sns_topics_not_publicly_accessible(Check): else: report.status = "FAIL" report.status_extended = f"SNS topic {topic.name} is public because its policy allows public access." + break findings.append(report) diff --git a/prowler/providers/aws/services/sqs/sqs_queues_not_publicly_accessible/sqs_queues_not_publicly_accessible.py b/prowler/providers/aws/services/sqs/sqs_queues_not_publicly_accessible/sqs_queues_not_publicly_accessible.py index 9207d6c2da..a21e5a8c00 100644 --- a/prowler/providers/aws/services/sqs/sqs_queues_not_publicly_accessible/sqs_queues_not_publicly_accessible.py +++ b/prowler/providers/aws/services/sqs/sqs_queues_not_publicly_accessible/sqs_queues_not_publicly_accessible.py @@ -41,9 +41,11 @@ class sqs_queues_not_publicly_accessible(Check): else: report.status = "FAIL" report.status_extended = f"SQS queue {queue.id} is public because its policy allows public access, and the condition does not limit access to resources within the same account." + break else: report.status = "FAIL" report.status_extended = f"SQS queue {queue.id} is public because its policy allows public access." + break findings.append(report) return findings