From dd713351dcefb994d8bbcb2050a8b8100d6d7c61 Mon Sep 17 00:00:00 2001 From: Daniel Barranquero <74871504+danibarranqueroo@users.noreply.github.com> Date: Mon, 21 Jul 2025 13:07:26 +0200 Subject: [PATCH] fix(defender): avoid duplicated findings in check `defender_domain_dkim_enabled` (#8334) --- prowler/CHANGELOG.md | 7 +++++++ .../defender_domain_dkim_enabled.py | 2 +- .../defender_domain_dkim_enabled_test.py | 4 ++-- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/prowler/CHANGELOG.md b/prowler/CHANGELOG.md index 72c6742888..4c87cf1360 100644 --- a/prowler/CHANGELOG.md +++ b/prowler/CHANGELOG.md @@ -2,6 +2,13 @@ All notable changes to the **Prowler SDK** are documented in this file. +## [v5.9.2] (Prowler v5.9.2) UNRELEASED + +### Fixed +- Use the correct resource name in `defender_domain_dkim_enabled` check [(#8334)](https://github.com/prowler-cloud/prowler/pull/8334) + +--- + ## [v5.9.0] (Prowler v5.9.0) ### Added diff --git a/prowler/providers/m365/services/defender/defender_domain_dkim_enabled/defender_domain_dkim_enabled.py b/prowler/providers/m365/services/defender/defender_domain_dkim_enabled/defender_domain_dkim_enabled.py index f6258744d0..1f14aa9a42 100644 --- a/prowler/providers/m365/services/defender/defender_domain_dkim_enabled/defender_domain_dkim_enabled.py +++ b/prowler/providers/m365/services/defender/defender_domain_dkim_enabled/defender_domain_dkim_enabled.py @@ -26,7 +26,7 @@ class defender_domain_dkim_enabled(Check): report = CheckReportM365( metadata=self.metadata(), resource=config, - resource_name="DKIM Configuration", + resource_name=config.id, resource_id=config.id, ) report.status = "FAIL" diff --git a/tests/providers/m365/services/defender/defender_domain_dkim_enabled/defender_domain_dkim_enabled_test.py b/tests/providers/m365/services/defender/defender_domain_dkim_enabled/defender_domain_dkim_enabled_test.py index bbbf82b51c..839c42ddc4 100644 --- a/tests/providers/m365/services/defender/defender_domain_dkim_enabled/defender_domain_dkim_enabled_test.py +++ b/tests/providers/m365/services/defender/defender_domain_dkim_enabled/defender_domain_dkim_enabled_test.py @@ -43,7 +43,7 @@ class Test_defender_domain_dkim_enabled: == "DKIM is enabled for domain with ID domain1." ) assert result[0].resource == defender_client.dkim_configurations[0].dict() - assert result[0].resource_name == "DKIM Configuration" + assert result[0].resource_name == "domain1" assert result[0].resource_id == "domain1" assert result[0].location == "global" @@ -86,7 +86,7 @@ class Test_defender_domain_dkim_enabled: == "DKIM is not enabled for domain with ID domain2." ) assert result[0].resource == defender_client.dkim_configurations[0].dict() - assert result[0].resource_name == "DKIM Configuration" + assert result[0].resource_name == "domain2" assert result[0].resource_id == "domain2" assert result[0].location == "global"