Prowler 511 leaving one database per scan (#9795)

api/src/backend/tasks/jobs/attack_paths/aws.py

@@ -173,7 +173,9 @@ def sync_aws_account(
     max_progress = (
         87  # `cartography_aws.RESOURCE_FUNCTIONS["permission_relationships"]` - 1
     )
-    n_steps = len(requested_syncs) - 2  # Excluding `permission_relationships` and `resourcegroupstaggingapi`
+    n_steps = (
+        len(requested_syncs) - 2
+    )  # Excluding `permission_relationships` and `resourcegroupstaggingapi`
     progress_step = (max_progress - current_progress) / n_steps
 
     failed_syncs = {}
@@ -195,7 +197,9 @@ def sync_aws_account(
                 if func_name == "ecr:image_layers":
                     cartography_aws.RESOURCE_FUNCTIONS[func_name](
                         neo4j_session=sync_args.get("neo4j_session"),
-                        aioboto3_session=get_aioboto3_session(sync_args.get("boto3_session")),
+                        aioboto3_session=get_aioboto3_session(
+                            sync_args.get("boto3_session")
+                        ),
                         regions=sync_args.get("regions"),
                         current_aws_account_id=sync_args.get("current_aws_account_id"),
                         update_tag=sync_args.get("update_tag"),

api/src/backend/tasks/jobs/attack_paths/scan.py

@@ -46,19 +46,35 @@ def run(tenant_id: str, scan_id: str, task_id: str) -> dict[str, Any]:
         prowler_api_provider = ProwlerAPIProvider.objects.get(scan__pk=scan_id)
         prowler_sdk_provider = initialize_prowler_provider(prowler_api_provider)
 
-    # If the provider is still not supported, just return the current `ingestion_exceptions`, that is empty
-    if not get_cartography_ingestion_function(prowler_api_provider.provider):
+    # Attack Paths Scan necessary objects
+    cartography_ingestion_function = get_cartography_ingestion_function(
+        prowler_api_provider.provider
+    )
+    attack_paths_scan = db_utils.retrieve_attack_paths_scan(tenant_id, scan_id)
+
+    # Checks before starting the scan
+    if not cartography_ingestion_function:
+        ingestion_exceptions = {
+            "global_error": f"Provider {prowler_api_provider.provider} is not supported for Attack Paths scans"
+        }
+        if attack_paths_scan:
+            db_utils.finish_attack_paths_scan(
+                attack_paths_scan, StateChoices.COMPLETED, ingestion_exceptions
+            )
+
+        logger.warning(
+            f"Provider {prowler_api_provider.provider} is not supported for Attack Paths scans"
+        )
         return ingestion_exceptions
 
-    # Getting the Attack Paths Scan object and starting it
-    attack_paths_scan = db_utils.retrieve_attack_paths_scan(tenant_id, scan_id)
-    if not attack_paths_scan:
-        logger.warning(
-            f"No Attack Paths Scan found for scan {scan_id} and tenant {tenant_id}, let's create it then"
-        )
-        attack_paths_scan = db_utils.create_attack_paths_scan(
-            tenant_id, scan_id, prowler_api_provider.id
-        )
+    else:
+        if not attack_paths_scan:
+            logger.warning(
+                f"No Attack Paths Scan found for scan {scan_id} and tenant {tenant_id}, let's create it then"
+            )
+            attack_paths_scan = db_utils.create_attack_paths_scan(
+                tenant_id, scan_id, prowler_api_provider.id
+            )
 
     # While creating the Cartography configuration, attributes `neo4j_user` and `neo4j_password` are not really needed in this config object
     cartography_config = CartographyConfig(
@@ -92,7 +108,7 @@ def run(tenant_id: str, scan_id: str, task_id: str) -> dict[str, Any]:
 
             # The real scan, where iterates over cloud services
             ingestion_exceptions = _call_within_event_loop(
-                get_cartography_ingestion_function(prowler_api_provider.provider),
+                cartography_ingestion_function,
                 neo4j_session,
                 cartography_config,
                 prowler_api_provider,

api/src/backend/tasks/tests/test_attack_paths_scan.py

@@ -74,6 +74,9 @@ class TestAttackPathsRun:
             patch(
                 "tasks.jobs.attack_paths.scan.cartography_analysis.run"
             ) as mock_cartography_analysis,
+            patch(
+                "tasks.jobs.attack_paths.scan.cartography_ontology.run"
+            ) as mock_cartography_ontology,
             patch(
                 "tasks.jobs.attack_paths.scan.prowler.create_indexes"
             ) as mock_prowler_indexes,
@@ -115,6 +118,7 @@ class TestAttackPathsRun:
         mock_cartography_indexes.assert_called_once_with(mock_session, config)
         mock_prowler_indexes.assert_called_once_with(mock_session)
         mock_cartography_analysis.assert_called_once_with(mock_session, config)
+        mock_cartography_ontology.assert_called_once_with(mock_session, config)
         mock_prowler_analysis.assert_called_once_with(
             mock_session,
             provider,