From f0d4c2cfdad83b812692d1b6de92e998be9c8eb1 Mon Sep 17 00:00:00 2001 From: HugoPBrito Date: Thu, 13 Mar 2025 20:04:48 +0100 Subject: [PATCH] refactor: enhance entra_organization_admin_consent_workflow_enabled rename --- .../__init__.py | 0 ...in_consent_workflow_enabled.metadata.json} | 4 +-- ...ise_app_admin_consent_workflow_enabled.py} | 2 +- ...pp_admin_consent_workflow_enabled_test.py} | 34 +++++++++---------- 4 files changed, 20 insertions(+), 20 deletions(-) rename prowler/providers/microsoft365/services/entra/{entra_organization_admin_consent_workflow_enabled => entra_enterprise_app_admin_consent_workflow_enabled}/__init__.py (100%) rename prowler/providers/microsoft365/services/entra/{entra_organization_admin_consent_workflow_enabled/entra_organization_admin_consent_workflow_enabled.metadata.json => entra_enterprise_app_admin_consent_workflow_enabled/entra_enterprise_app_admin_consent_workflow_enabled.metadata.json} (92%) rename prowler/providers/microsoft365/services/entra/{entra_organization_admin_consent_workflow_enabled/entra_organization_admin_consent_workflow_enabled.py => entra_enterprise_app_admin_consent_workflow_enabled/entra_enterprise_app_admin_consent_workflow_enabled.py} (97%) rename tests/providers/microsoft365/services/entra/{entra_organization_admin_consent_workflow_enabled/entra_organization_admin_consent_workflow_enabled_test.py => entra_enterprise_app_admin_consent_workflow_enabled/entra_enterprise_app_admin_consent_workflow_enabled_test.py} (78%) diff --git a/prowler/providers/microsoft365/services/entra/entra_organization_admin_consent_workflow_enabled/__init__.py b/prowler/providers/microsoft365/services/entra/entra_enterprise_app_admin_consent_workflow_enabled/__init__.py similarity index 100% rename from prowler/providers/microsoft365/services/entra/entra_organization_admin_consent_workflow_enabled/__init__.py rename to prowler/providers/microsoft365/services/entra/entra_enterprise_app_admin_consent_workflow_enabled/__init__.py diff --git a/prowler/providers/microsoft365/services/entra/entra_organization_admin_consent_workflow_enabled/entra_organization_admin_consent_workflow_enabled.metadata.json b/prowler/providers/microsoft365/services/entra/entra_enterprise_app_admin_consent_workflow_enabled/entra_enterprise_app_admin_consent_workflow_enabled.metadata.json similarity index 92% rename from prowler/providers/microsoft365/services/entra/entra_organization_admin_consent_workflow_enabled/entra_organization_admin_consent_workflow_enabled.metadata.json rename to prowler/providers/microsoft365/services/entra/entra_enterprise_app_admin_consent_workflow_enabled/entra_enterprise_app_admin_consent_workflow_enabled.metadata.json index afd5dec202..be490f9551 100644 --- a/prowler/providers/microsoft365/services/entra/entra_organization_admin_consent_workflow_enabled/entra_organization_admin_consent_workflow_enabled.metadata.json +++ b/prowler/providers/microsoft365/services/entra/entra_enterprise_app_admin_consent_workflow_enabled/entra_enterprise_app_admin_consent_workflow_enabled.metadata.json @@ -1,13 +1,13 @@ { "Provider": "microsoft365", - "CheckID": "entra_organization_admin_consent_workflow_enabled", + "CheckID": "entra_enterprise_app_admin_consent_workflow_enabled", "CheckTitle": "Ensure the admin consent workflow is enabled.", "CheckType": [], "ServiceName": "entra", "SubServiceName": "", "ResourceIdTemplate": "", "Severity": "high", - "ResourceType": "Organization Settings", + "ResourceType": "Enterprise Applications Settings", "Description": "Ensure that the admin consent workflow is enabled in Microsoft Entra to allow users to request admin approval for applications requiring consent.", "Risk": "If the admin consent workflow is not enabled, users may be blocked from accessing applications that require admin consent, leading to potential work disruptions or unauthorized workarounds.", "RelatedUrl": "https://learn.microsoft.com/en-us/entra/identity/enterprise-apps/configure-admin-consent-workflow", diff --git a/prowler/providers/microsoft365/services/entra/entra_organization_admin_consent_workflow_enabled/entra_organization_admin_consent_workflow_enabled.py b/prowler/providers/microsoft365/services/entra/entra_enterprise_app_admin_consent_workflow_enabled/entra_enterprise_app_admin_consent_workflow_enabled.py similarity index 97% rename from prowler/providers/microsoft365/services/entra/entra_organization_admin_consent_workflow_enabled/entra_organization_admin_consent_workflow_enabled.py rename to prowler/providers/microsoft365/services/entra/entra_enterprise_app_admin_consent_workflow_enabled/entra_enterprise_app_admin_consent_workflow_enabled.py index 0a90f8e3c4..23068a9df7 100644 --- a/prowler/providers/microsoft365/services/entra/entra_organization_admin_consent_workflow_enabled/entra_organization_admin_consent_workflow_enabled.py +++ b/prowler/providers/microsoft365/services/entra/entra_enterprise_app_admin_consent_workflow_enabled/entra_enterprise_app_admin_consent_workflow_enabled.py @@ -4,7 +4,7 @@ from prowler.lib.check.models import Check, CheckReportMicrosoft365 from prowler.providers.microsoft365.services.entra.entra_client import entra_client -class entra_organization_admin_consent_workflow_enabled(Check): +class entra_enterprise_app_admin_consent_workflow_enabled(Check): """ Ensure the admin consent workflow is enabled in Microsoft Entra. diff --git a/tests/providers/microsoft365/services/entra/entra_organization_admin_consent_workflow_enabled/entra_organization_admin_consent_workflow_enabled_test.py b/tests/providers/microsoft365/services/entra/entra_enterprise_app_admin_consent_workflow_enabled/entra_enterprise_app_admin_consent_workflow_enabled_test.py similarity index 78% rename from tests/providers/microsoft365/services/entra/entra_organization_admin_consent_workflow_enabled/entra_organization_admin_consent_workflow_enabled_test.py rename to tests/providers/microsoft365/services/entra/entra_enterprise_app_admin_consent_workflow_enabled/entra_enterprise_app_admin_consent_workflow_enabled_test.py index f00d195942..337ddfbeab 100644 --- a/tests/providers/microsoft365/services/entra/entra_organization_admin_consent_workflow_enabled/entra_organization_admin_consent_workflow_enabled_test.py +++ b/tests/providers/microsoft365/services/entra/entra_enterprise_app_admin_consent_workflow_enabled/entra_enterprise_app_admin_consent_workflow_enabled_test.py @@ -9,7 +9,7 @@ from tests.providers.microsoft365.microsoft365_fixtures import ( ) -class Test_entra_organization_admin_consent_workflow_enabled: +class Test_entra_enterprise_app_admin_consent_workflow_enabled: def test_admin_consent_enabled(self): """ Test when admin_consent_enabled is True: @@ -23,12 +23,12 @@ class Test_entra_organization_admin_consent_workflow_enabled: return_value=set_mocked_microsoft365_provider(), ), mock.patch( - "prowler.providers.microsoft365.services.entra.entra_organization_admin_consent_workflow_enabled.entra_organization_admin_consent_workflow_enabled.entra_client", + "prowler.providers.microsoft365.services.entra.entra_enterprise_app_admin_consent_workflow_enabled.entra_enterprise_app_admin_consent_workflow_enabled.entra_client", new=entra_client, ), ): - from prowler.providers.microsoft365.services.entra.entra_organization_admin_consent_workflow_enabled.entra_organization_admin_consent_workflow_enabled import ( - entra_organization_admin_consent_workflow_enabled, + from prowler.providers.microsoft365.services.entra.entra_enterprise_app_admin_consent_workflow_enabled.entra_enterprise_app_admin_consent_workflow_enabled import ( + entra_enterprise_app_admin_consent_workflow_enabled, ) entra_client.admin_consent_policy = AdminConsentPolicy( @@ -39,7 +39,7 @@ class Test_entra_organization_admin_consent_workflow_enabled: ) entra_client.tenant_domain = DOMAIN - check = entra_organization_admin_consent_workflow_enabled() + check = entra_enterprise_app_admin_consent_workflow_enabled() result = check.execute() assert len(result) == 1 @@ -65,12 +65,12 @@ class Test_entra_organization_admin_consent_workflow_enabled: return_value=set_mocked_microsoft365_provider(), ), mock.patch( - "prowler.providers.microsoft365.services.entra.entra_organization_admin_consent_workflow_enabled.entra_organization_admin_consent_workflow_enabled.entra_client", + "prowler.providers.microsoft365.services.entra.entra_enterprise_app_admin_consent_workflow_enabled.entra_enterprise_app_admin_consent_workflow_enabled.entra_client", new=entra_client, ), ): - from prowler.providers.microsoft365.services.entra.entra_organization_admin_consent_workflow_enabled.entra_organization_admin_consent_workflow_enabled import ( - entra_organization_admin_consent_workflow_enabled, + from prowler.providers.microsoft365.services.entra.entra_enterprise_app_admin_consent_workflow_enabled.entra_enterprise_app_admin_consent_workflow_enabled import ( + entra_enterprise_app_admin_consent_workflow_enabled, ) entra_client.admin_consent_policy = AdminConsentPolicy( @@ -81,7 +81,7 @@ class Test_entra_organization_admin_consent_workflow_enabled: ) entra_client.tenant_domain = DOMAIN - check = entra_organization_admin_consent_workflow_enabled() + check = entra_enterprise_app_admin_consent_workflow_enabled() result = check.execute() assert len(result) == 1 @@ -107,12 +107,12 @@ class Test_entra_organization_admin_consent_workflow_enabled: return_value=set_mocked_microsoft365_provider(), ), mock.patch( - "prowler.providers.microsoft365.services.entra.entra_organization_admin_consent_workflow_enabled.entra_organization_admin_consent_workflow_enabled.entra_client", + "prowler.providers.microsoft365.services.entra.entra_enterprise_app_admin_consent_workflow_enabled.entra_enterprise_app_admin_consent_workflow_enabled.entra_client", new=entra_client, ), ): - from prowler.providers.microsoft365.services.entra.entra_organization_admin_consent_workflow_enabled.entra_organization_admin_consent_workflow_enabled import ( - entra_organization_admin_consent_workflow_enabled, + from prowler.providers.microsoft365.services.entra.entra_enterprise_app_admin_consent_workflow_enabled.entra_enterprise_app_admin_consent_workflow_enabled import ( + entra_enterprise_app_admin_consent_workflow_enabled, ) entra_client.admin_consent_policy = AdminConsentPolicy( @@ -123,7 +123,7 @@ class Test_entra_organization_admin_consent_workflow_enabled: ) entra_client.tenant_domain = DOMAIN - check = entra_organization_admin_consent_workflow_enabled() + check = entra_enterprise_app_admin_consent_workflow_enabled() result = check.execute() assert len(result) == 1 @@ -151,15 +151,15 @@ class Test_entra_organization_admin_consent_workflow_enabled: return_value=set_mocked_microsoft365_provider(), ), mock.patch( - "prowler.providers.microsoft365.services.entra.entra_organization_admin_consent_workflow_enabled.entra_organization_admin_consent_workflow_enabled.entra_client", + "prowler.providers.microsoft365.services.entra.entra_enterprise_app_admin_consent_workflow_enabled.entra_enterprise_app_admin_consent_workflow_enabled.entra_client", new=entra_client, ), ): - from prowler.providers.microsoft365.services.entra.entra_organization_admin_consent_workflow_enabled.entra_organization_admin_consent_workflow_enabled import ( - entra_organization_admin_consent_workflow_enabled, + from prowler.providers.microsoft365.services.entra.entra_enterprise_app_admin_consent_workflow_enabled.entra_enterprise_app_admin_consent_workflow_enabled import ( + entra_enterprise_app_admin_consent_workflow_enabled, ) - check = entra_organization_admin_consent_workflow_enabled() + check = entra_enterprise_app_admin_consent_workflow_enabled() result = check.execute() assert len(result) == 0