From f0e8c799282aed380dc2d7e8fe801c94e769d7d6 Mon Sep 17 00:00:00 2001
From: Toni de la Fuente <toni@blyx.com>
Date: Thu, 6 Jan 2022 13:40:19 +0100
Subject: [PATCH] Added passed security groups and updated title to check 777

---
 checks/check_extra777 | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/checks/check_extra777 b/checks/check_extra777
index 4cfc026aa0..184bda0e5f 100644
--- a/checks/check_extra777
+++ b/checks/check_extra777
@@ -15,7 +15,7 @@
 # Reference: https://docs.aws.amazon.com/vpc/latest/userguide/amazon-vpc-limits.html
 
 CHECK_ID_extra777="7.77"
-CHECK_TITLE_extra777="[extra777] Find VPC security groups with many ingress or egress rules "
+CHECK_TITLE_extra777="[extra777] Find VPC security groups with more than 50 ingress or egress rules "
 CHECK_SCORED_extra777="NOT_SCORED"
 CHECK_CIS_LEVEL_extra777="EXTRA"
 CHECK_SEVERITY_extra777="Medium"
@@ -35,8 +35,11 @@ extra777(){
                              ${PROFILE_OPT} \
                              --region ${regx} \
                              --query 'SecurityGroups[*].GroupId' \
-                             --output text | xargs
-                             )
+                             --output text 2>&1| xargs )
+        if [[ $(echo "$SECURITY_GROUP_IDS" | grep -E 'AccessDenied|UnauthorizedOperation|AuthorizationError') ]]; then
+            textFail "$regx: Access Denied trying to describe security groups" "$regx"
+            continue
+        fi
 
         for SECURITY_GROUP in ${SECURITY_GROUP_IDS}; do
 
@@ -58,6 +61,8 @@ extra777(){
 
             if [[ (${INGRESS_TOTAL} -ge ${THRESHOLD}) || (${EGRESS_TOTAL} -ge ${THRESHOLD}) ]]; then
                 textFail "${regx}: ${SECURITY_GROUP} has ${INGRESS_TOTAL} inbound rules and ${EGRESS_TOTAL} outbound rules" "${regx}" "${SECURITY_GROUP}"
+            else
+                textPass "${regx}: ${SECURITY_GROUP} has ${INGRESS_TOTAL} inbound rules and ${EGRESS_TOTAL} outbound rules" "${regx}" "${SECURITY_GROUP}"
             fi
         done
     done