prowler/ui/components/findings/table/finding-triage-submit.test.ts

import { describe, expect, it } from "vitest";

import { FINDING_STATUS } from "@/types/components";
import {
  FINDING_TRIAGE_NOTE_MAX_LENGTH,
  FINDING_TRIAGE_STATUS,
  type FindingTriageDetail,
} from "@/types/findings-triage";

import { buildFindingTriageUpdateInput } from "./finding-triage-submit";

function makeTriageDetail(
  overrides?: Partial<FindingTriageDetail>,
): FindingTriageDetail {
  return {
    findingId: "finding-1",
    findingUid: "prowler-finding-uid-1",
    triageId: "triage-1",
    notesCount: 1,
    status: FINDING_TRIAGE_STATUS.UNDER_REVIEW,
    label: "Under Review",
    hasVisibleNote: true,
    isMuted: false,
    canEdit: true,
    billingHref: "https://prowler.com/pricing",
    noteId: "note-1",
    noteBody: "Existing investigation note",
    maxNoteLength: FINDING_TRIAGE_NOTE_MAX_LENGTH,
    rawFindingStatus: FINDING_STATUS.FAIL,
    manualPassCreatedByName: null,
    manualPassCreatedAt: null,
    manualPassExpiresAt: null,
    manualPassActive: null,
    manualPassEvidence: null,
    manualPassDeactivatedAt: null,
    ...overrides,
  };
}

describe("buildFindingTriageUpdateInput", () => {
  it("should return null when neither status nor note changed", () => {
    // Given
    const triage = makeTriageDetail();

    // When
    const result = buildFindingTriageUpdateInput({
      triage,
      selectedStatus: FINDING_TRIAGE_STATUS.UNDER_REVIEW,
      noteBody: "Existing investigation note",
    });

    // Then
    expect(result).toBeNull();
  });

  it("should update an existing note through noteId without duplicating note creation", () => {
    // Given
    const triage = makeTriageDetail();

    // When
    const result = buildFindingTriageUpdateInput({
      triage,
      selectedStatus: FINDING_TRIAGE_STATUS.UNDER_REVIEW,
      noteBody: " Updated existing note ",
    });

    // Then
    expect(result).toEqual({
      findingId: "finding-1",
      findingUid: "prowler-finding-uid-1",
      triageId: "triage-1",
      notesCount: 1,
      noteId: "note-1",
      isMuted: false,
      note: "Updated existing note",
    });
  });

  it("should send status plus note only when creating the first note", () => {
    // Given
    const triage = makeTriageDetail({
      triageId: null,
      notesCount: 0,
      noteId: null,
      noteBody: "",
      hasVisibleNote: false,
    });

    // When
    const result = buildFindingTriageUpdateInput({
      triage,
      selectedStatus: FINDING_TRIAGE_STATUS.UNDER_REVIEW,
      noteBody: " First note ",
    });

    // Then
    expect(result).toEqual({
      findingId: "finding-1",
      findingUid: "prowler-finding-uid-1",
      triageId: null,
      notesCount: 0,
      noteId: null,
      isMuted: false,
      status: FINDING_TRIAGE_STATUS.UNDER_REVIEW,
      previousStatus: FINDING_TRIAGE_STATUS.UNDER_REVIEW,
      note: "First note",
    });
  });

  it("should send only status when status changes and an existing note is unchanged", () => {
    // Given
    const triage = makeTriageDetail();

    // When
    const result = buildFindingTriageUpdateInput({
      triage,
      selectedStatus: FINDING_TRIAGE_STATUS.RISK_ACCEPTED,
      noteBody: "Existing investigation note",
    });

    // Then
    expect(result).toEqual({
      findingId: "finding-1",
      findingUid: "prowler-finding-uid-1",
      triageId: "triage-1",
      notesCount: 1,
      noteId: "note-1",
      isMuted: false,
      status: FINDING_TRIAGE_STATUS.RISK_ACCEPTED,
      previousStatus: FINDING_TRIAGE_STATUS.UNDER_REVIEW,
    });
  });

  it("should send an empty note when an existing note is cleared", () => {
    // Given
    const triage = makeTriageDetail();

    // When
    const result = buildFindingTriageUpdateInput({
      triage,
      selectedStatus: FINDING_TRIAGE_STATUS.UNDER_REVIEW,
      noteBody: "   ",
    });

    // Then
    expect(result).toEqual({
      findingId: "finding-1",
      findingUid: "prowler-finding-uid-1",
      triageId: "triage-1",
      notesCount: 1,
      noteId: "note-1",
      isMuted: false,
      note: "",
    });
  });

  it("should build a manual pass from fresh evidence without reusing the editable note", () => {
    // Given
    const triage = makeTriageDetail({
      rawFindingStatus: FINDING_STATUS.MANUAL,
    });

    // When
    const result = buildFindingTriageUpdateInput({
      triage,
      selectedStatus: FINDING_TRIAGE_STATUS.RESOLVED,
      noteBody: "Edited conversation note",
      manualPassEvidence: " Fresh evidence from the control owner. ",
    });

    // Then
    expect(result).toEqual({
      findingId: "finding-1",
      findingUid: "prowler-finding-uid-1",
      triageId: "triage-1",
      notesCount: 1,
      noteId: "note-1",
      isMuted: false,
      status: FINDING_TRIAGE_STATUS.RESOLVED,
      previousStatus: FINDING_TRIAGE_STATUS.UNDER_REVIEW,
      manualPassEvidence: "Fresh evidence from the control owner.",
    });
  });

  it("should reject a manual pass without fresh nonblank evidence", () => {
    // Given
    const triage = makeTriageDetail({
      rawFindingStatus: FINDING_STATUS.MANUAL,
    });

    // When
    const result = buildFindingTriageUpdateInput({
      triage,
      selectedStatus: FINDING_TRIAGE_STATUS.RESOLVED,
      noteBody: "Existing investigation note",
      manualPassEvidence: "   ",
    });

    // Then
    expect(result).toBeNull();
  });

  it("should reject a manual pass when the raw status is not MANUAL", () => {
    // Given
    const triage = makeTriageDetail({
      rawFindingStatus: FINDING_STATUS.FAIL,
    });

    // When
    const result = buildFindingTriageUpdateInput({
      triage,
      selectedStatus: FINDING_TRIAGE_STATUS.RESOLVED,
      noteBody: "Existing investigation note",
      manualPassEvidence: "The control owner verified this requirement.",
    });

    // Then
    expect(result).toBeNull();
  });
});