ben.carrasco/sbc-sip-sidecar
1
0
Fork 0
mirror of https://github.com/jambonz/sbc-sip-sidecar.git synced 2025-12-19 04:27:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix bug calling getUniqueGateways (#96)

Browse Source 
* fix bug calling getUniqueGateways

* fix bug filtering gateways for regbot

* minor logging
This commit is contained in:
Dave Horton
2025-04-12 09:57:50 -04:00
committed by GitHub
parent fa6b300205
commit e87aebf88c
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/sip-trunk-options-ping.js
View File

@@ -57,12 +57,12 @@ class OptionsBot {
const carrier = await lookupCarrierBySid(this.voip_carrier_sid); const carrier = await lookupCarrierBySid(this.voip_carrier_sid);
if (carrier) { if (carrier) {
// eslint-disable-next-line max-len // eslint-disable-next-line max-len
this.logger.info(`Disabling Options ping for ${this.ipv4} in carrier ${carrier.name} (sid:${carrier.voip_carrier_sid})`); this.logger.info(`Disabling Options ping for ${this.ipv4} in carrier ${carrier.name}:${carrier.voip_carrier_sid} due to ${res.status}`);
writeAlerts({ writeAlerts({
account_sid: carrier.account_sid, account_sid: carrier.account_sid,
service_provider_sid: carrier.service_provider_sid, service_provider_sid: carrier.service_provider_sid,
// eslint-disable-next-line max-len // eslint-disable-next-line max-len
message: `Disabling Options ping for ${this.ipv4} in carrier ${carrier.name} (sid:${carrier.voip_carrier_sid})` message: `Disabling Options ping for ${this.ipv4} in carrier ${carrier.name}:${carrier.voip_carrier_sid} due to ${res.status}`
}); });
} }

6
lib/sip-trunk-register.js
View File

@@ -61,8 +61,8 @@ function getUniqueGateways(gateways, logger) {
const uniqueGatewayKeys = new Set(); const uniqueGatewayKeys = new Set();
return gateways.filter((gw) => { return gateways.filter((gw) => {
const key = `${gw.ipv4}:${gw.sip_realm}:${gw.username}:${gw.password}`; const key = `${gw.ipv4}:${gw.sip_realm}:${gw.carrier?.register_username}:${gw.carrier?.register_password}`;
if (!gw.password) { if (!gw.carrier?.register_password) {
logger.info({gw}, `Gateway ${key} does not have a password, ignoring`); logger.info({gw}, `Gateway ${key} does not have a password, ignoring`);
return false; return false;
} }
@@ -223,7 +223,7 @@ const updateCarrierRegbots = async(logger, srf) => {
// start new regbots // start new regbots
let batch_count = 0; let batch_count = 0;
for (const gw of getUniqueGateways(gateways)) { for (const gw of getUniqueGateways(gateways, logger)) {
try { try {
const rb = new Regbot(logger, { const rb = new Regbot(logger, {
voip_carrier_sid: gw.carrier.voip_carrier_sid, voip_carrier_sid: gw.carrier.voip_carrier_sid,