mirror of
https://github.com/signalwire/freeswitch.git
synced 2026-07-11 06:41:51 +00:00
Ethan Atkins
999a6dd0b7
I ran into some ice failures when testing reinvites using bypass_media_after_bridge. Every ice session has ice-ufrag and ice-pwd attributes. When leg A sends those attributes to leg B, leg B is supposed to send stun packets to leg A using the credentials provided in those attributes. Freeswitch was not updating the session credentials when the phone sent a new invite containing new ufrag and pwd attributes. This caused ICE to fail on the client side (PJSIP in this case). The new_ice flag is set to true when freeswitch detects a change in those attributes. For whatever reason, the reinvite flows that I was testing did not set the CF_REINVITE flag on the channel, but new_ice was true. It seems to me that freeswitch should always reactivate ice when the ufrag and pwd credentials change.