mirror of
https://github.com/signalwire/freeswitch.git
synced 2026-11-12 20:47:06 +00:00
Dmitry Verenitsin
e730a4e541
The RTCP NACK feedback handler used the packet's header length field as the loop bound instead of the byte count the caller already validated. An oversized length ran the loop past the fixed-size RTCP buffer, an out-of-bounds access. Clamp the entry count to the feedback words that fit in the received packet. Add an end-to-end test feeding an oversized-length NACK through the RTCP reader.
FreeSWITCH unit tests should be kept as shallow unit tests and micro benchmarks testing functionality exposed through libfreeswitch. Requirements for a new unit tests: 1. Tests must use switch_test.h framework