support delete record (#224)

* support delete record

* wip

* wip

lib/routes/api/recent-calls.js

@@ -4,7 +4,14 @@ const {DbErrorBadRequest} = require('../../utils/errors');
 const {getHomerApiKey, getHomerSipTrace, getHomerPcap} = require('../../utils/homer-utils');
 const {getJaegerTrace} = require('../../utils/jaeger-utils');
 const Account = require('../../models/account');
-const { getS3Object, getGoogleStorageObject, getAzureStorageObject } = require('../../utils/storage-utils');
+const {
+  getS3Object,
+  getGoogleStorageObject,
+  getAzureStorageObject,
+  deleteS3Object,
+  deleteGoogleStorageObject,
+  deleteAzureStorageObject
+} = require('../../utils/storage-utils');
 
 const parseAccountSid = (url) => {
   const arr = /Accounts\/([^\/]*)/.exec(url);
@@ -146,10 +153,51 @@ router.get('/:call_sid/record/:year/:month/:day/:format', async(req, res) => {
     res.set({
       'Content-Type': `audio/${format || 'mp3'}`
     });
-    stream.pipe(res);
+    if (stream) {
+      stream.pipe(res);
+    } else {
+      return res.sendStatus(404);
+    }
   }  catch (err) {
     logger.error({err}, ` error retrieving recording ${call_sid}`);
     res.sendStatus(404);
   }
 });
+
+router.delete('/:call_sid/record/:year/:month/:day/:format', async(req, res) => {
+  const {logger} = req.app.locals;
+  const {call_sid, year, month, day, format} = req.params;
+
+  try {
+    const account_sid = parseAccountSid(req.originalUrl);
+    const r = await Account.retrieve(account_sid);
+    if (r.length === 0 || !r[0].bucket_credential) return res.sendStatus(404);
+    const {bucket_credential} = r[0];
+
+    const deleteOptions  = {
+      ...bucket_credential,
+      key: `${year}/${month}/${day}/${call_sid}.${format || 'mp3'}`
+    };
+
+    switch (bucket_credential.vendor) {
+      case 'aws_s3':
+        await deleteS3Object(logger, deleteOptions);
+        break;
+      case 'google':
+        await deleteGoogleStorageObject(logger, deleteOptions);
+        break;
+      case 'azure':
+        await deleteAzureStorageObject(logger, deleteOptions);
+        break;
+      default:
+        logger.error(`There is no handler for deleting record from ${bucket_credential.vendor}`);
+        return res.sendStatus(500);
+    }
+
+    res.sendStatus(204);
+  }  catch (err) {
+    logger.error({err}, ` error deleting recording ${call_sid}`);
+    res.sendStatus(404);
+  }
+});
 module.exports = router;

lib/utils/storage-utils.js

@@ -1,8 +1,10 @@
-const { S3Client, PutObjectCommand, GetObjectCommand } = require('@aws-sdk/client-s3');
+const { S3Client, PutObjectCommand, GetObjectCommand, DeleteObjectCommand } = require('@aws-sdk/client-s3');
 const {Storage} = require('@google-cloud/storage');
 const fs = require('fs');
 const { BlobServiceClient } = require('@azure/storage-blob');
 
+// Azure
+
 async function testAzureStorage(logger, opts) {
   const blobServiceClient = BlobServiceClient.fromConnectionString(opts.connection_string);
   const containerClient = blobServiceClient.getContainerClient(opts.name);
@@ -19,16 +21,29 @@ async function getAzureStorageObject(logger, opts) {
   return response.readableStreamBody;
 }
 
-function testGoogleStorage(logger, opts) {
+async function deleteAzureStorageObject(logger, opts) {
+  const blobServiceClient = BlobServiceClient.fromConnectionString(opts.connection_string);
+  const containerClient = blobServiceClient.getContainerClient(opts.name);
+  const blockBlobClient = containerClient.getBlockBlobClient(opts.key);
+  await blockBlobClient.delete();
+}
+
+// Google
+
+function _initGoogleClient(opts) {
+  const serviceKey = JSON.parse(opts.service_key);
+  return new Storage({
+    projectId: serviceKey.project_id,
+    credentials: {
+      client_email: serviceKey.client_email,
+      private_key: serviceKey.private_key
+    },
+  });
+}
+
+async function testGoogleStorage(logger, opts) {
   return new Promise((resolve, reject) => {
-    const serviceKey = JSON.parse(opts.service_key);
-    const storage = new Storage({
-      projectId: serviceKey.project_id,
-      credentials: {
-        client_email: serviceKey.client_email,
-        private_key: serviceKey.private_key
-      },
-    });
+    const storage = _initGoogleClient(opts);
 
     const blob = storage.bucket(opts.name).file('jambonz-sample.text');
 
@@ -40,29 +55,39 @@ function testGoogleStorage(logger, opts) {
 }
 
 async function getGoogleStorageObject(logger, opts) {
-  const serviceKey = JSON.parse(opts.service_key);
-  const storage = new Storage({
-    projectId: serviceKey.project_id,
-    credentials: {
-      client_email: serviceKey.client_email,
-      private_key: serviceKey.private_key
-    },
-  });
+  const storage = _initGoogleClient(opts);
+
+  const bucket = storage.bucket(opts.name);
+  const file = bucket.file(opts.key);
+  const [exists] = await file.exists();
+  if (exists) {
+    return file.createReadStream();
+  }
+}
+
+async function deleteGoogleStorageObject(logger, opts) {
+  const storage = _initGoogleClient(opts);
 
   const bucket = storage.bucket(opts.name);
   const file = bucket.file(opts.key);
 
-  return file.createReadStream();
+  await file.delete();
 }
 
-async function testAwsS3(logger, opts) {
-  const s3 = new S3Client({
+// AWS S3
+
+function _initS3Client(opts) {
+  return new S3Client({
     credentials: {
       accessKeyId: opts.access_key_id,
       secretAccessKey: opts.secret_access_key,
     },
     region: opts.region || 'us-east-1'
   });
+}
+
+async function testAwsS3(logger, opts) {
+  const s3 = _initS3Client(opts);
 
   const input = {
     'Body': 'Hello From Jambonz',
@@ -76,26 +101,37 @@ async function testAwsS3(logger, opts) {
 }
 
 async function getS3Object(logger, opts) {
-  const s3 = new S3Client({
-    credentials: {
-      accessKeyId: opts.access_key_id,
-      secretAccessKey: opts.secret_access_key,
-    },
-    region: opts.region || 'us-east-1'
-  });
-  const command = new GetObjectCommand({
-    Bucket: opts.name,
-    Key: opts.key
-  });
+  const s3 = _initS3Client(opts);
+  const command = new GetObjectCommand(
+    {
+      Bucket: opts.name,
+      Key: opts.key
+    }
+  );
   const res = await s3.send(command);
   return res.Body;
 }
 
+async function deleteS3Object(logger, opts) {
+  const s3 = _initS3Client(opts);
+
+  const command = new DeleteObjectCommand(
+    {
+      Bucket: opts.name,
+      Key: opts.key
+    }
+  );
+  await s3.send(command);
+}
+
 module.exports = {
   testAwsS3,
   getS3Object,
+  deleteS3Object,
   testGoogleStorage,
   getGoogleStorageObject,
+  deleteGoogleStorageObject,
   testAzureStorage,
-  getAzureStorageObject
+  getAzureStorageObject,
+  deleteAzureStorageObject
 };