forward updateCall error response from feature server to client (#454)

* forward updateCall error response from feature server to client

* wip

* wip

* update review comment
This commit is contained in:
Hoan Luu Huu
2025-05-23 17:27:12 +07:00
committed by GitHub
parent 0c2f5becdc
commit f23c4fbd48

View File

@@ -1062,8 +1062,25 @@ const updateCall = async(req, res) => {
});
if (!response.ok) {
logger.error(`Error sending updateCall POST to ${url}`);
return res.sendStatus(500);
try {
const text = await response.text();
logger.error(`Error sending updateCall POST to ${url}, status: ${response.status} body: ${text}`);
// Try to parse as JSON if there's content
if (text) {
try {
const body = JSON.parse(text);
return res.status(response.status).json(body);
} catch {
// Not valid JSON
return res.status(response.status).send(text);
}
}
return res.sendStatus(response.status);
} catch (err) {
logger.error({err}, `updateCall: error reading response from ${url}`);
return res.sendStatus(response.status);
}
}
if (response.status === 200) {
// feature server return json for sip_request command