fix: app_json is used for outbound call (#358)

* fix: app_json is used for outbound call

* fix jslint

* fix: app_json setter in rest:dial task

lib/http-routes/api/create-call.js

@@ -19,7 +19,12 @@ router.post('/', async(req, res) => {
   logger.debug({body: req.body}, 'got createCall request');
   try {
     let uri, cs, to;
+    // app_json is creaeted by only api-server.
+    // if it available, take it and delete before creating task
+    const app_json = req.body.app_json;
+    delete req.body.app_json;
     const restDial = makeTask(logger, {'rest:dial': req.body});
+    restDial.appJson = app_json;
     const {lookupAccountDetails} = dbUtils(logger, srf);
     const {getSBC, getFreeswitch} = srf.locals;
     const sbcAddress = getSBC();

lib/tasks/rest_dial.js

@@ -23,6 +23,10 @@ class TaskRestDial extends Task {
 
   get name() { return TaskName.RestDial; }
 
+  set appJson(app_json) {
+    this.app_json = app_json;
+  }
+
   /**
    * INVITE has just been sent at this point
   */
@@ -84,7 +88,12 @@ class TaskRestDial extends Task {
           this.logger.info({err}, 'Rest:dial:Call established - Error calling startAmd');
         }
       }
-      const tasks = await cs.requestor.request('session:new', this.call_hook, params, httpHeaders);
+      let tasks;
+      if (this.app_json) {
+        tasks = JSON.parse(this.app_json);
+      } else {
+        tasks = await cs.requestor.request('session:new', this.call_hook, params, httpHeaders);
+      }
       if (tasks && Array.isArray(tasks)) {
         this.logger.debug({tasks: tasks}, `TaskRestDial: replacing application with ${tasks.length} tasks`);
         cs.replaceApplication(normalizeJambones(this.logger, tasks).map((tdata) => makeTask(this.logger, tdata)));

test/create-call-test.js

@@ -164,3 +164,59 @@ test('test create-call amd', async(t) => {
     t.error(err);
   }
 });
+
+test('test create-call app_json', async(t) => {
+  clearModule.all();
+  const {srf, disconnect} = require('../app');
+
+  try {
+    await connect(srf);
+
+
+    // GIVEN
+    let from = 'create-call-app-json';
+    let account_sid = 'bb845d4b-83a9-4cde-a6e9-50f3743bab3f';
+
+    // Give UAS app time to come up
+    const p = sippUac('uas.xml', '172.38.0.10', from);
+    await waitFor(1000);
+
+    const app_json = `[
+      {
+        "verb": "pause",
+        "length": 7
+      }
+    ]`;
+
+    const post = bent('http://127.0.0.1:3000/', 'POST', 'json', 201);
+    post('v1/createCall', {
+      'account_sid':account_sid,
+      "call_hook": {
+        "url": "http://127.0.0.1:3100/",
+        "method": "POST",
+        "username": "username",
+        "password": "password"
+      },
+      app_json,
+      "from": from,
+      "to": {
+        "type": "phone",
+        "number": "15583084809"
+      },
+      "amd": {
+        "actionHook": "/actionHook"
+      },
+      "speech_recognizer_vendor": "google",
+      "speech_recognizer_language": "en"
+    });
+
+    //THEN
+    await p;
+
+    disconnect();
+  } catch (err) {
+    console.log(`error received: ${err}`);
+    disconnect();
+    t.error(err);
+  }
+});