0.8.3

* Fix #343 by cancelling the request if the session isn't available

* Commit that works for 302's calls

---------

Co-authored-by: Matt Preskett <matt.preskett@netcall.com>

lib/session/call-session.js

@@ -64,6 +64,16 @@ class CallSession extends Emitter {
     this.notifiedComplete = false;
     this.rootSpan = rootSpan;
 
+    this._origRecognizerSettings = {
+      vendor: this.application?.speech_recognizer_vendor,
+      language: this.application?.speech_recognizer_language,
+    };
+    this._origSynthesizerSettings = {
+      vendor: this.application?.speech_synthesis_vendor,
+      language: this.application?.speech_synthesis_language,
+      voice: this.application?.speech_synthesis_voice,
+    };
+
     assert(rootSpan);
 
     this._recordState = RecordState.RecordingOff;
@@ -324,6 +334,22 @@ class CallSession extends Emitter {
     return this._globalSttPunctuation !== undefined;
   }
 
+  resetRecognizer() {
+    this._globalSttHints = undefined;
+    this._globalSttPunctuation = undefined;
+    this._globalAltLanguages = undefined;
+    this.isContinuousAsr = false;
+    this.asrDtmfTerminationDigits = undefined;
+    this.speechRecognizerLanguage = this._origRecognizerSettings.language;
+    this.speechRecognizerVendor = this._origRecognizerSettings.vendor;
+  }
+
+  resetSynthesizer() {
+    this.speechSynthesisLanguage = this._origSynthesizerSettings.language;
+    this.speechSynthesisVendor = this._origSynthesizerSettings.vendor;
+    this.speechSynthesisVoice = this._origSynthesizerSettings.voice;
+  }
+
   async notifyRecordOptions(opts) {
     const {action} = opts;
     this.logger.debug({opts}, 'CallSession:notifyRecordOptions');
@@ -680,6 +706,12 @@ class CallSession extends Emitter {
             stt_region: credential.stt_region
           };
         }
+        else if ('nvidia' === vendor) {
+          return {
+            speech_credential_sid: credential.speech_credential_sid,
+            riva_server_uri: credential.riva_server_uri
+          };
+        }
         else if (vendor.startsWith('custom:')) {
           return {
             speech_credential_sid: credential.speech_credential_sid,
@@ -729,6 +761,7 @@ class CallSession extends Emitter {
         }
         if (!skip) {
           const {span, ctx} = this.rootSpan.startChildSpan(`verb:${task.summary}`);
+          span.setAttributes({'verb.summary': task.summary});
           task.span = span;
           task.ctx = ctx;
           await task.exec(this, resources);
@@ -750,19 +783,22 @@ class CallSession extends Emitter {
       }
 
       if (0 === this.tasks.length && this.requestor instanceof WsRequestor && !this.callGone) {
-        let span;
+        //let span;
         try {
-          const {span} = this.rootSpan.startChildSpan('waiting for commands');
-          const {reason, queue, command} = await this._awaitCommandsOrHangup();
+          //const {span} = this.rootSpan.startChildSpan('waiting for commands');
+          //const {reason, queue, command} = await this._awaitCommandsOrHangup();
+          /*
           span.setAttributes({
             'completion.reason': reason,
             'async.request.queue': queue,
             'async.request.command': command
           });
           span.end();
+          */
+          await this._awaitCommandsOrHangup();
           if (this.callGone) break;
         } catch (err) {
-          span.end();
+          //span.end();
           this.logger.info(err, 'CallSession:exec - error waiting for new commands');
           break;
         }
@@ -1255,15 +1291,17 @@ class CallSession extends Emitter {
       this.wakeupResolver(resolution);
       this.wakeupResolver = null;
     }
+    /*
     else {
-      const {span} = this.rootSpan.startChildSpan('async command');
       const {queue, command} = resolution;
+      const {span} = this.rootSpan.startChildSpan(`recv cmd: ${command}`);
       span.setAttributes({
         'async.request.queue': queue,
         'async.request.command': command
       });
       span.end();
     }
+    */
   }
 
   _onWsConnectionDropped() {

lib/tasks/config.js

@@ -30,6 +30,12 @@ class TaskConfig extends Task {
         if (this.bargeIn[k]) this.gatherOpts[k] = this.bargeIn[k];
       });
     }
+
+    if (this.data.reset) {
+      if (typeof this.data.reset === 'string') this.data.reset = [this.data.reset];
+    }
+    else this.data.reset = [];
+
     if (this.bargeIn.sticky) this.autoEnable = true;
     this.preconditions = (this.bargeIn.enable || this.record?.action || this.listen?.url || this.data.amd) ?
       TaskPreconditions.Endpoint :
@@ -45,6 +51,10 @@ class TaskConfig extends Task {
 
   get summary() {
     const phrase = [];
+
+    /* reset recognizer and/or synthesizer to default values? */
+    if (this.data.reset.length) phrase.push(`reset ${this.data.reset.join(',')}`);
+
     if (this.bargeIn.enable) phrase.push('enable barge-in');
     if (this.hasSynthesizer) {
       const {vendor:v, language:l, voice} = this.synthesizer;
@@ -62,7 +72,7 @@ class TaskConfig extends Task {
     }
     if (this.data.amd) phrase.push('enable amd');
     if (this.notifyEvents) phrase.push(`event notification ${this.notifyEvents ? 'on' : 'off'}`);
-    return `${this.name}{${phrase.join(',')}`;
+    return `${this.name}{${phrase.join(',')}}`;
   }
 
   async exec(cs, {ep} = {}) {
@@ -86,6 +96,11 @@ class TaskConfig extends Task {
       }
     }
 
+    this.data.reset.forEach((k) => {
+      if (k === 'synthesizer') cs.resetSynthesizer();
+      else if (k === 'recognizer') cs.resetRecognizer();
+    });
+
     if (this.hasSynthesizer) {
       cs.speechSynthesisVendor = this.synthesizer.vendor !== 'default'
         ? this.synthesizer.vendor

lib/tasks/rest_dial.js

@@ -28,6 +28,7 @@ class TaskRestDial extends Task {
   */
   async exec(cs) {
     await super.exec(cs);
+    this.cs = cs;
     this.canCancel = true;
 
     this._setCallTimer();
@@ -37,9 +38,9 @@ class TaskRestDial extends Task {
   kill(cs) {
     super.kill(cs);
     this._clearCallTimer();
-    if (this.canCancel && cs?.req) {
+    if (this.canCancel) {
       this.canCancel = false;
-      cs.req.cancel();
+      cs?.req?.cancel();
     }
     this.notifyTaskDone();
   }
@@ -98,7 +99,7 @@ class TaskRestDial extends Task {
   _onCallTimeout() {
     this.logger.debug('TaskRestDial: timeout expired without answer, killing task');
     this.timer = null;
-    this.kill();
+    this.kill(this.cs);
   }
 }
 

lib/tasks/say.js

@@ -36,6 +36,7 @@ class TaskSay extends Task {
     this.earlyMedia = this.data.earlyMedia === true || (parentTask && parentTask.earlyMedia);
     this.synthesizer = this.data.synthesizer || {};
     this.disableTtsCache = this.data.disableTtsCache;
+    this.options = this.synthesizer.options || {};
   }
 
   get name() { return TaskName.Say; }
@@ -66,7 +67,7 @@ class TaskSay extends Task {
       cs.speechSynthesisVoice;
     const engine = this.synthesizer.engine || 'standard';
     const salt = cs.callSid;
-    const credentials = cs.getSpeechCredentials(vendor, 'tts');
+    let credentials = cs.getSpeechCredentials(vendor, 'tts');
 
     /* parse Nuance voices into name and model */
     let model;
@@ -78,6 +79,16 @@ class TaskSay extends Task {
       }
     }
 
+    /* allow for microsoft custom region voice and api_key to be specified as an override */
+    if (vendor === 'microsoft' && this.options.deploymentId) {
+      credentials = credentials || {};
+      credentials.use_custom_tts = true;
+      credentials.custom_tts_endpoint = this.options.deploymentId;
+      credentials.api_key = this.options.apiKey || credentials.apiKey;
+      credentials.region = this.options.region || credentials.region;
+      voice = this.options.voice || voice;
+    }
+
     this.logger.info({vendor, language, voice, model}, 'TaskSay:exec');
     this.ep = ep;
     try {

lib/tasks/task.js

@@ -155,7 +155,7 @@ class Task extends Emitter {
     if (this.actionHook) {
       const type = this.name === TaskName.Redirect ? 'session:redirect' : 'verb:hook';
       const params = results ? Object.assign(this.cs.callInfo.toJSON(), results) : this.cs.callInfo.toJSON();
-      const span = this.startSpan(type, {'hook.url': this.actionHook});
+      const span = this.startSpan(`${type} (${this.actionHook})`);
       const b3 = this.getTracingPropagation('b3', span);
       const httpHeaders = b3 && {b3};
       span.setAttributes({'http.body': JSON.stringify(params)});

lib/utils/db-utils.js

@@ -78,6 +78,10 @@ const speechMapper = (cred) => {
       const o = JSON.parse(decrypt(credential));
       obj.api_key = o.api_key;
     }
+    else if ('nvidia' === obj.vendor) {
+      const o = JSON.parse(decrypt(credential));
+      obj.riva_server_uri = o.riva_server_uri;
+    }
     else if (obj.vendor.startsWith('custom:')) {
       const o = JSON.parse(decrypt(credential));
       obj.auth_token = o.auth_token;

lib/utils/transcription-utils.js

@@ -549,6 +549,7 @@ module.exports = (logger) => {
     }
     else if ('nvidia' === vendor) {
       const {nvidiaOptions = {}} = rOpts;
+      const rivaUri = nvidiaOptions.rivaUri || sttCredentials.riva_server_uri;
       opts = {
         ...opts,
         ...((nvidiaOptions.profanityFilter || rOpts.profanityFilter) && {NVIDIA_PROFANITY_FILTER: 1}),
@@ -560,7 +561,7 @@ module.exports = (logger) => {
         ...(nvidiaOptions.maxAlternatives && {NVIDIA_MAX_ALTERNATIVES: nvidiaOptions.maxAlternatives}),
         ...(!nvidiaOptions.maxAlternatives && {NVIDIA_MAX_ALTERNATIVES: 1}),
         ...(rOpts.model && {NVIDIA_MODEL: rOpts.model}),
-        ...(nvidiaOptions.rivaUri && {NVIDIA_RIVA_URI: nvidiaOptions.rivaUri}),
+        ...(rivaUri && {NVIDIA_RIVA_URI: rivaUri}),
         ...(nvidiaOptions.verbatimTranscripts && {NVIDIA_VERBATIM_TRANSCRIPTS: 1}),
         ...(rOpts.diarization && {NVIDIA_SPEAKER_DIARIZATION: 1}),
         ...(rOpts.diarization && rOpts.diarizationMaxSpeakers > 0 &&

package.json

@@ -1,6 +1,6 @@
 {
   "name": "jambonz-feature-server",
-  "version": "v0.8.2",
+  "version": "0.8.3",
   "main": "app.js",
   "engines": {
     "node": ">= 10.16.0"
@@ -25,13 +25,13 @@
     "jslint:fix": "eslint app.js tracer.js lib --fix"
   },
   "dependencies": {
-    "@jambonz/db-helpers": "^0.7.4",
+    "@jambonz/db-helpers": "^0.7.10",
     "@jambonz/http-health-check": "^0.0.1",
-    "@jambonz/realtimedb-helpers": "^0.7.0",
-    "@jambonz/speech-utils": "^0.0.12",
+    "@jambonz/realtimedb-helpers": "^0.7.2",
+    "@jambonz/speech-utils": "^0.0.13",
     "@jambonz/stats-collector": "^0.1.8",
     "@jambonz/time-series": "^0.2.5",
-    "@jambonz/verb-specifications": "^0.0.16",
+    "@jambonz/verb-specifications": "^0.0.22",
     "@opentelemetry/api": "^1.4.0",
     "@opentelemetry/exporter-jaeger": "^1.9.0",
     "@opentelemetry/exporter-trace-otlp-http": "^0.35.0",

test/gather-tests.js

@@ -102,6 +102,53 @@ test('\'gather\' test - default (google)', async(t) => {
   }
 });
 
+test('\'config\' test - reset to app defaults', async(t) => {
+  if (!GCP_JSON_KEY) {
+    t.pass('skipping config tests');
+    return t.end();
+  }
+  clearModule.all();
+  const {srf, disconnect} = require('../app');
+
+  try {
+    await connect(srf);
+    // GIVEN
+    let verbs = [
+      {
+        "verb": "config",
+        "recognizer": {
+          "vendor": "google",
+          "language": "fr-FR"
+        },
+      },
+      {
+        "verb": "config",
+        "reset": ['recognizer'],
+      },
+      {
+        "verb": "gather",
+        "input": ["speech"],
+        "timeout": 10,
+        "actionHook": "/actionHook"
+      }
+    ];
+    let from = "gather_success";
+    provisionCallHook(from, verbs);
+    // THEN
+    await sippUac('uac-gather-account-creds-success.xml', '172.38.0.10', from);
+    let obj = await getJSON(`http://127.0.0.1:3100/lastRequest/${from}_actionHook`);
+    //console.log(JSON.stringify(obj));
+    t.ok(obj.body.speech.alternatives[0].transcript.toLowerCase() === 'i\'d like to speak to customer support',
+      'config: resets recognizer to app defaults');
+
+    disconnect();
+  } catch (err) {
+    console.log(`error received: ${err}`);
+    disconnect();
+    t.error(err);
+  }
+});
+
 test('\'gather\' test - microsoft', async(t) => {
   if (!MICROSOFT_REGION || !MICROSOFT_API_KEY) {
     t.pass('skipping microsoft tests');
@@ -214,7 +261,7 @@ test('\'gather\' test - deepgram', async(t) => {
     await sippUac('uac-gather-account-creds-success.xml', '172.38.0.10', from);
     let obj = await getJSON(`http://127.0.0.1:3100/lastRequest/${from}_actionHook`);
     //console.log(JSON.stringify(obj));
-    t.ok(obj.body.speech.alternatives[0].transcript.toLowerCase().startsWith('i\'d like to speak to customer support'),
+    t.ok(obj.body.speech.alternatives[0].transcript.toLowerCase().includes('like to speak to customer support'),
       'gather: succeeds when using deepgram credentials');
     disconnect();
   } catch (err) {

test/say-tests.js

@@ -43,3 +43,84 @@ test('\'say\' tests', async(t) => {
     t.error(err);
   }
 });
+
+test('\'config\' reset synthesizer tests', async(t) => {
+  clearModule.all();
+  const {srf, disconnect} = require('../app');
+
+  try {
+    await connect(srf);
+
+    // GIVEN
+    const verbs = [
+      {
+        "verb": "config",
+        "synthesizer": {
+          "vendor": "microsft",
+          "voice": "foobar"
+        },
+      },
+      {
+        "verb": "config",
+        "reset": 'synthesizer',
+      },
+      {
+        verb: 'say',
+        text: 'hello'
+      }
+    ];
+
+    const from = 'say_test_success';
+    provisionCallHook(from, verbs)
+
+    // THEN
+    await sippUac('uac-success-received-bye.xml', '172.38.0.10', from);
+    t.pass('say: succeeds when using using account credentials');
+    disconnect();
+  } catch (err) {
+    console.log(`error received: ${err}`);
+    disconnect();
+    t.error(err);
+  }
+});
+
+const {MICROSOFT_CUSTOM_API_KEY, MICROSOFT_DEPLOYMENT_ID, MICROSOFT_CUSTOM_REGION, MICROSOFT_CUSTOM_VOICE} = process.env;
+if (MICROSOFT_CUSTOM_API_KEY && MICROSOFT_DEPLOYMENT_ID && MICROSOFT_CUSTOM_REGION && MICROSOFT_CUSTOM_VOICE) {
+  test('\'say\' tests - microsoft custom voice', async(t) => {
+    clearModule.all();
+    const {srf, disconnect} = require('../app');
+
+    try {
+      await connect(srf);
+
+      // GIVEN
+      const verbs = [
+        {
+          verb: 'say',
+          text: 'hello',
+          synthesizer: {
+            vendor: 'microsoft',
+            voice: MICROSOFT_CUSTOM_VOICE,
+            options: {
+              deploymentId: MICROSOFT_DEPLOYMENT_ID,
+              apiKey: MICROSOFT_CUSTOM_API_KEY,
+              region: MICROSOFT_CUSTOM_REGION,
+            }
+          }
+        }
+      ];
+
+      const from = 'say_test_success';
+      provisionCallHook(from, verbs)
+
+      // THEN
+      await sippUac('uac-success-received-bye.xml', '172.38.0.10', from);
+      t.pass('say: succeeds when using microsoft custom voice');
+      disconnect();
+    } catch (err) {
+      console.log(`error received: ${err}`);
+      disconnect();
+      t.error(err);
+    }
+  });
+}

test/transcribe-tests.js

@@ -166,7 +166,7 @@ test('\'transcribe\' test - deepgram', async(t) => {
     // THEN
     await sippUac('uac-gather-account-creds-success.xml', '172.38.0.10', from);
     let obj = await getJSON(`http://127.0.0.1:3100/lastRequest/${from}_actionHook`);
-    t.ok(obj.body.speech.alternatives[0].transcript.toLowerCase().startsWith('i\'d like to speak to customer support'),
+    t.ok(obj.body.speech.alternatives[0].transcript.toLowerCase().includes('like to speak to customer support'),
       'transcribe: succeeds when using deepgram credentials');
 
     disconnect();
@@ -206,7 +206,7 @@ test('\'transcribe\' test - soniox', async(t) => {
     // THEN
     await sippUac('uac-gather-account-creds-success.xml', '172.38.0.10', from);
     let obj = await getJSON(`http://127.0.0.1:3100/lastRequest/${from}_actionHook`);
-    console.log(JSON.stringify(obj));
+    //console.log(JSON.stringify(obj));
     t.ok(obj.body.speech.alternatives[0].transcript.toLowerCase().startsWith('i\'d like to speak to customer support'),
       'transcribe: succeeds when using soniox credentials');