fix: Dockerfile to reduce vulnerabilities

bugfix: unnecessary call to stopTranscription in gather verb when only collecting digits
added call_termination_by on app call status (#168 )
2026-02-11 00:39:56 +00:00 · 2022-09-30 16:20:24 +00:00 · 2022-09-30 10:27:33 +01:00 · 2022-09-23 09:13:55 +02:00 · 2022-09-21 15:22:19 +02:00 · 2022-09-20 13:54:54 +02:00
10 changed files with 26 additions and 17 deletions
--- a/2
+++ b/2
@@ -1,4 +1,4 @@
-FROM --platform=linux/amd64 node:18.8.0-alpine as base
+FROM --platform=linux/amd64 node:18.10-alpine as base

 RUN apk --update --no-cache add --virtual .builds-deps build-base python3

--- a/lib/session/call-info.js
+++ b/lib/session/call-info.js
@@ -11,6 +11,7 @@ class CallInfo {
    let srf;
    this.direction = opts.direction;
    this.traceId = opts.traceId;
+    this.callTerminationBy = undefined;
    if (opts.req) {
      const u = opts.req.getParsedHeader('from');
      const uri = parseUri(u.uri);
@@ -119,7 +120,7 @@ class CallInfo {
      applicationSid: this.applicationSid,
      fsSipAddress: this.localSipAddress
    };
-    ['parentCallSid', 'originatingSipIp', 'originatingSipTrunkName'].forEach((prop) => {
+    ['parentCallSid', 'originatingSipIp', 'originatingSipTrunkName', 'callTerminationBy'].forEach((prop) => {
      if (this[prop]) obj[prop] = this[prop];
    });
    if (typeof this.duration === 'number') obj.duration = this.duration;
--- a/lib/session/call-session.js
+++ b/lib/session/call-session.js
@@ -638,6 +638,7 @@ class CallSession extends Emitter {
    this._onTasksDone();
    this._clearResources();

+
    if (!this.isConfirmCallSession && !this.isSmsCallSession) sessionTracker.remove(this.callSid);
  }

@@ -1188,6 +1189,7 @@ class CallSession extends Emitter {
    } catch (err) {
      if (err === CALLER_CANCELLED_ERR_MSG) {
        this.logger.error(err, 'caller canceled quickly before we could respond, ending call');
+        this.callInfo.callTerminationBy = 'caller';
        this._notifyCallStatusChange({
          callStatus: CallStatus.NoAnswer,
          sipStatus: 487,
@@ -1302,7 +1304,8 @@ class CallSession extends Emitter {
      this.dlg = await this.srf.createUAS(this.req, this.res, {
        headers: {
          'X-Trace-ID': this.req.locals.traceId,
-          'X-Call-Sid': this.req.locals.callSid
+          'X-Call-Sid': this.req.locals.callSid,
+          ...(this.applicationSid && {'X-Application-Sid': this.applicationSid})
        },
        localSdp: this.ep.local.sdp
      });
@@ -1494,8 +1497,9 @@ class CallSession extends Emitter {
        dlg.connected = false;
        dlg.destroy = origDestroy;
        const duration = moment().diff(this.dlg.connectTime, 'seconds');
+        this.callInfo.callTerminationBy = 'jambonz';
        this.emit('callStatusChange', {callStatus: CallStatus.Completed, duration});
-        this.logger.debug('CallSession: call terminated by jambones');
+        this.logger.debug('CallSession: call terminated by jambonz');
        this.rootSpan.setAttributes({'call.termination': 'hangup by jambonz'});
        origDestroy().catch((err) => this.logger.info({err}, 'CallSession - error destroying dialog'));
        if (this.wakeupResolver) {
--- a/lib/session/inbound-call-session.js
+++ b/lib/session/inbound-call-session.js
@@ -34,6 +34,7 @@ class InboundCallSession extends CallSession {

  _onCancel() {
    this.rootSpan.setAttributes({'call.termination': 'caller abandoned'});
+    this.callInfo.callTerminationBy = 'caller';
    this._notifyCallStatusChange({
      callStatus: CallStatus.NoAnswer,
      sipStatus: 487,
@@ -69,6 +70,7 @@ class InboundCallSession extends CallSession {
    assert(this.dlg.connectTime);
    const duration = moment().diff(this.dlg.connectTime, 'seconds');
    this.rootSpan.setAttributes({'call.termination': 'hangup by caller'});
+    this.callInfo.callTerminationBy = 'caller';
    this.emit('callStatusChange', {
      callStatus: CallStatus.Completed,
      duration
--- a/lib/session/rest-call-session.js
+++ b/lib/session/rest-call-session.js
@@ -44,6 +44,7 @@ class RestCallSession extends CallSession {
   * This is invoked when the called party hangs up, in order to calculate the call duration.
   */
  _callerHungup() {
+    this.callInfo.callTerminationBy = 'caller';
    const duration = moment().diff(this.dlg.connectTime, 'seconds');
    this.emit('callStatusChange', {callStatus: CallStatus.Completed, duration});
    this.logger.debug('RestCallSession: called party hung up');
--- a/lib/session/siprec-call-session.js
+++ b/lib/session/siprec-call-session.js
@@ -36,7 +36,8 @@ class SipRecCallSession extends InboundCallSession {
        headers: {
          'Content-Type': 'application/sdp',
          'X-Trace-ID': this.req.locals.traceId,
-          'X-Call-Sid': this.req.locals.callSid
+          'X-Call-Sid': this.req.locals.callSid,
+          ...(this.applicationSid && {'X-Application-Sid': this.applicationSid})
        },
        localSdp: combinedSdp
      });
--- a/lib/tasks/gather.js
+++ b/lib/tasks/gather.js
@@ -641,7 +641,7 @@ class TaskGather extends Task {
    }

    this.span.setAttributes({'stt.resolve': reason, 'stt.result': JSON.stringify(evt)});
-    if (this.ep && this.ep.connected) {
+    if (this.needsStt && this.ep && this.ep.connected) {
      this.ep.stopTranscription({vendor: this.vendor})
        .catch((err) => this.logger.error({err}, 'Error stopping transcription'));
    }
--- a/lib/utils/place-outdial.js
+++ b/lib/utils/place-outdial.js
@@ -67,7 +67,8 @@ class SingleDialer extends Emitter {
      ...opts.headers,
      ...(this.target.headers || {}),
      'X-Jambonz-Routing': this.target.type,
-      'X-Call-Sid': this.callSid
+      'X-Call-Sid': this.callSid,
+      ...(this.applicationSid && {'X-Application-Sid': this.applicationSid})
    };
    if (srf.locals.fsUUID) {
      opts.headers = {
--- a/package-lock.json
+++ b/package-lock.json
@@ -11,7 +11,7 @@
      "dependencies": {
        "@jambonz/db-helpers": "^0.6.18",
        "@jambonz/http-health-check": "^0.0.1",
-        "@jambonz/realtimedb-helpers": "^0.4.30",
+        "@jambonz/realtimedb-helpers": "^0.4.32",
        "@jambonz/stats-collector": "^0.1.6",
        "@jambonz/time-series": "^0.2.1",
        "@opentelemetry/api": "^1.1.0",
@@ -543,9 +543,9 @@
      }
    },
    "node_modules/@jambonz/realtimedb-helpers": {
-      "version": "0.4.30",
-      "resolved": "https://registry.npmjs.org/@jambonz/realtimedb-helpers/-/realtimedb-helpers-0.4.30.tgz",
-      "integrity": "sha512-bF1crcyz/sYDCnOX0odbI1KLZUo6TADc548MHX5/O2+gY6Yi6u9GdEaf2u5q5fgmpoJ+Qrf3fuiENxzro+Pq8g==",
+      "version": "0.4.32",
+      "resolved": "https://registry.npmjs.org/@jambonz/realtimedb-helpers/-/realtimedb-helpers-0.4.32.tgz",
+      "integrity": "sha512-m08rqFEg6I43JVwjiyt0ahvljxJ3YvL3xsKHMoSJw48hdy/8V4w9ovYnUNaZGhaerhJVw36fCfTk4YNlByTnVw==",
      "dependencies": {
        "@google-cloud/text-to-speech": "^3.4.0",
        "@jambonz/promisify-redis": "^0.0.6",
@@ -6669,9 +6669,9 @@
      }
    },
    "@jambonz/realtimedb-helpers": {
-      "version": "0.4.30",
-      "resolved": "https://registry.npmjs.org/@jambonz/realtimedb-helpers/-/realtimedb-helpers-0.4.30.tgz",
-      "integrity": "sha512-bF1crcyz/sYDCnOX0odbI1KLZUo6TADc548MHX5/O2+gY6Yi6u9GdEaf2u5q5fgmpoJ+Qrf3fuiENxzro+Pq8g==",
+      "version": "0.4.32",
+      "resolved": "https://registry.npmjs.org/@jambonz/realtimedb-helpers/-/realtimedb-helpers-0.4.32.tgz",
+      "integrity": "sha512-m08rqFEg6I43JVwjiyt0ahvljxJ3YvL3xsKHMoSJw48hdy/8V4w9ovYnUNaZGhaerhJVw36fCfTk4YNlByTnVw==",
      "requires": {
        "@google-cloud/text-to-speech": "^3.4.0",
        "@jambonz/promisify-redis": "^0.0.6",
--- a/package.json
+++ b/package.json
@@ -16,8 +16,7 @@
    "type": "git",
    "url": "https://github.com/jambonz/jambonz-feature-server.git"
  },
-  "bugs": {
-  },
+  "bugs": {},
  "scripts": {
    "start": "node app",
    "test": "NODE_ENV=test JAMBONES_HOSTING=1 HTTP_POOL=1 DRACHTIO_HOST=127.0.0.1 DRACHTIO_PORT=9060 DRACHTIO_SECRET=cymru JAMBONES_MYSQL_HOST=127.0.0.1 JAMBONES_MYSQL_PORT=3360 JAMBONES_MYSQL_USER=jambones_test JAMBONES_MYSQL_PASSWORD=jambones_test JAMBONES_MYSQL_DATABASE=jambones_test JAMBONES_REDIS_HOST=127.0.0.1 JAMBONES_REDIS_PORT=16379 JAMBONES_LOGLEVEL=error ENABLE_METRICS=0 HTTP_PORT=3000 JAMBONES_SBCS=172.38.0.10 JAMBONES_FREESWITCH=127.0.0.1:8022:ClueCon:docker-host JAMBONES_TIME_SERIES_HOST=127.0.0.1 JAMBONES_NETWORK_CIDR=172.38.0.0/16 node test/ ",
@@ -27,7 +26,7 @@
  "dependencies": {
    "@jambonz/db-helpers": "^0.6.18",
    "@jambonz/http-health-check": "^0.0.1",
-    "@jambonz/realtimedb-helpers": "^0.4.30",
+    "@jambonz/realtimedb-helpers": "^0.4.32",
    "@jambonz/stats-collector": "^0.1.6",
    "@jambonz/time-series": "^0.2.1",
    "@opentelemetry/api": "^1.1.0",
Author	SHA1	Message	Date
snyk-bot	ad228c54fb	fix: Dockerfile to reduce vulnerabilities	2022-09-30 16:20:24 +00:00
Dave Horton	218f2d6c67	bugfix: unnecessary call to stopTranscription in gather verb when only collecting digits	2022-09-30 10:27:33 +01:00
Joan	c2c8f00978	added call_termination_by on app call status (#168 ) Co-authored-by: Joan Salvatella <joan@bookline.io>	2022-09-23 09:13:55 +02:00
Dave Horton	32714d73f3	update to synthAudio with bugfix for writing TTS rtt stats for microsoft	2022-09-21 15:22:19 +02:00
Dave Horton	8da85ebd5a	include custom header X-Application-Sid to make it available to cdrs	2022-09-20 13:54:54 +02:00