mirror of
https://github.com/prowler-cloud/prowler.git
synced 2026-07-23 20:42:02 +00:00
chore: update CHANGELOG
This commit is contained in:
@@ -24,6 +24,7 @@ All notable changes to the **Prowler SDK** are documented in this file.
|
||||
- Add missing audit evidence for controls 1.1.4 and 2.5.5 for ISMS-P compliance. [(#8386)](https://github.com/prowler-cloud/prowler/pull/8386)
|
||||
- Use the correct @staticmethod decorator for `set_identity` and `set_session_config` methods in AwsProvider [(#8056)](https://github.com/prowler-cloud/prowler/pull/8056)
|
||||
- Use the correct default value for `role_session_name` and `session_duration` in AwsSetUpSession [(#8056)](https://github.com/prowler-cloud/prowler/pull/8056)
|
||||
- GitHub App authentication inconsistency where `--github-app-key` and `--github-app-key-path` were incorrectly aliased to the same parameter, causing confusion between file paths and key content [(#8422)](https://github.com/prowler-cloud/prowler/pull/8422)
|
||||
|
||||
---
|
||||
|
||||
|
||||
@@ -306,16 +306,13 @@ class GithubProvider(Provider):
|
||||
env_key = environ.get("GITHUB_APP_KEY", "")
|
||||
|
||||
if app_id and env_key:
|
||||
# Smart detection: check if env_key is file path or key content
|
||||
# Check if env_key is file path or key content
|
||||
if env_key.startswith("-----BEGIN"):
|
||||
# It's key content
|
||||
app_key = format_rsa_key(env_key)
|
||||
elif os.path.isfile(env_key):
|
||||
# It's a file path
|
||||
with open(env_key, "r") as rsa_key:
|
||||
app_key = rsa_key.read()
|
||||
else:
|
||||
# Invalid format
|
||||
raise GithubEnvironmentVariableError(
|
||||
file=os.path.basename(__file__),
|
||||
message="GITHUB_APP_KEY must contain either RSA key content (starting with -----BEGIN) or a valid file path.",
|
||||
|
||||
Reference in New Issue
Block a user