fix(api): reject non-object external provider secret

- Validate the secret is a JSON object before the no-schema path accepts it,
  so a list/string/null cannot be persisted and fail later at {**secret}
- Add parametrized coverage for list/string/null/int payloads
This commit is contained in:
StylusFrost
2026-06-01 21:35:34 +02:00
parent 77b2ffeb54
commit 116fb7083d
2 changed files with 17 additions and 0 deletions
@@ -52,6 +52,21 @@ class TestExternalProviderSecretValidation:
"external-template", {"anything": "goes"}
)
@pytest.mark.parametrize("bad_secret", [["a", "b"], "a-string", None, 42])
def test_secret_rejected_when_not_a_json_object(self, bad_secret):
"""Even with no declared schema, a non-object secret must be rejected so
a list/string/null cannot be persisted and blow up later at
``{**secret}``. See PR #11402 review (Alan-TheGentleman)."""
provider_class = MagicMock()
provider_class.get_credentials_schema.return_value = []
with patch(
"api.v1.serializers.SDKProvider.get_class", return_value=provider_class
):
with pytest.raises(ValidationError):
BaseWriteProviderSecretSerializer._validate_external_provider_secret(
"external-template", bad_secret
)
class TestProviderEnumSerializerField:
"""The provider field accepts whatever the SDK exposes (built-in or
+2
View File
@@ -1552,6 +1552,8 @@ class BaseWriteProviderSecretSerializer(BaseWriteSerializer):
Providers that declare no schema have their secret accepted as-is; the
credentials are then validated by the provider's ``test_connection``.
"""
if not isinstance(secret, dict):
raise serializers.ValidationError({"secret": ["Must be a JSON object."]})
schemas = SDKProvider.get_class(provider_type).get_credentials_schema()
if not schemas:
return