chore(elbv2): cleanup tests (#5553)

This commit is contained in:
sansns-aws
2024-10-28 16:45:01 -04:00
committed by GitHub
parent 3c6e06837c
commit 14f06d6497
7 changed files with 44 additions and 53 deletions
@@ -1,4 +1,3 @@
from re import search
from unittest import mock
from boto3 import client, resource
@@ -96,9 +95,9 @@ class Test_elbv2_deletion_protection:
assert len(result) == 1
assert result[0].status == "FAIL"
assert search(
"does not have deletion protection",
result[0].status_extended,
assert (
result[0].status_extended
== "ELBv2 my-lb does not have deletion protection enabled."
)
assert result[0].resource_id == "my-lb"
assert result[0].resource_arn == lb["LoadBalancerArn"]
@@ -159,9 +158,9 @@ class Test_elbv2_deletion_protection:
assert len(result) == 1
assert result[0].status == "PASS"
assert search(
"has deletion protection enabled",
result[0].status_extended,
assert (
result[0].status_extended
== "ELBv2 my-lb has deletion protection enabled."
)
assert result[0].resource_id == "my-lb"
assert result[0].resource_arn == lb["LoadBalancerArn"]
@@ -1,4 +1,3 @@
from re import search
from unittest import mock
from boto3 import client, resource
@@ -100,9 +99,9 @@ class Test_elbv2_desync_mitigation_mode:
assert len(result) == 1
assert result[0].status == "FAIL"
assert search(
"does not have desync mitigation mode set as strictest/defensive and is not dropping invalid header fields",
result[0].status_extended,
assert (
result[0].status_extended
== "ELBv2 ALB my-lb does not have desync mitigation mode set as strictest/defensive and is not dropping invalid header fields."
)
assert result[0].resource_id == "my-lb"
assert result[0].resource_arn == lb["LoadBalancerArn"]
@@ -168,9 +167,9 @@ class Test_elbv2_desync_mitigation_mode:
assert len(result) == 1
assert result[0].status == "PASS"
assert search(
"does not have desync mitigation mode set as strictest/defensive but is dropping invalid header fields",
result[0].status_extended,
assert (
result[0].status_extended
== "ELBv2 ALB my-lb does not have desync mitigation mode set as strictest/defensive but is dropping invalid header fields."
)
assert result[0].resource_id == "my-lb"
assert result[0].resource_arn == lb["LoadBalancerArn"]
@@ -231,9 +230,9 @@ class Test_elbv2_desync_mitigation_mode:
assert len(result) == 1
assert result[0].status == "PASS"
assert search(
"is configured with correct desync mitigation mode",
result[0].status_extended,
assert (
result[0].status_extended
== "ELBv2 ALB my-lb is configured with correct desync mitigation mode."
)
assert result[0].resource_id == "my-lb"
assert result[0].resource_arn == lb["LoadBalancerArn"]
@@ -1,4 +1,3 @@
from re import search
from unittest import mock
from boto3 import client, resource
@@ -113,9 +112,9 @@ class Test_elbv2_insecure_ssl_ciphers:
assert len(result) == 1
assert result[0].status == "PASS"
assert search(
"does not have insecure SSL protocols or ciphers",
result[0].status_extended,
assert (
result[0].status_extended
== "ELBv2 my-lb does not have insecure SSL protocols or ciphers."
)
assert result[0].resource_id == "my-lb"
assert result[0].resource_arn == lb["LoadBalancerArn"]
@@ -192,9 +191,9 @@ class Test_elbv2_insecure_ssl_ciphers:
assert len(result) == 1
assert result[0].status == "FAIL"
assert search(
"has listeners with insecure SSL protocols or ciphers",
result[0].status_extended,
assert (
result[0].status_extended
== "ELBv2 my-lb has listeners with insecure SSL protocols or ciphers (ELBSecurityPolicy-TLS-1-1-2017-01)."
)
assert result[0].resource_id == "my-lb"
assert result[0].resource_arn == lb["LoadBalancerArn"]
@@ -1,4 +1,3 @@
from re import search
from unittest import mock
from boto3 import client, resource
@@ -89,9 +88,8 @@ class Test_elbv2_listeners_underneath:
assert len(result) == 1
assert result[0].status == "FAIL"
assert search(
"has no listeners underneath",
result[0].status_extended,
assert (
result[0].status_extended == "ELBv2 my-lb has no listeners underneath."
)
assert result[0].resource_id == "my-lb"
assert result[0].resource_arn == lb["LoadBalancerArn"]
@@ -167,6 +165,6 @@ class Test_elbv2_listeners_underneath:
assert len(result) == 1
assert result[0].status == "PASS"
assert search("has listeners underneath", result[0].status_extended)
assert result[0].status_extended == "ELBv2 my-lb has listeners underneath."
assert result[0].resource_id == "my-lb"
assert result[0].resource_arn == lb["LoadBalancerArn"]
@@ -1,4 +1,3 @@
from re import search
from unittest import mock
from boto3 import client, resource
@@ -99,9 +98,9 @@ class Test_elbv2_logging_enabled:
assert len(result) == 1
assert result[0].status == "FAIL"
assert search(
"does not have access logs configured",
result[0].status_extended,
assert (
result[0].status_extended
== "ELBv2 ALB my-lb does not have access logs configured."
)
assert result[0].resource_id == "my-lb"
assert result[0].resource_arn == lb["LoadBalancerArn"]
@@ -165,9 +164,9 @@ class Test_elbv2_logging_enabled:
assert len(result) == 1
assert result[0].status == "PASS"
assert search(
"has access logs to S3 configured",
result[0].status_extended,
assert (
result[0].status_extended
== "ELBv2 ALB my-lb has access logs to S3 configured."
)
assert result[0].resource_id == "my-lb"
assert result[0].resource_arn == lb["LoadBalancerArn"]
@@ -1,4 +1,3 @@
from re import search
from unittest import mock
from boto3 import client, resource
@@ -111,9 +110,9 @@ class Test_elbv2_ssl_listeners:
assert len(result) == 1
assert result[0].status == "FAIL"
assert search(
"has non-encrypted listeners",
result[0].status_extended,
assert (
result[0].status_extended
== "ELBv2 ALB my-lb has non-encrypted listeners."
)
assert result[0].resource_id == "my-lb"
assert result[0].resource_arn == lb["LoadBalancerArn"]
@@ -189,9 +188,8 @@ class Test_elbv2_ssl_listeners:
assert len(result) == 1
assert result[0].status == "PASS"
assert search(
"has HTTPS listeners only",
result[0].status_extended,
assert (
result[0].status_extended == "ELBv2 ALB my-lb has HTTPS listeners only."
)
assert result[0].resource_id == "my-lb"
assert result[0].resource_arn == lb["LoadBalancerArn"]
@@ -260,9 +258,9 @@ class Test_elbv2_ssl_listeners:
assert len(result) == 1
assert result[0].status == "PASS"
assert search(
"has HTTP listener but it redirects to HTTPS",
result[0].status_extended,
assert (
result[0].status_extended
== "ELBv2 ALB my-lb has HTTP listener but it redirects to HTTPS."
)
assert result[0].resource_id == "my-lb"
assert result[0].resource_arn == lb["LoadBalancerArn"]
@@ -1,4 +1,3 @@
from re import search
from unittest import mock
import botocore
@@ -146,9 +145,9 @@ class Test_elbv2_waf_acl_attached:
assert len(result) == 1
assert result[0].status == "FAIL"
assert search(
"is not protected by WAF Web ACL",
result[0].status_extended,
assert (
result[0].status_extended
== "ELBv2 ALB my-lb is not protected by WAF Web ACL."
)
assert result[0].resource_id == "my-lb"
assert result[0].resource_arn == lb["LoadBalancerArn"]
@@ -233,9 +232,9 @@ class Test_elbv2_waf_acl_attached:
assert len(result) == 1
assert result[0].status == "PASS"
assert search(
"is protected by WAFv2 Web ACL",
result[0].status_extended,
assert (
result[0].status_extended
== "ELBv2 ALB my-lb is protected by WAFv2 Web ACL my-web-acl."
)
assert result[0].resource_id == "my-lb"
assert result[0].resource_arn == lb["LoadBalancerArn"]