refactor: rename entra_admin_portals_role_limited_access

This commit is contained in:
HugoPBrito committed 2025-03-13 19:54:35 +01:00
1 parent 3bf62f7b70
commit 1ab91b0cae
4 files changed
+19 -19

No files matched your search

@@ -1,6 +1,6 @@
{
"Provider": "microsoft365",
"CheckID": "entra_admin_portals_role_limited_access",
"CheckID": "entra_ca_policy_admin_portals_role_limited_access",
"CheckTitle": "Ensure that only administrative roles have access to Microsoft Admin Portals",
"CheckType": [],
"ServiceName": "entra",
@@ -7,7 +7,7 @@ from prowler.providers.microsoft365.services.entra.entra_service import (
)
class entra_admin_portals_role_limited_access(Check):
class entra_ca_policy_admin_portals_role_limited_access(Check):
"""Check if Conditional Access policies deny access to the Microsoft 365 admin center for users with limited access roles.
This check ensures that Conditional Access policies are in place to deny access to the Microsoft 365 admin center for users with limited access roles.
@@ -20,7 +20,7 @@ from tests.providers.microsoft365.microsoft365_fixtures import (
)
class Test_entra_admin_portals_role_limited_access:
class Test_entra_ca_policy_admin_portals_role_limited_access:
def test_entra_no_conditional_access_policies(self):
entra_client = mock.MagicMock
entra_client.audited_tenant = "audited_tenant"
@@ -31,17 +31,17 @@ class Test_entra_admin_portals_role_limited_access:
return_value=set_mocked_microsoft365_provider(),
),
mock.patch(
"prowler.providers.microsoft365.services.entra.entra_admin_portals_role_limited_access.entra_admin_portals_role_limited_access.entra_client",
"prowler.providers.microsoft365.services.entra.entra_ca_policy_admin_portals_role_limited_access.entra_ca_policy_admin_portals_role_limited_access.entra_client",
new=entra_client,
),
):
from prowler.providers.microsoft365.services.entra.entra_admin_portals_role_limited_access.entra_admin_portals_role_limited_access import (
entra_admin_portals_role_limited_access,
from prowler.providers.microsoft365.services.entra.entra_ca_policy_admin_portals_role_limited_access.entra_ca_policy_admin_portals_role_limited_access import (
entra_ca_policy_admin_portals_role_limited_access,
)
entra_client.conditional_access_policies = {}
check = entra_admin_portals_role_limited_access()
check = entra_ca_policy_admin_portals_role_limited_access()
result = check.execute()
assert len(result) == 1
assert result[0].status == "FAIL"
@@ -66,12 +66,12 @@ class Test_entra_admin_portals_role_limited_access:
return_value=set_mocked_microsoft365_provider(),
),
mock.patch(
"prowler.providers.microsoft365.services.entra.entra_admin_portals_role_limited_access.entra_admin_portals_role_limited_access.entra_client",
"prowler.providers.microsoft365.services.entra.entra_ca_policy_admin_portals_role_limited_access.entra_ca_policy_admin_portals_role_limited_access.entra_client",
new=entra_client,
),
):
from prowler.providers.microsoft365.services.entra.entra_admin_portals_role_limited_access.entra_admin_portals_role_limited_access import (
entra_admin_portals_role_limited_access,
from prowler.providers.microsoft365.services.entra.entra_ca_policy_admin_portals_role_limited_access.entra_ca_policy_admin_portals_role_limited_access import (
entra_ca_policy_admin_portals_role_limited_access,
)
from prowler.providers.microsoft365.services.entra.entra_service import (
ConditionalAccessPolicy,
@@ -112,7 +112,7 @@ class Test_entra_admin_portals_role_limited_access:
)
}
check = entra_admin_portals_role_limited_access()
check = entra_ca_policy_admin_portals_role_limited_access()
result = check.execute()
assert len(result) == 1
assert result[0].status == "FAIL"
@@ -138,12 +138,12 @@ class Test_entra_admin_portals_role_limited_access:
return_value=set_mocked_microsoft365_provider(),
),
mock.patch(
"prowler.providers.microsoft365.services.entra.entra_admin_portals_role_limited_access.entra_admin_portals_role_limited_access.entra_client",
"prowler.providers.microsoft365.services.entra.entra_ca_policy_admin_portals_role_limited_access.entra_ca_policy_admin_portals_role_limited_access.entra_client",
new=entra_client,
),
):
from prowler.providers.microsoft365.services.entra.entra_admin_portals_role_limited_access.entra_admin_portals_role_limited_access import (
entra_admin_portals_role_limited_access,
from prowler.providers.microsoft365.services.entra.entra_ca_policy_admin_portals_role_limited_access.entra_ca_policy_admin_portals_role_limited_access import (
entra_ca_policy_admin_portals_role_limited_access,
)
from prowler.providers.microsoft365.services.entra.entra_service import (
ConditionalAccessPolicy,
@@ -186,7 +186,7 @@ class Test_entra_admin_portals_role_limited_access:
)
}
check = entra_admin_portals_role_limited_access()
check = entra_ca_policy_admin_portals_role_limited_access()
result = check.execute()
assert len(result) == 1
assert result[0].status == "FAIL"
@@ -215,12 +215,12 @@ class Test_entra_admin_portals_role_limited_access:
return_value=set_mocked_microsoft365_provider(),
),
mock.patch(
"prowler.providers.microsoft365.services.entra.entra_admin_portals_role_limited_access.entra_admin_portals_role_limited_access.entra_client",
"prowler.providers.microsoft365.services.entra.entra_ca_policy_admin_portals_role_limited_access.entra_ca_policy_admin_portals_role_limited_access.entra_client",
new=entra_client,
),
):
from prowler.providers.microsoft365.services.entra.entra_admin_portals_role_limited_access.entra_admin_portals_role_limited_access import (
entra_admin_portals_role_limited_access,
from prowler.providers.microsoft365.services.entra.entra_ca_policy_admin_portals_role_limited_access.entra_ca_policy_admin_portals_role_limited_access import (
entra_ca_policy_admin_portals_role_limited_access,
)
from prowler.providers.microsoft365.services.entra.entra_service import (
ConditionalAccessPolicy,
@@ -263,7 +263,7 @@ class Test_entra_admin_portals_role_limited_access:
)
}
check = entra_admin_portals_role_limited_access()
check = entra_ca_policy_admin_portals_role_limited_access()
result = check.execute()
assert len(result) == 1
assert result[0].status == "PASS"