feat(teams): add new check teams_meeting_external_control_disabled (#7604)

Co-authored-by: Sergio Garcia <hello@mistercloudsec.com>
This commit is contained in:
Andoni Alonso
2025-04-25 16:59:36 +02:00
committed by GitHub
parent a51a185f49
commit 51db81aa5c
7 changed files with 201 additions and 0 deletions
+1
View File
@@ -30,6 +30,7 @@ All notable changes to the **Prowler SDK** are documented in this file.
- Add new check `teams_meeting_anonymous_user_start_disabled` [(#7567)](https://github.com/prowler-cloud/prowler/pull/7567)
- Add new check `teams_meeting_external_lobby_bypass_disabled` [(#7568)](https://github.com/prowler-cloud/prowler/pull/7568)
- Add new check `teams_meeting_dial_in_lobby_bypass_disabled` [(#7571)](https://github.com/prowler-cloud/prowler/pull/7571)
- Add new check `teams_meeting_external_control_disabled` [(#7604)](https://github.com/prowler-cloud/prowler/pull/7604)
- Add new check `teams_meeting_chat_anonymous_users_disabled` [(#7579)](https://github.com/prowler-cloud/prowler/pull/7579)
### Fixed
@@ -0,0 +1,30 @@
{
"Provider": "m365",
"CheckID": "teams_meeting_external_control_disabled",
"CheckTitle": "Ensure external participants can't give or request control",
"CheckType": [],
"ServiceName": "teams",
"SubServiceName": "",
"ResourceIdTemplate": "",
"Severity": "high",
"ResourceType": "Teams Global Meeting Policy",
"Description": "Ensure external participants can't give or request control in Teams meetings.",
"Risk": "Allowing external participants to give or request control during meetings could lead to unauthorized content sharing or malicious actions by external users.",
"RelatedUrl": "https://learn.microsoft.com/en-us/powershell/module/teams/set-csteamsmeetingpolicy?view=teams-ps",
"Remediation": {
"Code": {
"CLI": "Set-CsTeamsMeetingPolicy -Identity Global -AllowExternalParticipantGiveRequestControl $false",
"NativeIaC": "",
"Other": "1. Navigate to Microsoft Teams admin center https://admin.teams.microsoft.com. 2. Click to expand Meetings select Meeting policies. 3. Click Global (Org-wide default). 4. Under content sharing set External participants can give or request control to Off.",
"Terraform": ""
},
"Recommendation": {
"Text": "Disable the ability for external participants to give or request control during Teams meetings to prevent unauthorized content sharing and maintain meeting security.",
"Url": "https://learn.microsoft.com/en-us/powershell/module/teams/set-csteamsmeetingpolicy?view=teams-ps"
}
},
"Categories": [],
"DependsOn": [],
"RelatedTo": [],
"Notes": ""
}
@@ -0,0 +1,46 @@
from typing import List
from prowler.lib.check.models import Check, CheckReportM365
from prowler.providers.m365.services.teams.teams_client import teams_client
class teams_meeting_external_control_disabled(Check):
"""Check if external participants can't give or request control in meetings.
Attributes:
metadata: Metadata associated with the check (inherited from Check).
"""
def execute(self) -> List[CheckReportM365]:
"""Execute the check for external participants' control permissions in meetings.
This method checks if external participants are prevented from giving or requesting control in meetings.
Returns:
List[CheckReportM365]: A list of reports containing the result of the check.
"""
findings = []
global_meeting_policy = teams_client.global_meeting_policy
if global_meeting_policy:
report = CheckReportM365(
metadata=self.metadata(),
resource=global_meeting_policy if global_meeting_policy else {},
resource_name="Teams Meetings Global (Org-wide default) Policy",
resource_id="teamsMeetingsGlobalPolicy",
)
report.status = "FAIL"
report.status_extended = (
"External participants can give or request control."
)
if (
not global_meeting_policy.allow_external_participant_give_request_control
):
report.status = "PASS"
report.status_extended = (
"External participants cannot give or request control."
)
findings.append(report)
return findings
@@ -57,6 +57,9 @@ class Teams(M365Service):
allow_anonymous_users_to_start_meeting=global_meeting_policy.get(
"AllowAnonymousUsersToStartMeeting", True
),
allow_external_participant_give_request_control=global_meeting_policy.get(
"AllowExternalParticipantGiveRequestControl", True
),
allow_external_users_to_bypass_lobby=global_meeting_policy.get(
"AutoAdmittedUsers", "Everyone"
),
@@ -109,6 +112,7 @@ class TeamsSettings(BaseModel):
class GlobalMeetingPolicy(BaseModel):
allow_anonymous_users_to_join_meeting: bool = True
allow_anonymous_users_to_start_meeting: bool = True
allow_external_participant_give_request_control: bool = True
allow_external_users_to_bypass_lobby: str = "Everyone"
allow_pstn_users_to_bypass_lobby: bool = True
meeting_chat_enabled_type: str = "EnabledForEveryone"
@@ -0,0 +1,118 @@
from unittest import mock
from tests.providers.m365.m365_fixtures import DOMAIN, set_mocked_m365_provider
class Test_teams_meeting_external_control_disabled:
def test_no_global_meeting_policy(self):
teams_client = mock.MagicMock()
teams_client.global_meeting_policy = None
with (
mock.patch(
"prowler.providers.common.provider.Provider.get_global_provider",
return_value=set_mocked_m365_provider(),
),
mock.patch(
"prowler.providers.m365.lib.powershell.m365_powershell.M365PowerShell.connect_microsoft_teams"
),
mock.patch(
"prowler.providers.m365.services.teams.teams_meeting_external_control_disabled.teams_meeting_external_control_disabled.teams_client",
new=teams_client,
),
):
from prowler.providers.m365.services.teams.teams_meeting_external_control_disabled.teams_meeting_external_control_disabled import (
teams_meeting_external_control_disabled,
)
check = teams_meeting_external_control_disabled()
result = check.execute()
assert len(result) == 0
def test_external_participants_can_control(self):
teams_client = mock.MagicMock()
teams_client.audited_tenant = "audited_tenant"
teams_client.audited_domain = DOMAIN
with (
mock.patch(
"prowler.providers.common.provider.Provider.get_global_provider",
return_value=set_mocked_m365_provider(),
),
mock.patch(
"prowler.providers.m365.lib.powershell.m365_powershell.M365PowerShell.connect_microsoft_teams"
),
mock.patch(
"prowler.providers.m365.services.teams.teams_meeting_external_control_disabled.teams_meeting_external_control_disabled.teams_client",
new=teams_client,
),
):
from prowler.providers.m365.services.teams.teams_meeting_external_control_disabled.teams_meeting_external_control_disabled import (
teams_meeting_external_control_disabled,
)
from prowler.providers.m365.services.teams.teams_service import (
GlobalMeetingPolicy,
)
teams_client.global_meeting_policy = GlobalMeetingPolicy(
allow_external_participant_give_request_control=True
)
check = teams_meeting_external_control_disabled()
result = check.execute()
assert len(result) == 1
assert result[0].status == "FAIL"
assert (
result[0].status_extended
== "External participants can give or request control."
)
assert result[0].resource == teams_client.global_meeting_policy.dict()
assert (
result[0].resource_name
== "Teams Meetings Global (Org-wide default) Policy"
)
assert result[0].resource_id == "teamsMeetingsGlobalPolicy"
def test_external_participants_cannot_control(self):
teams_client = mock.MagicMock()
teams_client.audited_tenant = "audited_tenant"
teams_client.audited_domain = DOMAIN
with (
mock.patch(
"prowler.providers.common.provider.Provider.get_global_provider",
return_value=set_mocked_m365_provider(),
),
mock.patch(
"prowler.providers.m365.lib.powershell.m365_powershell.M365PowerShell.connect_microsoft_teams"
),
mock.patch(
"prowler.providers.m365.services.teams.teams_meeting_external_control_disabled.teams_meeting_external_control_disabled.teams_client",
new=teams_client,
),
):
from prowler.providers.m365.services.teams.teams_meeting_external_control_disabled.teams_meeting_external_control_disabled import (
teams_meeting_external_control_disabled,
)
from prowler.providers.m365.services.teams.teams_service import (
GlobalMeetingPolicy,
)
teams_client.global_meeting_policy = GlobalMeetingPolicy(
allow_external_participant_give_request_control=False
)
check = teams_meeting_external_control_disabled()
result = check.execute()
assert len(result) == 1
assert result[0].status == "PASS"
assert (
result[0].status_extended
== "External participants cannot give or request control."
)
assert result[0].resource == teams_client.global_meeting_policy.dict()
assert (
result[0].resource_name
== "Teams Meetings Global (Org-wide default) Policy"
)
assert result[0].resource_id == "teamsMeetingsGlobalPolicy"
@@ -28,6 +28,7 @@ def mock_get_global_meeting_policy(_):
return GlobalMeetingPolicy(
allow_anonymous_users_to_join_meeting=False,
allow_anonymous_users_to_start_meeting=False,
allow_external_participant_give_request_control=False,
allow_external_users_to_bypass_lobby="EveryoneInCompanyExcludingGuests",
allow_pstn_users_to_bypass_lobby=False,
meeting_chat_enabled_type="EnabledExceptAnonymous",
@@ -125,6 +126,7 @@ class Test_Teams_Service:
assert teams_client.global_meeting_policy == GlobalMeetingPolicy(
allow_anonymous_users_to_join_meeting=False,
allow_anonymous_users_to_start_meeting=False,
allow_external_participant_give_request_control=False,
allow_external_users_to_bypass_lobby="EveryoneInCompanyExcludingGuests",
allow_pstn_users_to_bypass_lobby=False,
meeting_chat_enabled_type="EnabledExceptAnonymous",