ben.carrasco/prowler
1
0
Fork 0
mirror of https://github.com/prowler-cloud/prowler.git synced 2026-01-25 02:08:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(tests): remove some comments

Browse Source
This commit is contained in:
Pepe Fagoaga
2026-01-19 21:43:42 +01:00
parent 7399dc94cf
commit 64e7d7e8cf
2 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/lib/timeline/models_test.py
View File

@@ -1,5 +1,3 @@
"""Tests for prowler.lib.timeline.models module."""
from datetime import datetime, timezone
import pytest
@@ -55,7 +53,10 @@ class TestTimelineEvent:
)
assert event.event_id == "full-event-id-456"
assert event.actor_uid == "arn:aws:sts::123456789012:assumed-role/admin-role/session"
assert (
event.actor_uid
== "arn:aws:sts::123456789012:assumed-role/admin-role/session"
)
assert event.source_ip_address == "192.168.1.100"
assert event.user_agent == "aws-cli/2.0.0"
assert event.request_parameters == {"bucket": "my-bucket", "acl": "private"}

14
tests/providers/aws/lib/cloudtrail_timeline/cloudtrail_timeline_test.py
View File

@@ -1,5 +1,3 @@
"""Tests for CloudTrail timeline service."""
import json
from datetime import datetime, timezone
from unittest.mock import MagicMock
@@ -250,13 +248,17 @@ class TestCloudTrailTimeline:
# Default: write_events_only=True
timeline = CloudTrailTimeline(session=mock_session)
result = timeline.get_resource_timeline(region="us-east-1", resource_id="sg-123")
result = timeline.get_resource_timeline(
region="us-east-1", resource_id="sg-123"
)
# Only the write event should be returned
assert len(result) == 1
assert result[0]["event_name"] == "CreateSecurityGroup"
def test_get_resource_timeline_includes_read_events_when_disabled(self, mock_session):
def test_get_resource_timeline_includes_read_events_when_disabled(
self, mock_session
):
"""Verify all events returned when write_events_only=False."""
events = [
{
@@ -285,7 +287,9 @@ class TestCloudTrailTimeline:
# Disable filtering
timeline = CloudTrailTimeline(session=mock_session, write_events_only=False)
result = timeline.get_resource_timeline(region="us-east-1", resource_id="sg-123")
result = timeline.get_resource_timeline(
region="us-east-1", resource_id="sg-123"
)
# All events should be returned
assert len(result) == 2