ben.carrasco/prowler
1
0
Fork 0
mirror of https://github.com/prowler-cloud/prowler.git synced 2026-07-23 20:42:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(ec2): add name from image information to status_extended (#5755)

Browse Source 
Co-authored-by: MrCloudSec <hello@mistercloudsec.com>
This commit is contained in:
Rubén De la Torre Vico
2024-11-13 20:30:58 +01:00
committed by GitHub
parent 794268cec5
commit 73361a1cea
3 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
prowler/providers/aws/services/ec2/ec2_ami_public/ec2_ami_public.py
+4 -3
View File
@@ -12,11 +12,12 @@ class ec2_ami_public(Check):
report.resource_arn = image.arn
report.resource_tags = image.tags
report.status = "PASS"
report.status_extended = f"EC2 AMI {image.id} is not public."
report.status_extended = (
f"EC2 AMI {image.name if image.name else image.id} is not public."
)
if image.public:
report.status = "FAIL"
report.status_extended = f"EC2 AMI {image.id} is currently public."
report.resource_id = image.id
report.status_extended = f"EC2 AMI {image.name if image.name else image.id} is currently public."
findings.append(report)
prowler/providers/aws/services/ec2/ec2_service.py
+1 -1
View File
@@ -357,7 +357,7 @@ class EC2(AWSService):
Image(
id=image["ImageId"],
arn=arn,
name=image.get("Name", None),
name=image.get("Name", ""),
public=image.get("Public", False),
region=regional_client.region,
tags=image.get("Tags"),
tests/providers/aws/services/ec2/ec2_ami_public/ec2_ami_public_test.py
+2 -4
View File
@@ -72,7 +72,7 @@ class Test_ec2_ami_public:
assert len(result) == 1
assert result[0].status == "PASS"
assert result[0].status_extended == f"EC2 AMI {image_id} is not public."
assert result[0].status_extended == "EC2 AMI test-ami is not public."
assert result[0].resource_id == image_id
assert (
result[0].resource_arn
@@ -124,9 +124,7 @@ class Test_ec2_ami_public:
assert len(result) == 1
assert result[0].status == "FAIL"
assert (
result[0].status_extended == f"EC2 AMI {image_id} is currently public."
)
assert result[0].status_extended == "EC2 AMI test-ami is currently public."
assert result[0].resource_id == image_id
assert (
result[0].resource_arn