ben.carrasco/prowler
1
0
Fork 0
mirror of https://github.com/prowler-cloud/prowler.git synced 2026-07-23 04:21:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ecs): Adjust code to the new ARN formats in the ECS service (#5312)

Browse Source 
Co-authored-by: Mario Rodriguez Lopez <101330800+MarioRgzLpz@users.noreply.github.com>
Co-authored-by: Sergio Garcia <38561120+sergargar@users.noreply.github.com>
This commit is contained in:
Prowler Bot
2024-10-07 22:41:57 +02:00
committed by GitHub
parent f84928c232
commit 8a808e4d5d
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
prowler/providers/aws/services/ecs/ecs_service.py
+3 -3
View File
@@ -35,7 +35,7 @@ class ECS(AWSService):
):
self.task_definitions[task_definition] = TaskDefinition(
# we want the family name without the revision
name=sub(":.*", "", task_definition.split("/")[1]),
name=sub(":.*", "", task_definition.split("/")[-1]),
arn=task_definition,
revision=task_definition.split(":")[-1],
region=regional_client.region,
@@ -111,7 +111,7 @@ class ECS(AWSService):
service_desc = describe_response["services"][0]
service_arn = service_desc["serviceArn"]
service_obj = Service(
name=sub(":.*", "", service_arn.split("/")[2]),
name=sub(":.*", "", service_arn.split("/")[-1]),
arn=service_arn,
region=cluster.region,
assign_public_ip=(
@@ -139,7 +139,7 @@ class ECS(AWSService):
is_resource_filtered(cluster, self.audit_resources)
):
self.clusters[cluster] = Cluster(
name=sub(":.*", "", cluster.split("/")[1]),
name=sub(":.*", "", cluster.split("/")[-1]),
arn=cluster,
region=regional_client.region,
)
tests/providers/aws/services/ecs/ecs_service_test.py
+3 -3
View File
@@ -12,7 +12,7 @@ def mock_make_api_call(self, operation_name, kwarg):
if operation_name == "ListTaskDefinitions":
return {
"taskDefinitionArns": [
"arn:aws:ecs:eu-west-1:123456789012:task-definition/test_ecs_task:1"
"arn:aws:ecs:eu-west-1:123456789012:task-definition/test_cluster_1/test_ecs_task:1"
]
}
if operation_name == "DescribeTaskDefinition":
@@ -117,7 +117,7 @@ class Test_ECS_Service:
aws_provider = set_mocked_aws_provider()
ecs = ECS(aws_provider)
task_arn = "arn:aws:ecs:eu-west-1:123456789012:task-definition/test_ecs_task:1"
task_arn = "arn:aws:ecs:eu-west-1:123456789012:task-definition/test_cluster_1/test_ecs_task:1"
assert len(ecs.task_definitions) == 1
assert ecs.task_definitions[task_arn].name == "test_ecs_task"
@@ -131,7 +131,7 @@ class Test_ECS_Service:
aws_provider = set_mocked_aws_provider()
ecs = ECS(aws_provider)
task_arn = "arn:aws:ecs:eu-west-1:123456789012:task-definition/test_ecs_task:1"
task_arn = "arn:aws:ecs:eu-west-1:123456789012:task-definition/test_cluster_1/test_ecs_task:1"
assert len(ecs.task_definitions) == 1
assert ecs.task_definitions[task_arn].name == "test_ecs_task"