ben.carrasco/prowler
1
0
Fork 0
mirror of https://github.com/prowler-cloud/prowler.git synced 2026-04-06 02:58:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: enhance status extended

Browse Source
This commit is contained in:
HugoPBrito
2026-01-12 16:24:40 +01:00
parent b11e074f41
commit 99d2736116
2 changed files with 4 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
prowler/providers/cloudflare/services/zones/zones_ssl_strict/zones_ssl_strict.py
View File

@@ -37,6 +37,6 @@ class zones_ssl_strict(Check):
report.status_extended = f"SSL/TLS encryption mode is set to {ssl_mode} for zone {zone.name}."
else:
report.status = "FAIL"
report.status_extended = f"SSL/TLS encryption mode is set to {ssl_mode} for zone {zone.name}."
report.status_extended = f"SSL/TLS encryption mode is set to {ssl_mode} for zone {zone.name}, which is not strict or full."
findings.append(report)
return findings

43
tests/providers/cloudflare/services/zones/zones_ssl_strict/zones_ssl_strict_test.py
View File

@@ -73,43 +73,6 @@ class Test_zones_ssl_strict:
== f"SSL/TLS encryption mode is set to strict for zone {ZONE_NAME}."
)
def test_zone_ssl_full_strict_mode(self):
zones_client = mock.MagicMock
zones_client.zones = {
ZONE_ID: CloudflareZone(
id=ZONE_ID,
name=ZONE_NAME,
status="active",
paused=False,
settings=CloudflareZoneSettings(
ssl_encryption_mode="full_strict",
),
)
}
with (
mock.patch(
"prowler.providers.common.provider.Provider.get_global_provider",
return_value=set_mocked_cloudflare_provider(),
),
mock.patch(
"prowler.providers.cloudflare.services.zones.zones_ssl_strict.zones_ssl_strict.zones_client",
new=zones_client,
),
):
from prowler.providers.cloudflare.services.zones.zones_ssl_strict.zones_ssl_strict import (
zones_ssl_strict,
)
check = zones_ssl_strict()
result = check.execute()
assert len(result) == 1
assert result[0].status == "PASS"
assert (
result[0].status_extended
== f"SSL/TLS encryption mode is set to full_strict for zone {ZONE_NAME}."
)
def test_zone_ssl_full_mode(self):
zones_client = mock.MagicMock
zones_client.zones = {
@@ -141,7 +104,7 @@ class Test_zones_ssl_strict:
check = zones_ssl_strict()
result = check.execute()
assert len(result) == 1
assert result[0].status == "FAIL"
assert result[0].status == "PASS"
assert (
result[0].status_extended
== f"SSL/TLS encryption mode is set to full for zone {ZONE_NAME}."
@@ -181,7 +144,7 @@ class Test_zones_ssl_strict:
assert result[0].status == "FAIL"
assert (
result[0].status_extended
== f"SSL/TLS encryption mode is set to flexible for zone {ZONE_NAME}."
== f"SSL/TLS encryption mode is set to flexible for zone {ZONE_NAME}, which is not strict or full."
)
def test_zone_ssl_off_mode(self):
@@ -218,5 +181,5 @@ class Test_zones_ssl_strict:
assert result[0].status == "FAIL"
assert (
result[0].status_extended
== f"SSL/TLS encryption mode is set to off for zone {ZONE_NAME}."
== f"SSL/TLS encryption mode is set to off for zone {ZONE_NAME}, which is not strict or full."
)