ben.carrasco/prowler
1
0
Fork 0
mirror of https://github.com/prowler-cloud/prowler.git synced 2026-07-23 12:31:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(ssm): add tags to ssm_managed_compliant_patching (#5245)

Browse Source 
Co-authored-by: Sergio <sergio@prowler.com>
This commit is contained in:
Rubén De la Torre Vico
2024-09-30 18:00:43 +02:00
committed by GitHub
parent 234f8c2958
commit c9ff96144d
2 changed files with 51 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
prowler/providers/aws/services/ssm/ssm_managed_compliant_patching/ssm_managed_compliant_patching.py
+6
View File
@@ -1,4 +1,5 @@
from prowler.lib.check.models import Check, Check_Report_AWS
from prowler.providers.aws.services.ec2.ec2_client import ec2_client
from prowler.providers.aws.services.ssm.ssm_client import ssm_client
from prowler.providers.aws.services.ssm.ssm_service import ResourceStatus
@@ -11,6 +12,11 @@ class ssm_managed_compliant_patching(Check):
report.region = resource.region
report.resource_id = resource.id
report.resource_arn = resource.arn
# Find tags of the instance in ec2_client
for instance in ec2_client.instances:
if instance.id == resource.id:
report.resource_tags = instance.tags
if resource.status == ResourceStatus.COMPLIANT:
report.status = "PASS"
report.status_extended = (
tests/providers/aws/services/ssm/ssm_managed_compliant_patching/ssm_managed_compliant_patching_test.py
+45 -1
View File
@@ -4,7 +4,11 @@ from prowler.providers.aws.services.ssm.ssm_service import (
ComplianceResource,
ResourceStatus,
)
from tests.providers.aws.utils import AWS_ACCOUNT_NUMBER, AWS_REGION_US_EAST_1
from tests.providers.aws.utils import (
AWS_ACCOUNT_NUMBER,
AWS_REGION_US_EAST_1,
set_mocked_aws_provider,
)
class Test_ssm_managed_compliant_patching:
@@ -37,10 +41,26 @@ class Test_ssm_managed_compliant_patching:
status=ResourceStatus.COMPLIANT,
)
}
ec2_client = mock.MagicMock
ec2_client.instances = [
mock.MagicMock(
id=instance_id,
tags=[
{"Key": "Name", "Value": "test_instance"},
{"Key": "Environment", "Value": "development"},
],
)
]
with mock.patch(
"prowler.providers.aws.services.ssm.ssm_service.SSM",
new=ssm_client,
), mock.patch(
"prowler.providers.common.provider.Provider.get_global_provider",
return_value=set_mocked_aws_provider([AWS_REGION_US_EAST_1]),
), mock.patch(
"prowler.providers.aws.services.ssm.ssm_managed_compliant_patching.ssm_managed_compliant_patching.ec2_client",
new=ec2_client,
):
# Test Check
from prowler.providers.aws.services.ssm.ssm_managed_compliant_patching.ssm_managed_compliant_patching import (
@@ -62,6 +82,10 @@ class Test_ssm_managed_compliant_patching:
result[0].status_extended
== f"EC2 managed instance {instance_id} is compliant."
)
assert result[0].resource_tags == [
{"Key": "Name", "Value": "test_instance"},
{"Key": "Environment", "Value": "development"},
]
def test_compliance_resources_non_compliant(self):
ssm_client = mock.MagicMock
@@ -75,10 +99,26 @@ class Test_ssm_managed_compliant_patching:
status=ResourceStatus.NON_COMPLIANT,
)
}
ec2_client = mock.MagicMock
ec2_client.instances = [
mock.MagicMock(
id=instance_id,
tags=[
{"Key": "Name", "Value": "test_instance"},
{"Key": "Environment", "Value": "development"},
],
)
]
with mock.patch(
"prowler.providers.aws.services.ssm.ssm_service.SSM",
new=ssm_client,
), mock.patch(
"prowler.providers.common.provider.Provider.get_global_provider",
return_value=set_mocked_aws_provider([AWS_REGION_US_EAST_1]),
), mock.patch(
"prowler.providers.aws.services.ssm.ssm_managed_compliant_patching.ssm_managed_compliant_patching.ec2_client",
new=ec2_client,
):
# Test Check
from prowler.providers.aws.services.ssm.ssm_managed_compliant_patching.ssm_managed_compliant_patching import (
@@ -100,3 +140,7 @@ class Test_ssm_managed_compliant_patching:
result[0].status_extended
== f"EC2 managed instance {instance_id} is non-compliant."
)
assert result[0].resource_tags == [
{"Key": "Name", "Value": "test_instance"},
{"Key": "Environment", "Value": "development"},
]