ben.carrasco/prowler
1
0
Fork 0
mirror of https://github.com/prowler-cloud/prowler.git synced 2026-07-23 20:42:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(gcp): iterate through service projects (#6549)

Browse Source 
Co-authored-by: pedrooot <pedromarting3@gmail.com>
This commit is contained in:
Sergio Garcia
2025-01-16 08:52:52 -05:00
committed by GitHub
parent 4280266a96
commit dd63c16a74
4 changed files with 44 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
prowler/providers/gcp/services/compute/compute_project_os_login_enabled/compute_project_os_login_enabled.py
+1 -1
View File
@@ -5,7 +5,7 @@ from prowler.providers.gcp.services.compute.compute_client import compute_client
class compute_project_os_login_enabled(Check):
def execute(self) -> Check_Report_GCP:
findings = []
for project in compute_client.projects:
for project in compute_client.compute_projects:
report = Check_Report_GCP(
metadata=self.metadata(),
resource_metadata=project,
prowler/providers/gcp/services/iam/iam_audit_logs_enabled/iam_audit_logs_enabled.py
+1 -1
View File
@@ -7,7 +7,7 @@ from prowler.providers.gcp.services.cloudresourcemanager.cloudresourcemanager_cl
class iam_audit_logs_enabled(Check):
def execute(self) -> Check_Report_GCP:
findings = []
for project in cloudresourcemanager_client.projects:
for project in cloudresourcemanager_client.cloud_resource_manager_projects:
report = Check_Report_GCP(
metadata=self.metadata(),
resource_metadata=project,
tests/providers/gcp/services/compute/compute_project_os_login_enabled/compute_project_os_login_enabled_test.py
+21 -2
View File
@@ -1,6 +1,7 @@
from re import search
from unittest import mock
from prowler.providers.gcp.models import GCPProject
from tests.providers.gcp.gcp_fixtures import GCP_PROJECT_ID, set_mocked_gcp_provider
@@ -35,7 +36,16 @@ class Test_compute_project_os_login_enabled:
compute_client = mock.MagicMock()
compute_client.project_ids = [GCP_PROJECT_ID]
compute_client.projects = [project]
compute_client.compute_projects = [project]
compute_client.projects = {
GCP_PROJECT_ID: GCPProject(
id=GCP_PROJECT_ID,
number="123456789012",
name="test",
labels={},
lifecycle_state="ACTIVE",
)
}
compute_client.region = "global"
with mock.patch(
@@ -72,7 +82,16 @@ class Test_compute_project_os_login_enabled:
compute_client = mock.MagicMock()
compute_client.project_ids = [GCP_PROJECT_ID]
compute_client.projects = [project]
compute_client.compute_projects = [project]
compute_client.projects = {
GCP_PROJECT_ID: GCPProject(
id=GCP_PROJECT_ID,
number="123456789012",
name="test",
labels={},
lifecycle_state="ACTIVE",
)
}
compute_client.region = "global"
with mock.patch(
tests/providers/gcp/services/iam/iam_audit_logs_enabled/iam_audit_logs_enabled_test.py
+21 -2
View File
@@ -1,6 +1,7 @@
from re import search
from unittest import mock
from prowler.providers.gcp.models import GCPProject
from tests.providers.gcp.gcp_fixtures import GCP_PROJECT_ID, set_mocked_gcp_provider
@@ -35,7 +36,16 @@ class Test_iam_audit_logs_enabled:
cloudresourcemanager_client = mock.MagicMock()
cloudresourcemanager_client.project_ids = [GCP_PROJECT_ID]
cloudresourcemanager_client.projects = [project1]
cloudresourcemanager_client.cloud_resource_manager_projects = [project1]
cloudresourcemanager_client.projects = {
GCP_PROJECT_ID: GCPProject(
id=GCP_PROJECT_ID,
number="123456789012",
name="test",
labels={},
lifecycle_state="ACTIVE",
)
}
cloudresourcemanager_client.region = "global"
with mock.patch(
@@ -72,7 +82,16 @@ class Test_iam_audit_logs_enabled:
cloudresourcemanager_client = mock.MagicMock()
cloudresourcemanager_client.project_ids = [GCP_PROJECT_ID]
cloudresourcemanager_client.projects = [project1]
cloudresourcemanager_client.cloud_resource_manager_projects = [project1]
cloudresourcemanager_client.projects = {
GCP_PROJECT_ID: GCPProject(
id=GCP_PROJECT_ID,
number="123456789012",
name="test",
labels={},
lifecycle_state="ACTIVE",
)
}
cloudresourcemanager_client.region = "global"
with mock.patch(