ben.carrasco/prowler
1
0
Fork 0
mirror of https://github.com/prowler-cloud/prowler.git synced 2026-07-24 04:51:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: fix some comments (#3900)

Browse Source
This commit is contained in:
tianzedavid
2024-04-30 19:43:55 +08:00
committed by GitHub
parent 86cb9f5838
commit e4154ed4a2
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dashboard/pages/overview.py
+2 -2
View File
@@ -222,7 +222,7 @@ else:
# Handle the case where there is location column
if "LOCATION" in data.columns:
data["REGION"] = data["LOCATION"]
# Hande the case where there is no region column
# Handle the case where there is no region column
if "REGION" not in data.columns:
data["REGION"] = "-"
# Handle the case where the region is null
@@ -685,7 +685,7 @@ def filter_data(
########################################################
"""Line PLOT 1"""
########################################################
# Formating date columns
# Formatting date columns
filtered_data_sp["TIMESTAMP_formatted"] = pd.to_datetime(
filtered_data_sp["TIMESTAMP"]
).dt.strftime("%Y-%m-%d")
docs/developer-guide/unit-testing.md
+1 -1
View File
@@ -410,7 +410,7 @@ Then, at the check_level when Python tries to import the client with `from prowl
### Services
For testing the AWS services we have to follow the same logic as with the AWS checks, we have to check if the AWS API calls made by the service are covered by Moto and we have to test the service `__init__` to verifiy that the information is being correctly retrieved.
For testing the AWS services we have to follow the same logic as with the AWS checks, we have to check if the AWS API calls made by the service are covered by Moto and we have to test the service `__init__` to verify that the information is being correctly retrieved.
The service tests could act as *Integration Tests* since we test how the service retrieves the information from the provider, but since Moto or the custom mock objects mocks that calls this test will fall into *Unit Tests*.
prowler/providers/aws/lib/service/service.py
+1 -1
View File
@@ -15,7 +15,7 @@ MAX_WORKERS = 10
class AWSService:
"""The AWSService class offers a parent class for each AWS Service to generate:
- AWS Regional Clients
- Shared information like the account ID and ARN, the the AWS partition and the checks audited
- Shared information like the account ID and ARN, the AWS partition and the checks audited
- AWS Session
- Thread pool for the __threading_call__
- Also handles if the AWS Service is Global