fix(azure): remove resource_name inside the Check_Report (#7420)

This commit is contained in:
Pedro Martín
2025-04-03 17:35:02 +02:00
committed by GitHub
parent 3202184718
commit e4d234fe03
6 changed files with 8 additions and 11 deletions
@@ -16,7 +16,6 @@ class defender_ensure_defender_for_databases_is_on(Check):
metadata=self.metadata(), resource=pricings["SqlServers"]
)
report.subscription = subscription
report.resource_name = "Defender plan Databases"
report.status = "PASS"
report.status_extended = f"Defender plan Defender for Databases from subscription {subscription} is set to ON (pricing tier standard)."
if (
@@ -8,8 +8,7 @@ class compute_project_os_login_enabled(Check):
for project in compute_client.compute_projects:
report = Check_Report_GCP(
metadata=self.metadata(),
resource=project,
resource_name=project.id,
resource=compute_client.projects[project.id],
project_id=project.id,
location=compute_client.region,
)
@@ -10,8 +10,7 @@ class iam_audit_logs_enabled(Check):
for project in cloudresourcemanager_client.cloud_resource_manager_projects:
report = Check_Report_GCP(
metadata=self.metadata(),
resource=project,
resource_name=project.id,
resource=cloudresourcemanager_client.projects[project.id],
project_id=project.id,
location=cloudresourcemanager_client.region,
)
@@ -214,7 +214,7 @@ class Test_defender_ensure_defender_for_databases_is_on:
== f"Defender plan Defender for Databases from subscription {AZURE_SUBSCRIPTION_ID} is set to ON (pricing tier standard)."
)
assert result[0].subscription == AZURE_SUBSCRIPTION_ID
assert result[0].resource_name == "Defender plan Databases"
assert result[0].resource_name == "Defender plan Servers"
assert result[0].resource_id == resource_id
def test_defender_databases_cosmosdb_not_standard(self):
@@ -272,5 +272,5 @@ class Test_defender_ensure_defender_for_databases_is_on:
== f"Defender plan Defender for Databases from subscription {AZURE_SUBSCRIPTION_ID} is set to OFF (pricing tier not standard)."
)
assert result[0].subscription == AZURE_SUBSCRIPTION_ID
assert result[0].resource_name == "Defender plan Databases"
assert result[0].resource_name == "Defender plan Servers"
assert result[0].resource_id == resource_id
@@ -75,7 +75,7 @@ class Test_compute_project_os_login_enabled:
result[0].status_extended,
)
assert result[0].resource_id == project.id
assert result[0].resource_name == project.id
assert result[0].resource_name == "test"
assert result[0].location == "global"
assert result[0].project_id == GCP_PROJECT_ID
@@ -125,6 +125,6 @@ class Test_compute_project_os_login_enabled:
result[0].status_extended,
)
assert result[0].resource_id == project.id
assert result[0].resource_name == project.id
assert result[0].resource_name == "test"
assert result[0].location == "global"
assert result[0].project_id == GCP_PROJECT_ID
@@ -76,7 +76,7 @@ class Test_iam_audit_logs_enabled:
r.status_extended,
)
assert r.resource_id == GCP_PROJECT_ID
assert r.resource_name == GCP_PROJECT_ID
assert r.resource_name == "test"
assert r.project_id == GCP_PROJECT_ID
assert r.location == cloudresourcemanager_client.region
@@ -126,6 +126,6 @@ class Test_iam_audit_logs_enabled:
r.status_extended,
)
assert r.resource_id == GCP_PROJECT_ID
assert r.resource_name == GCP_PROJECT_ID
assert r.resource_name == "test"
assert r.project_id == GCP_PROJECT_ID
assert r.location == cloudresourcemanager_client.region