feat(teams): add new check teams_meeting_recording_disabled (#7607)

Co-authored-by: Sergio Garcia <hello@mistercloudsec.com>
This commit is contained in:
Andoni Alonso
2025-04-25 18:35:54 +02:00
committed by Pepe Fagoaga
parent be2965d274
commit e50d779e34
7 changed files with 195 additions and 0 deletions
+1
View File
@@ -32,6 +32,7 @@ All notable changes to the **Prowler SDK** are documented in this file.
- Add new check `teams_meeting_dial_in_lobby_bypass_disabled` [(#7571)](https://github.com/prowler-cloud/prowler/pull/7571)
- Add new check `teams_meeting_external_control_disabled` [(#7604)](https://github.com/prowler-cloud/prowler/pull/7604)
- Add new check `teams_meeting_external_chat_disabled` [(#7605)](https://github.com/prowler-cloud/prowler/pull/7605)
- Add new check `teams_meeting_recording_disabled` [(#7607)](https://github.com/prowler-cloud/prowler/pull/7607)
- Add new check `teams_meeting_chat_anonymous_users_disabled` [(#7579)](https://github.com/prowler-cloud/prowler/pull/7579)
### Fixed
@@ -0,0 +1,30 @@
{
"Provider": "m365",
"CheckID": "teams_meeting_recording_disabled",
"CheckTitle": "Ensure meeting recording is disabled by default",
"CheckType": [],
"ServiceName": "teams",
"SubServiceName": "",
"ResourceIdTemplate": "",
"Severity": "high",
"ResourceType": "Teams Global Meeting Policy",
"Description": "Ensures that only authorized users, such as organizers, co-organizers, and leads, can initiate a recording.",
"Risk": "Allowing meeting recordings by default increases the risk of unauthorized individuals capturing and potentially sharing sensitive meeting content.",
"RelatedUrl": "https://learn.microsoft.com/en-us/powershell/module/teams/set-csteamsmeetingpolicy?view=teams-ps",
"Remediation": {
"Code": {
"CLI": "Set-CsTeamsMeetingPolicy -Identity Global -AllowCloudRecording $false",
"NativeIaC": "",
"Other": "1. Navigate to Microsoft Teams admin center https://admin.teams.microsoft.com. 2. Click to expand Meetings select Meeting policies. 3. Click Global (Org-wide default). 4. Under Recording & transcription set Meeting recording to Off.",
"Terraform": ""
},
"Recommendation": {
"Text": "Disable meeting recording in the Global meeting policy to ensure only authorized users can initiate recordings. Create separate policies for users or groups who need recording capabilities.",
"Url": "https://learn.microsoft.com/en-us/powershell/module/teams/set-csteamsmeetingpolicy?view=teams-ps"
}
},
"Categories": [],
"DependsOn": [],
"RelatedTo": [],
"Notes": ""
}
@@ -0,0 +1,40 @@
from typing import List
from prowler.lib.check.models import Check, CheckReportM365
from prowler.providers.m365.services.teams.teams_client import teams_client
class teams_meeting_recording_disabled(Check):
"""Check if meeting recording is disabled by default.
Attributes:
metadata: Metadata associated with the check (inherited from Check).
"""
def execute(self) -> List[CheckReportM365]:
"""Execute the check for meeting recording settings.
This method checks if meeting recording is disabled in the Global meeting policy.
Returns:
List[CheckReportM365]: A list of reports containing the result of the check.
"""
findings = []
global_meeting_policy = teams_client.global_meeting_policy
if global_meeting_policy:
report = CheckReportM365(
metadata=self.metadata(),
resource=global_meeting_policy if global_meeting_policy else {},
resource_name="Teams Meetings Global (Org-wide default) Policy",
resource_id="teamsMeetingsGlobalPolicy",
)
report.status = "FAIL"
report.status_extended = "Meeting recording is enabled by default."
if not global_meeting_policy.allow_cloud_recording:
report.status = "PASS"
report.status_extended = "Meeting recording is disabled by default."
findings.append(report)
return findings
@@ -69,6 +69,9 @@ class Teams(M365Service):
allow_external_non_trusted_meeting_chat=global_meeting_policy.get(
"AllowExternalNonTrustedMeetingChat", True
),
allow_cloud_recording=global_meeting_policy.get(
"AllowCloudRecording", True
),
meeting_chat_enabled_type=global_meeting_policy.get(
"MeetingChatEnabledType", "EnabledForEveryone"
),
@@ -117,6 +120,7 @@ class GlobalMeetingPolicy(BaseModel):
allow_anonymous_users_to_start_meeting: bool = True
allow_external_participant_give_request_control: bool = True
allow_external_non_trusted_meeting_chat: bool = True
allow_cloud_recording: bool = True
allow_external_users_to_bypass_lobby: str = "Everyone"
allow_pstn_users_to_bypass_lobby: bool = True
meeting_chat_enabled_type: str = "EnabledForEveryone"
@@ -0,0 +1,118 @@
from unittest import mock
from tests.providers.m365.m365_fixtures import DOMAIN, set_mocked_m365_provider
class Test_teams_meeting_recording_disabled:
def test_no_global_meeting_policy(self):
teams_client = mock.MagicMock()
teams_client.global_meeting_policy = None
teams_client.audited_tenant = "audited_tenant"
teams_client.audited_domain = DOMAIN
with (
mock.patch(
"prowler.providers.common.provider.Provider.get_global_provider",
return_value=set_mocked_m365_provider(),
),
mock.patch(
"prowler.providers.m365.lib.powershell.m365_powershell.M365PowerShell.connect_microsoft_teams"
),
mock.patch(
"prowler.providers.m365.services.teams.teams_meeting_recording_disabled.teams_meeting_recording_disabled.teams_client",
new=teams_client,
),
):
from prowler.providers.m365.services.teams.teams_meeting_recording_disabled.teams_meeting_recording_disabled import (
teams_meeting_recording_disabled,
)
check = teams_meeting_recording_disabled()
result = check.execute()
assert len(result) == 0
def test_meeting_recording_enabled(self):
teams_client = mock.MagicMock()
teams_client.audited_tenant = "audited_tenant"
teams_client.audited_domain = DOMAIN
with (
mock.patch(
"prowler.providers.common.provider.Provider.get_global_provider",
return_value=set_mocked_m365_provider(),
),
mock.patch(
"prowler.providers.m365.lib.powershell.m365_powershell.M365PowerShell.connect_microsoft_teams"
),
mock.patch(
"prowler.providers.m365.services.teams.teams_meeting_recording_disabled.teams_meeting_recording_disabled.teams_client",
new=teams_client,
),
):
from prowler.providers.m365.services.teams.teams_meeting_recording_disabled.teams_meeting_recording_disabled import (
teams_meeting_recording_disabled,
)
from prowler.providers.m365.services.teams.teams_service import (
GlobalMeetingPolicy,
)
teams_client.global_meeting_policy = GlobalMeetingPolicy(
allow_cloud_recording=True
)
check = teams_meeting_recording_disabled()
result = check.execute()
assert len(result) == 1
assert result[0].status == "FAIL"
assert (
result[0].status_extended == "Meeting recording is enabled by default."
)
assert result[0].resource == teams_client.global_meeting_policy.dict()
assert (
result[0].resource_name
== "Teams Meetings Global (Org-wide default) Policy"
)
assert result[0].resource_id == "teamsMeetingsGlobalPolicy"
def test_meeting_recording_disabled(self):
teams_client = mock.MagicMock()
teams_client.audited_tenant = "audited_tenant"
teams_client.audited_domain = DOMAIN
with (
mock.patch(
"prowler.providers.common.provider.Provider.get_global_provider",
return_value=set_mocked_m365_provider(),
),
mock.patch(
"prowler.providers.m365.lib.powershell.m365_powershell.M365PowerShell.connect_microsoft_teams"
),
mock.patch(
"prowler.providers.m365.services.teams.teams_meeting_recording_disabled.teams_meeting_recording_disabled.teams_client",
new=teams_client,
),
):
from prowler.providers.m365.services.teams.teams_meeting_recording_disabled.teams_meeting_recording_disabled import (
teams_meeting_recording_disabled,
)
from prowler.providers.m365.services.teams.teams_service import (
GlobalMeetingPolicy,
)
teams_client.global_meeting_policy = GlobalMeetingPolicy(
allow_cloud_recording=False
)
check = teams_meeting_recording_disabled()
result = check.execute()
assert len(result) == 1
assert result[0].status == "PASS"
assert (
result[0].status_extended == "Meeting recording is disabled by default."
)
assert result[0].resource == teams_client.global_meeting_policy.dict()
assert (
result[0].resource_name
== "Teams Meetings Global (Org-wide default) Policy"
)
assert result[0].resource_id == "teamsMeetingsGlobalPolicy"
@@ -30,6 +30,7 @@ def mock_get_global_meeting_policy(_):
allow_anonymous_users_to_start_meeting=False,
allow_external_participant_give_request_control=False,
allow_external_non_trusted_meeting_chat=False,
allow_cloud_recording=False,
allow_external_users_to_bypass_lobby="EveryoneInCompanyExcludingGuests",
allow_pstn_users_to_bypass_lobby=False,
meeting_chat_enabled_type="EnabledExceptAnonymous",
@@ -129,6 +130,7 @@ class Test_Teams_Service:
allow_anonymous_users_to_start_meeting=False,
allow_external_participant_give_request_control=False,
allow_external_non_trusted_meeting_chat=False,
allow_cloud_recording=False,
allow_external_users_to_bypass_lobby="EveryoneInCompanyExcludingGuests",
allow_pstn_users_to_bypass_lobby=False,
meeting_chat_enabled_type="EnabledExceptAnonymous",