fix(ui): prevent rescheduling scans during credential update (#10851)

ui/CHANGELOG.md

@@ -8,6 +8,10 @@ All notable changes to the **Prowler UI** are documented in this file.
 
 - Allows tenant owners to expel users from their organizations  [(#10787)](https://github.com/prowler-cloud/prowler/pull/10787)
 
+### 🐞 Fixed
+
+- Provider wizard no longer advances to the Launch Scan step when rotating credentials: the modal closes after a successful connection test, preventing inadvertent scan rescheduling during credential updates [(#10851)](https://github.com/prowler-cloud/prowler/pull/10851)
+
 ### ❌ Removed
 
 - Redesign compliance page with a horizontal ThreatScore card (always-visible pillar breakdown + ActionDropdown), client-side search for compliance frameworks, compact scan selector trigger, responsive mobile filters, download-started toasts for CSV/PDF exports, enhanced compliance cards with truncated titles, and Alert-based empty/error states; migrate Progress component from HeroUI to shadcn [(#10767)](https://github.com/prowler-cloud/prowler/pull/10767)

ui/components/providers/wizard/hooks/use-provider-wizard-controller.test.tsx

@@ -153,7 +153,7 @@ describe("useProviderWizardController", () => {
     expect(onOpenChange).not.toHaveBeenCalled();
   });
 
-  it("moves to launch step after a successful connection test in update mode", async () => {
+  it("closes the wizard after a successful connection test in update mode", async () => {
     // Given
     const onOpenChange = vi.fn();
     const { result } = renderHook(() =>
@@ -181,9 +181,10 @@ describe("useProviderWizardController", () => {
       result.current.handleTestSuccess();
     });
 
-    // Then
-    expect(result.current.currentStep).toBe(PROVIDER_WIZARD_STEP.LAUNCH);
-    expect(onOpenChange).not.toHaveBeenCalled();
+    // Then: credential rotation never surfaces the launch/schedule step
+    expect(onOpenChange).toHaveBeenCalledWith(false);
+    expect(refreshMock).toHaveBeenCalledTimes(1);
+    expect(result.current.currentStep).not.toBe(PROVIDER_WIZARD_STEP.LAUNCH);
   });
 
   it("does not override launch footer config in the controller", () => {

ui/components/providers/wizard/hooks/use-provider-wizard-controller.ts

@@ -197,6 +197,12 @@ export function useProviderWizardController({
   };
 
   const handleTestSuccess = () => {
+    if (
+      useProviderWizardStore.getState().mode === PROVIDER_WIZARD_MODE.UPDATE
+    ) {
+      handleClose();
+      return;
+    }
     setCurrentStep(PROVIDER_WIZARD_STEP.LAUNCH);
   };
 
@@ -234,6 +240,7 @@ export function useProviderWizardController({
     handleTestSuccess,
     isOrgDirectEntry,
     isProviderFlow,
+    mode,
     modalTitle,
     openOrganizationsFlow,
     orgCurrentStep,

ui/components/providers/wizard/provider-wizard-modal.tsx

@@ -10,7 +10,10 @@ import { DialogHeader, DialogTitle } from "@/components/shadcn/dialog";
 import { Modal } from "@/components/shadcn/modal";
 import { useScrollHint } from "@/hooks/use-scroll-hint";
 import { ORG_SETUP_PHASE, ORG_WIZARD_STEP } from "@/types/organizations";
-import { PROVIDER_WIZARD_STEP } from "@/types/provider-wizard";
+import {
+  PROVIDER_WIZARD_MODE,
+  PROVIDER_WIZARD_STEP,
+} from "@/types/provider-wizard";
 
 import { useProviderWizardController } from "./hooks/use-provider-wizard-controller";
 import {
@@ -23,7 +26,12 @@ import { WIZARD_FOOTER_ACTION_TYPE } from "./steps/footer-controls";
 import { LaunchStep } from "./steps/launch-step";
 import { TestConnectionStep } from "./steps/test-connection-step";
 import type { OrgWizardInitialData, ProviderWizardInitialData } from "./types";
-import { WizardStepper } from "./wizard-stepper";
+import { PROVIDER_WIZARD_STEPS, WizardStepper } from "./wizard-stepper";
+
+const UPDATE_MODE_WIZARD_STEPS = PROVIDER_WIZARD_STEPS.slice(
+  0,
+  PROVIDER_WIZARD_STEP.LAUNCH,
+);
 
 interface ProviderWizardModalProps {
   open: boolean;
@@ -47,6 +55,7 @@ export function ProviderWizardModal({
     handleTestSuccess,
     isOrgDirectEntry,
     isProviderFlow,
+    mode,
     modalTitle,
     openOrganizationsFlow,
     orgCurrentStep,
@@ -97,7 +106,14 @@ export function ProviderWizardModal({
       <div className="mt-6 flex min-h-0 flex-1 flex-col overflow-hidden lg:mt-8 lg:flex-row">
         <div className="mb-4 box-border w-full shrink-0 lg:mb-0 lg:w-[328px]">
           {isProviderFlow ? (
-            <WizardStepper currentStep={currentStep} />
+            <WizardStepper
+              currentStep={currentStep}
+              steps={
+                mode === PROVIDER_WIZARD_MODE.UPDATE
+                  ? UPDATE_MODE_WIZARD_STEPS
+                  : undefined
+              }
+            />
           ) : (
             <WizardStepper
               currentStep={orgCurrentStep}

ui/components/providers/wizard/wizard-stepper.tsx

@@ -7,17 +7,18 @@ import { ProwlerShort } from "@/components/icons/prowler/ProwlerIcons";
 import { cn } from "@/lib/utils";
 import { IconComponent, IconSvgProps } from "@/types/components";
 
-interface WizardStepperProps {
-  currentStep: number;
-  stepOffset?: number;
-}
-
 interface StepConfig {
   label: string;
   description: string;
   icon: IconComponent;
 }
 
+interface WizardStepperProps {
+  currentStep: number;
+  stepOffset?: number;
+  steps?: StepConfig[];
+}
+
 const STEPS: StepConfig[] = [
   {
     label: "Link a Cloud Provider",
@@ -43,18 +44,21 @@ const STEPS: StepConfig[] = [
   },
 ];
 
+export const PROVIDER_WIZARD_STEPS = STEPS;
+
 export function WizardStepper({
   currentStep,
   stepOffset = 0,
+  steps = STEPS,
 }: WizardStepperProps) {
   const activeVisualStep = Math.max(
     0,
-    Math.min(currentStep + stepOffset, STEPS.length - 1),
+    Math.min(currentStep + stepOffset, steps.length - 1),
   );
 
   return (
     <nav aria-label="Wizard progress" className="flex flex-col gap-0">
-      {STEPS.map((step, index) => {
+      {steps.map((step, index) => {
         const isComplete = index < activeVisualStep;
         const isActive = index === activeVisualStep;
         const isInactive = index > activeVisualStep;
@@ -67,7 +71,7 @@ export function WizardStepper({
                 isActive={isActive}
                 icon={step.icon}
               />
-              {index < STEPS.length - 1 && (
+              {index < steps.length - 1 && (
                 <StepConnector isComplete={isComplete} />
               )}
             </div>