ben.carrasco/prowler
1
0
Fork 0
mirror of https://github.com/prowler-cloud/prowler.git synced 2026-01-25 02:08:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(kafka): false positives in kafka_cluster_is_public check (#8514)

Browse Source
This commit is contained in:
Hugo Pereira Brito
2025-08-13 09:05:09 +02:00
committed by GitHub
parent d9f3a6b88e
commit f5b1532647
3 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
prowler/CHANGELOG.md
View File

@@ -23,6 +23,7 @@ All notable changes to the **Prowler SDK** are documented in this file.
- Validation errors in Azure and M365 providers [(#8353)](https://github.com/prowler-cloud/prowler/pull/8353)
- Azure `app_http_logs_enabled` check false positives [(#8507)](https://github.com/prowler-cloud/prowler/pull/8507)
- Azure `storage_geo_redundant_enabled` check false positives [(#8504)](https://github.com/prowler-cloud/prowler/pull/8504)
- AWS `kafka_cluster_is_public` check false positives [(#8514)](https://github.com/prowler-cloud/prowler/pull/8514)
---

6
prowler/providers/aws/services/kafka/kafka_cluster_is_public/kafka_cluster_is_public.py
View File

@@ -10,13 +10,13 @@ class kafka_cluster_is_public(Check):
report = Check_Report_AWS(metadata=self.metadata(), resource=cluster)
report.status = "FAIL"
report.status_extended = (
f"Kafka cluster '{cluster.name}' is publicly accessible."
f"Kafka cluster {cluster.name} is publicly accessible."
)
if cluster.public_access:
if not cluster.public_access:
report.status = "PASS"
report.status_extended = (
f"Kafka cluster '{cluster.name}' is not publicly accessible."
f"Kafka cluster {cluster.name} is not publicly accessible."
)
findings.append(report)

8
tests/providers/aws/services/kafka/kafka_cluster_is_public/kafka_cluster_is_public_test.py
View File

@@ -72,10 +72,10 @@ class Test_kafka_cluster_is_public:
result = check.execute()
assert len(result) == 1
assert result[0].status == "FAIL"
assert result[0].status == "PASS"
assert (
result[0].status_extended
== "Kafka cluster 'demo-cluster-1' is publicly accessible."
== "Kafka cluster demo-cluster-1 is not publicly accessible."
)
assert (
result[0].resource_arn
@@ -126,10 +126,10 @@ class Test_kafka_cluster_is_public:
result = check.execute()
assert len(result) == 1
assert result[0].status == "PASS"
assert result[0].status == "FAIL"
assert (
result[0].status_extended
== "Kafka cluster 'demo-cluster-1' is not publicly accessible."
== "Kafka cluster demo-cluster-1 is publicly accessible."
)
assert (
result[0].resource_arn