ben.carrasco/prowler
1
0
Fork 0
mirror of https://github.com/prowler-cloud/prowler.git synced 2026-04-14 08:28:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sdk): simplify guest MFA policy messages

Browse Source 
- remove single quotes around policy names in status messages
- align regression tests with the updated wording
This commit is contained in:
Hugo P.Brito
2026-04-09 14:54:21 +01:00
parent 4015e5e6b3
commit fc59b3cb45
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
prowler/providers/m365/services/entra/entra_conditional_access_policy_mfa_enforced_for_guest_users/entra_conditional_access_policy_mfa_enforced_for_guest_users.py
View File

@@ -120,7 +120,7 @@ class entra_conditional_access_policy_mfa_enforced_for_guest_users(Check):
resource_id=policy.id,
)
report.status = "PASS"
report.status_extended = f"Conditional Access Policy '{policy.display_name}' requires MFA for guest users."
report.status_extended = f"Conditional Access Policy {policy.display_name} requires MFA for guest users."
break
if (
@@ -137,7 +137,7 @@ class entra_conditional_access_policy_mfa_enforced_for_guest_users(Check):
resource_id=reporting_policy.id,
)
report.status = "FAIL"
report.status_extended = f"Conditional Access Policy '{reporting_policy.display_name}' targets guest users with MFA but is only in report-only mode."
report.status_extended = f"Conditional Access Policy {reporting_policy.display_name} targets guest users with MFA but is only in report-only mode."
findings.append(report)
return findings

6
tests/providers/m365/services/entra/entra_conditional_access_policy_mfa_enforced_for_guest_users/entra_conditional_access_policy_mfa_enforced_for_guest_users_test.py
View File

@@ -184,7 +184,7 @@ class Test_entra_conditional_access_policy_mfa_enforced_for_guest_users:
assert result[0].status == "PASS"
assert (
result[0].status_extended
== "Conditional Access Policy 'MFA for All Users' requires MFA for guest users."
== "Conditional Access Policy MFA for All Users requires MFA for guest users."
)
assert result[0].resource_id == policy.id
assert result[0].resource_name == "MFA for All Users"
@@ -222,7 +222,7 @@ class Test_entra_conditional_access_policy_mfa_enforced_for_guest_users:
assert result[0].status == "PASS"
assert (
result[0].status_extended
== "Conditional Access Policy 'MFA for Guest Users' requires MFA for guest users."
== "Conditional Access Policy MFA for Guest Users requires MFA for guest users."
)
assert result[0].resource_id == policy.id
@@ -594,7 +594,7 @@ class Test_entra_conditional_access_policy_mfa_enforced_for_guest_users:
assert result[0].status == "FAIL"
assert (
result[0].status_extended
== "Conditional Access Policy 'MFA for Guests Report Only' targets guest users with MFA but is only in report-only mode."
== "Conditional Access Policy MFA for Guests Report Only targets guest users with MFA but is only in report-only mode."
)
assert result[0].resource_id == policy.id
assert result[0].resource_name == "MFA for Guests Report Only"