fix for replaces

no need to reset rtpengine session when releasing media, and it was causing ICE to be reset which caused Teams to drop
2026-10-04 02:04:22 +00:00 · 2022-01-17 18:55:57 -05:00 · 2022-01-17 18:49:08 -05:00
1 changed files with 5 additions and 5 deletions
@@ -326,7 +326,7 @@ Duration=${payload.duration} `
   */
  async replaces(req, res) {
    try {
-      let opts = Object.assign(this.rtpEngineOpts.offer, {sdp: req.body});
+      let opts = Object.assign({}, this.rtpEngineOpts.uas.mediaOpts, {sdp: req.body});
      let response = await this.offer(opts);
      if ('ok' !== response.result) {
        res.send(488);
@@ -334,8 +334,8 @@ Duration=${payload.duration} `
      }
      this.logger.info({opts, response}, 'sent offer for reinvite to rtpengine');
      const sdp = await this.uac.modify(response.sdp);
-      opts = Object.assign(this.rtpEngineOpts.answer, {sdp, 'to-tag': this.toTag});
-      Object.assign(this.rtpEngineOpts.offer, {'to-tag': this.toTag});
+      opts = Object.assign({}, this.rtpEngineOpts.uac.mediaOpts, {sdp, 'to-tag': this.toTag});
+      Object.assign(this.rtpEngineOpts.uas.mediaOpts, {'to-tag': this.toTag});
      response = await this.answer(opts);
      if ('ok' !== response.result) {
        res.send(488);
@@ -395,7 +395,7 @@ Duration=${payload.duration} `
        direction,
        sdp: req.body,
      };
-      if (reason) opts.flags.push('reset');
+      //if (reason && opts.flags && !opts.flags.includes('reset')) opts.flags.push('reset');

      let response = await this.offer(opts);
      if ('ok' !== response.result) {
@@ -406,7 +406,7 @@ Duration=${payload.duration} `
      /* if this is a re-invite from the FS to change media anchoring, avoid sending the reinvite out */
      let sdp;
      if (reason && dlg.type === 'uac' && ['release-media', 'anchor-media'].includes(reason)) {
-        this.logger.info(`got a reinvite from FS to ${reason}`);
+        this.logger.info({response}, `got a reinvite from FS to ${reason}`);
        sdp = dlg.other.remote.sdp;
      }
      else {
Author	SHA1	Message	Date
Dave Horton	babeaa97b3	fix for replaces	2022-01-17 18:55:57 -05:00
Dave Horton	187bf92bb9	no need to reset rtpengine session when releasing media, and it was causing ICE to be reset which caused Teams to drop	2022-01-17 18:49:08 -05:00