bugfix: reinvite handling mixed up the public-private direction in rtpengine offer

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2019 jambonz
+Copyright (c) 2021 Drachtio Communications Services, LLC
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

lib/call-session.js

@@ -13,8 +13,8 @@ const MS_TEAMS_SIP_ENDPOINT = 'sip.pstnhub.microsoft.com';
 const createBLegFromHeader = (req) => {
   const from = req.getParsedHeader('From');
   const uri = parseUri(from.uri);
-  if (uri && uri.user) return `sip:${uri.user}@localhost`;
-  return 'sip:anonymous@localhost';
+  if (uri && uri.user) return `<sip:${uri.user}@localhost>`;
+  return '<sip:anonymous@localhost>';
 };
 
 class CallSession extends Emitter {
@@ -301,11 +301,17 @@ class CallSession extends Emitter {
 
   async _onReinvite(dlg, req, res) {
     try {
+      /* check for re-invite with no SDP -- seen that from BT when they provide UUI info */
+      if (!req.body) {
+        this.logger.info('got a reINVITE with no SDP; just respond with our current offer');
+        res.send(200, {body: dlg.local.sdp});
+        return;
+      }
       const fromTag = dlg.type === 'uas' ? this.rtpEngineOpts.uas.tag : this.rtpEngineOpts.uac.tag;
       const toTag = dlg.type === 'uas' ? this.rtpEngineOpts.uac.tag : this.rtpEngineOpts.uas.tag;
       const offerMedia = dlg.type === 'uas' ? this.rtpEngineOpts.uac.mediaOpts : this.rtpEngineOpts.uas.mediaOpts;
       const answerMedia = dlg.type === 'uas' ? this.rtpEngineOpts.uas.mediaOpts : this.rtpEngineOpts.uac.mediaOpts;
-      const direction =  dlg.type === 'uas' ? ['private', 'public'] : ['public', 'private'];
+      const direction =  dlg.type === 'uas' ? ['public', 'private'] : ['private', 'public'];
       let opts = {
         ...this.rtpEngineOpts.common,
         ...offerMedia,