bugfix: reinvite handling mixed up the public-private direction in rtpengine offer

if we get re-invite with no SDP (looking at you, BT) just respond with current offer
brackets around From
2026-10-04 02:04:22 +00:00 · 2021-08-09 15:45:20 -04:00 · 2021-08-03 10:41:19 -04:00 · 2021-07-28 16:22:05 -04:00
1 changed files with 9 additions and 3 deletions
@@ -13,8 +13,8 @@ const MS_TEAMS_SIP_ENDPOINT = 'sip.pstnhub.microsoft.com';
 const createBLegFromHeader = (req) => {
  const from = req.getParsedHeader('From');
  const uri = parseUri(from.uri);
-  if (uri && uri.user) return `sip:${uri.user}@localhost`;
-  return 'sip:anonymous@localhost';
+  if (uri && uri.user) return `<sip:${uri.user}@localhost>`;
+  return '<sip:anonymous@localhost>';
 };

 class CallSession extends Emitter {
@@ -265,11 +265,17 @@ class CallSession extends Emitter {

  async _onReinvite(dlg, req, res) {
    try {
+      /* check for re-invite with no SDP -- seen that from BT when they provide UUI info */
+      if (!req.body) {
+        this.logger.info('got a reINVITE with no SDP; just respond with our current offer');
+        res.send(200, {body: dlg.local.sdp});
+        return;
+      }
      const fromTag = dlg.type === 'uas' ? this.rtpEngineOpts.uas.tag : this.rtpEngineOpts.uac.tag;
      const toTag = dlg.type === 'uas' ? this.rtpEngineOpts.uac.tag : this.rtpEngineOpts.uas.tag;
      const offerMedia = dlg.type === 'uas' ? this.rtpEngineOpts.uac.mediaOpts : this.rtpEngineOpts.uas.mediaOpts;
      const answerMedia = dlg.type === 'uas' ? this.rtpEngineOpts.uas.mediaOpts : this.rtpEngineOpts.uac.mediaOpts;
-      const direction =  dlg.type === 'uas' ? ['private', 'public'] : ['public', 'private'];
+      const direction =  dlg.type === 'uas' ? ['public', 'private'] : ['private', 'public'];
      let opts = {
        ...this.rtpEngineOpts.common,
        ...offerMedia,
Author	SHA1	Message	Date
Dave Horton	a7bf420dd6	bugfix: reinvite handling mixed up the public-private direction in rtpengine offer	2021-08-09 15:45:20 -04:00
Dave Horton	55b02c924f	if we get re-invite with no SDP (looking at you, BT) just respond with current offer	2021-08-03 10:41:19 -04:00
Dave Horton	df02837c82	brackets around From	2021-07-28 16:22:05 -04:00