Recording update (#229 )

* new hasRecording flag on call info for setting recording URL in cdr * lint * use nullish coalescing for null response
fix vulnerability
2026-10-04 02:04:22 +00:00 · 2026-01-02 10:29:00 -05:00 · 2025-12-09 09:58:46 -05:00 · 2025-12-08 10:43:47 -05:00 · 2025-12-08 09:22:27 -05:00 · 2025-11-24 20:16:28 -06:00
5 changed files with 52 additions and 36 deletions
@@ -70,6 +70,7 @@ const {
  addKey,
  deleteKey,
  retrieveKey,
+  retrieveHash,
  createSet,
  retrieveSet,
  addToSet,
@@ -117,6 +118,7 @@ srf.locals = {...srf.locals,
    addKey,
    deleteKey,
    retrieveKey,
+    retrieveHash,
    createSet,
    incrKey,
    decrKey,
@@ -66,6 +66,7 @@ class CallSession extends Emitter {
    this.decrKey = req.srf.locals.realtimeDbHelpers.decrKey;
    this.addKey = req.srf.locals.realtimeDbHelpers.addKey;
    this.retrieveKey = req.srf.locals.realtimeDbHelpers.retrieveKey;
+    this.retrieveHash = req.srf.locals.realtimeDbHelpers.retrieveHash;

    this._mediaPath = MediaPath.FullMedia;

@@ -332,6 +333,15 @@ class CallSession extends Emitter {
        },
      });

+      // passing gateway outbound auth that sbc-inbound can send RE-INVITE with authentication process on UAS side
+      const {gateway} = this.req.locals;
+      if (gateway && gateway.register_username && gateway.register_password) {
+        this.logger.debug('passing outbound gateway auth to CallSession for reinvite processing');
+        uas.auth = {
+          username: gateway.register_username,
+          password: gateway.register_password
+        };
+      }
      // successfully connected
      this.logger.info('call connected successfully to feature server');
      debug('call connected successfully to feature server');
@@ -482,7 +492,9 @@ class CallSession extends Emitter {
            this.req.locals.carrier :
            this.req.locals.originator;
          const application = await this.srf.locals.getApplicationBySid(application_sid);
-          const isRecording = this.req.locals.account.record_all_calls || (application && application.record_all_calls);
+          const {hasRecording} = await this.retrieveHash(`call:${this.account_sid}:${call_sid}`) ?? {};
+          const isRecording = this.req.locals.account.record_all_calls ||
+          (application && application.record_all_calls) || hasRecording;
          const day = new Date();
          let recording_url = `/Accounts/${this.account_sid}/RecentCalls/${call_sid}/record`;
          recording_url += `/${day.getFullYear()}/${(day.getMonth() + 1).toString().padStart(2, '0')}`;
@@ -7,7 +7,8 @@ const sqlSelectSPForAccount = 'SELECT service_provider_sid FROM accounts WHERE a

 const sqlSelectAllCarriersForAccountByRealm =
 `SELECT sg.sip_gateway_sid, sg.voip_carrier_sid, vc.name, vc.account_sid,  
-vc.application_sid, sg.inbound, sg.outbound, sg.is_active, sg.ipv4, sg.netmask, sg.pad_crypto
+vc.application_sid, sg.inbound, sg.outbound, sg.is_active, sg.ipv4, sg.netmask, sg.pad_crypto,
+vc.register_username, vc.register_password
 FROM sip_gateways sg, voip_carriers vc, accounts acc 
 WHERE acc.sip_realm = ? 
 AND vc.account_sid = acc.account_sid 
@@ -17,7 +18,8 @@ AND sg.voip_carrier_sid = vc.voip_carrier_sid`;

 const sqlSelectAllCarriersForSPByRealm =
 `SELECT sg.sip_gateway_sid, sg.voip_carrier_sid, vc.name, vc.account_sid,  
-vc.application_sid, sg.inbound, sg.outbound, sg.is_active, sg.ipv4, sg.netmask, sg.pad_crypto
+vc.application_sid, sg.inbound, sg.outbound, sg.is_active, sg.ipv4, sg.netmask, sg.pad_crypto,
+vc.register_username, vc.register_password
 FROM sip_gateways sg, voip_carriers vc, accounts acc 
 WHERE acc.sip_realm = ? 
 AND vc.service_provider_sid = acc.service_provider_sid  
@@ -28,7 +30,8 @@ AND sg.voip_carrier_sid = vc.voip_carrier_sid`;

 const sqlSelectAllGatewaysForSP =
 `SELECT sg.sip_gateway_sid, sg.voip_carrier_sid, vc.name, vc.service_provider_sid,  
-vc.account_sid, vc.application_sid, sg.inbound, sg.outbound, sg.is_active, sg.ipv4, sg.netmask, sg.pad_crypto
+vc.account_sid, vc.application_sid, sg.inbound, sg.outbound, sg.is_active, sg.ipv4, sg.netmask, sg.pad_crypto,
+vc.register_username, vc.register_password
 FROM sip_gateways sg, voip_carriers vc
 WHERE sg.voip_carrier_sid = vc.voip_carrier_sid 
 AND vc.service_provider_sid IS NOT NULL 
@@ -57,7 +60,8 @@ AND outbound = 1`;

 const sqlSelectCarrierRequiringRegistration = `
 SELECT sg.sip_gateway_sid, sg.voip_carrier_sid, vc.name, vc.service_provider_sid, vc.account_sid,
-vc.application_sid, sg.inbound, sg.outbound, sg.is_active, sg.ipv4, sg.netmask, sg.pad_crypto
+vc.application_sid, sg.inbound, sg.outbound, sg.is_active, sg.ipv4, sg.netmask, sg.pad_crypto,
+vc.register_username, vc.register_password
 FROM sip_gateways sg, voip_carriers vc
 WHERE sg.voip_carrier_sid = vc.voip_carrier_sid
 AND vc.requires_register = 1
@@ -77,7 +81,8 @@ AND (

 const sqlSelectGatewaysByVoipCarrierSids = `
 SELECT sg.sip_gateway_sid, sg.voip_carrier_sid, vc.name, vc.service_provider_sid,
-vc.account_sid, vc.application_sid, sg.inbound, sg.outbound, sg.is_active, sg.ipv4, sg.netmask, sg.pad_crypto
+vc.account_sid, vc.application_sid, sg.inbound, sg.outbound, sg.is_active, sg.ipv4, sg.netmask, sg.pad_crypto,
+vc.register_username, vc.register_password
 FROM sip_gateways sg, voip_carriers vc
 WHERE sg.voip_carrier_sid IN (?)
 AND sg.voip_carrier_sid = vc.voip_carrier_sid
@@ -305,7 +310,9 @@ module.exports = (srf, logger) => {
            name: gw.name,
            service_provider_sid: gw.service_provider_sid,
            account_sid: gw.account_sid,
-            application_sid: gw.application_sid
+            application_sid: gw.application_sid,
+            register_username: gw.register_username,
+            register_password: gw.register_password
          };
        });
        /* remove duplicates, winnow down to voip_carriers, not gateways */
@@ -326,7 +333,8 @@ module.exports = (srf, logger) => {
                service_provider_sid: gw.service_provider_sid,
                account_sid: gw.account_sid,
                application_sid: gw.application_sid,
-                pad_crypto: gw.pad_crypto
+                register_username: gw.register_username,
+                register_password: gw.register_password
              };
            });
            /* remove duplicates */
@@ -459,7 +467,9 @@ module.exports = (srf, logger) => {
          service_provider_sid: gw.service_provider_sid,
          account_sid: gw.account_sid,
          application_sid: gw.application_sid,
-          pad_crypto: gw.pad_crypto
+          pad_crypto: gw.pad_crypto,
+          register_username: gw.register_username,
+          register_password: gw.register_password
        };
      });
    /* remove duplicates, winnow down to voip_carriers, not gateways */
@@ -479,7 +489,9 @@ module.exports = (srf, logger) => {
            service_provider_sid: gw.service_provider_sid,
            account_sid: gw.account_sid,
            application_sid: gw.application_sid,
-            pad_crypto: gw.pad_crypto
+            pad_crypto: gw.pad_crypto,
+            register_username: gw.register_username,
+            register_password: gw.register_password
          };
        });
        /* remove duplicates */
@@ -13,7 +13,7 @@
        "@aws-sdk/client-sns": "^3.549.0",
        "@babel/helpers": "^7.26.10",
        "@jambonz/db-helpers": "^0.9.18",
-        "@jambonz/digest-utils": "^0.0.8",
+        "@jambonz/digest-utils": "^0.0.9",
        "@jambonz/http-health-check": "^0.0.1",
        "@jambonz/realtimedb-helpers": "^0.8.18",
        "@jambonz/rtpengine-utils": "^0.4.4",
@@ -1346,10 +1346,11 @@
      "dev": true
    },
    "node_modules/@eslint/eslintrc/node_modules/js-yaml": {
-      "version": "4.1.0",
-      "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-4.1.0.tgz",
-      "integrity": "sha512-wpxZs9NoxZaJESJGIZTyDEaYpl0FKSA+FB9aJiyemKhMwkxQg63h4T1KJgUGHpTqPDNRcmmYLugrRjJlBtWvRA==",
+      "version": "4.1.1",
+      "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-4.1.1.tgz",
+      "integrity": "sha512-qQKT4zQxXl8lLwBtHMWwaTcGfFOZviOJet3Oy/xmGk2gZH677CJM9EvtfdSkgWcATZhj/55JZ0rmy3myCT5lsA==",
      "dev": true,
+      "license": "MIT",
      "dependencies": {
        "argparse": "^2.0.1"
      },
@@ -1500,9 +1501,9 @@
      }
    },
    "node_modules/@jambonz/digest-utils": {
-      "version": "0.0.8",
-      "resolved": "https://registry.npmjs.org/@jambonz/digest-utils/-/digest-utils-0.0.8.tgz",
-      "integrity": "sha512-zJV7/Qz2v3ihe86J5OSWLcrea+aT25WrnMWtc5xbVE+gOgB+d8/ESLS0MqRXyAKYLyxcEdb3lVpC4eK5XH8fdQ==",
+      "version": "0.0.9",
+      "resolved": "https://registry.npmjs.org/@jambonz/digest-utils/-/digest-utils-0.0.9.tgz",
+      "integrity": "sha512-4uK261hgCkk1gXhhhketMJVSsS7dY0lP9SPTMlf8GeGLxry6Mejfn3aqwVAfzO2LHNLxGTPGHYH1VJjSwxxwUA==",
      "license": "MIT",
      "dependencies": {
        "debug": "^4.3.4",
@@ -3427,7 +3428,6 @@
      "version": "4.21.2",
      "resolved": "https://registry.npmjs.org/express/-/express-4.21.2.tgz",
      "integrity": "sha512-28HqgMZAmih1Czt9ny7qr6ek2qddF4FclbMzwhCREB6OFfH+rXAnuNCwo1/wFvrtbgsQDb4kSbX9de9lFbrXnA==",
-      "license": "MIT",
      "dependencies": {
        "accepts": "~1.3.8",
        "array-flatten": "1.1.1",
@@ -4613,10 +4613,11 @@
      "integrity": "sha512-RdJUflcE3cUzKiMqQgsCu06FPu9UdIJO0beYbPhHN4k6apgJtifcoCtT9bcxOpYBtpD2kCM6Sbzg4CausW/PKQ=="
    },
    "node_modules/js-yaml": {
-      "version": "3.14.1",
-      "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-3.14.1.tgz",
-      "integrity": "sha512-okMH7OXXJ7YrN9Ok3/SXrnu4iX9yOk+25nqX4imS2npuvTYDmo/QEZoqwZkYaIDk3jVvBOTOIEgEhaLOynBS9g==",
+      "version": "3.14.2",
+      "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-3.14.2.tgz",
+      "integrity": "sha512-PMSmkqxr106Xa156c2M265Z+FTrPl+oxd/rgOQy2tijQeK5TxQ43psO1ZCwhVOSdnn+RzkzlRz/eY4BgJBYVpg==",
      "dev": true,
+      "license": "MIT",
      "dependencies": {
        "argparse": "^1.0.7",
        "esprima": "^4.0.0"
@@ -4930,9 +4931,9 @@
      }
    },
    "node_modules/nan": {
-      "version": "2.23.1",
-      "resolved": "https://registry.npmjs.org/nan/-/nan-2.23.1.tgz",
-      "integrity": "sha512-r7bBUGKzlqk8oPBDYxt6Z0aEdF1G1rwlMcLk8LCOMbOzf0mG+JUfUzG4fIMWwHWP0iyaLWEQZJmtB7nOHEm/qw==",
+      "version": "2.24.0",
+      "resolved": "https://registry.npmjs.org/nan/-/nan-2.24.0.tgz",
+      "integrity": "sha512-Vpf9qnVW1RaDkoNKFUvfxqAbtI8ncb8OJlqZ9wwpXzWPEsvsB1nvdUi6oYrHIkQ1Y/tMDnr1h4nczS0VB9Xykg==",
      "license": "MIT",
      "optional": true
    },
@@ -4950,17 +4951,6 @@
        "node": ">= 0.6"
      }
    },
-    "node_modules/node-gyp-build": {
-      "version": "4.6.0",
-      "resolved": "https://registry.npmjs.org/node-gyp-build/-/node-gyp-build-4.6.0.tgz",
-      "integrity": "sha512-NTZVKn9IylLwUzaKjkas1e4u2DLNcV4rdYagA4PWdPwW87Bi7z+BznyKSRwS/761tV/lzCGXplWsiaMjLqP2zQ==",
-      "optional": true,
-      "bin": {
-        "node-gyp-build": "bin.js",
-        "node-gyp-build-optional": "optional.js",
-        "node-gyp-build-test": "build-test.js"
-      }
-    },
    "node_modules/node-noop": {
      "version": "0.0.1",
      "resolved": "https://registry.npmjs.org/node-noop/-/node-noop-0.0.1.tgz",
@@ -30,7 +30,7 @@
    "@aws-sdk/client-sns": "^3.549.0",
    "@babel/helpers": "^7.26.10",
    "@jambonz/db-helpers": "^0.9.18",
-    "@jambonz/digest-utils": "^0.0.8",
+    "@jambonz/digest-utils": "^0.0.9",
    "@jambonz/http-health-check": "^0.0.1",
    "@jambonz/realtimedb-helpers": "^0.8.18",
    "@jambonz/rtpengine-utils": "^0.4.4",
Author	SHA1	Message	Date
Sam Machin	3f0fd794ce	Recording update (#229 ) * new hasRecording flag on call info for setting recording URL in cdr * lint * use nullish coalescing for null response	2026-01-02 10:29:00 -05:00
Dave Horton	876cb393f9	fix vulnerability	2025-12-09 09:58:46 -05:00
Sam Machin	fa2259d6e5	fix build (#228 ) * update dependenices * Update package-lock.json * fix buold	2025-12-08 10:43:47 -05:00
Sam Machin	2405190dcc	update dependenices (#227 )	2025-12-08 09:22:27 -05:00
Hoan Luu Huu	e9a5921b19	allow uas leg can send re-invite with outbound gatway credential (#221 ) * allow uas leg can send re-invite with outbound gatway credential * fix cannot get register username/password * fix cannot get register username/password * fix cannot get register username/password * fixed failing test cases	2025-11-24 20:16:28 -06:00