fix: remove X-Voip-Carrier-Sid for outbound INVITE

additional routing rule (#87 )
* additional routing rule * add testcase * update failing testcase
2026-10-04 02:04:19 +00:00 · 2023-05-29 20:15:22 +07:00 · 2023-05-29 09:06:11 -04:00 · 2023-05-11 09:25:44 -04:00 · 2023-05-10 16:02:08 -04:00 · 2023-05-10 14:43:46 -04:00
10 changed files with 211 additions and 107 deletions
@@ -37,7 +37,7 @@ const setNameRtp = `${(process.env.JAMBONES_CLUSTER_ID || 'default')}:active-rtp
 const rtpServers = [];
 const {
  ping,
-  performLcr,
+  lookupOutboundCarrierForAccount,
  lookupAllTeamsFQDNs,
  lookupAccountBySipRealm,
  lookupAccountBySid,
@@ -84,7 +84,7 @@ srf.locals = {...srf.locals,
  idleEmitter,
  dbHelpers: {
    ping,
-    performLcr,
+    lookupOutboundCarrierForAccount,
    lookupAllTeamsFQDNs,
    lookupAccountBySipRealm,
    lookupAccountBySid,
@@ -83,12 +83,13 @@ class CallSession extends Emitter {

    this.decrKey = req.srf.locals.realtimeDbHelpers.decrKey;

-    const {performLcr,
+    const {
+      lookupOutboundCarrierForAccount,
      lookupCarrierBySid,
      lookupSipGatewaysByCarrier,
      lookupCarrierByAccountLcr
    } = this.srf.locals.dbHelpers;
-    this.performLcr = performLcr;
+    this.lookupOutboundCarrierForAccount = lookupOutboundCarrierForAccount;
    this.lookupCarrierBySid = lookupCarrierBySid;
    this.lookupSipGatewaysByCarrier = lookupSipGatewaysByCarrier;
    this.lookupCarrierByAccountLcr = lookupCarrierByAccountLcr;
@@ -222,60 +223,77 @@ class CallSession extends Emitter {
          let voip_carrier_sid = this.req.get('X-Requested-Carrier-Sid');
          const account_sid = this.req.get('X-Account-Sid');
          if (!voip_carrier_sid && account_sid) {
-            debug('calling lcr');
+            /* search for an LCR table for this account or service provider */
            voip_carrier_sid = await this.lookupCarrierByAccountLcr(account_sid, this.req.calledNumber);
          }
-          if (voip_carrier_sid) {
-            const vc = await this.lookupCarrierBySid(voip_carrier_sid);
-            const gateways = await this.lookupSipGatewaysByCarrier(voip_carrier_sid);
-            const gws = (gateways || [])
-              .filter((gw) => gw.outbound);
-            if (gws.length) {
-              uris = [];
-              gws.forEach((o) => {
-                const prefix = vc.tech_prefix;
-                const hostport = !o.port || 5060 === o.port ? o.ipv4 : `${o.ipv4}:${o.port}`;
-                const prependPlus = vc.e164_leading_plus && !this.req.calledNumber.startsWith('0');
-                const transport = o.protocol || 'udp';
-                const u = `sip:${prefix ? prefix : ''}${prependPlus ? '+' : ''}${this.req.calledNumber}@${hostport};transport=${transport}`;
-                const obj = {
-                  name: vc.name,
-                  diversion: vc.diversion,
-                  hostport
-                };
-                if (vc.register_username && vc.register_password) {
-                  obj.auth = {
-                    username: vc.register_username,
-                    password: vc.register_password
-                  };
-                }
-                mapGateways.set(u, obj);
-                uris.push(u);
-              });
-              this.logger.debug({uris, voip_carrier_sid}, 'selected outbound gateways for requested carrier');
-            }
-            else {
-              this.logger.info({voip_carrier_sid}, 'no outbound gateways found for requested carrier');
+          if (!voip_carrier_sid) {
+            /* no LCR for this account/SP - try with inbound carrier */
+            const inbound_carrier_sid = this.req.get('X-Voip-Carrier-Sid');
+            if (inbound_carrier_sid) {
+              const gateways = await this.lookupSipGatewaysByCarrier(inbound_carrier_sid);
+              const gws = (gateways || [])
+                .filter((gw) => gw.outbound);
+              if (gws.length) {
+                voip_carrier_sid = inbound_carrier_sid;
+              }
            }
          }
-          if (mapGateways.size === 0) {
-            /**
-             * We normalize the called number by removing a leading + before sending it to LCR..
-             * but LCR will return us an array of sip uris, with leading + for carriers that require it
-             */
-            const routableNumber = this.req.calledNumber.startsWith('+') ?
-              this.req.calledNumber.slice(1) :
-              this.req.calledNumber;
-            const gateways = await this.performLcr(routableNumber, this.account_sid);
-            if (!gateways || gateways.length === 0) throw new Error('no routes found');
-            debug(`got gateways: ${JSON.stringify(gateways)}`);
-            gateways.forEach((gw) => mapGateways.set(gw.uri, {
-              name: gw.name,
-              auth: gw.auth,
-              diversion: gw.diversion,
-              hostport: gw.hostport
-            }));
-            uris = gateways.map((gw) => gw.uri);
+          if (!voip_carrier_sid) {
+            /* no LCR/ inbound carrier for this account/SP - at this point its a random shuffle of outbound carriers */
+            voip_carrier_sid = await this.lookupOutboundCarrierForAccount(this.account_sid);
+          }
+          if (!voip_carrier_sid) {
+            /* no outbound carriers exist for this account/SP */
+            this.logger.info(`no outbound carriers found for account_sid ${account_sid}`);
+            this.res.send(603);
+            return this.srf.endSession(this.req);
+          }
+          const vc = await this.lookupCarrierBySid(voip_carrier_sid);
+          const gateways = await this.lookupSipGatewaysByCarrier(voip_carrier_sid);
+          const gws = (gateways || [])
+            .filter((gw) => gw.outbound);
+          if (gws.length) {
+            uris = [];
+            gws.forEach((o) => {
+              const calledNumber = this.req.calledNumber.startsWith('+') ?
+                this.req.calledNumber.slice(1) :
+                this.req.calledNumber;
+              const prefix = vc.tech_prefix || '';
+              const protocol =  o.protocol?.startsWith('tls') ? 'tls' : (o.protocol || 'udp');
+              const hostport = !o.port || 5060 === o.port ? o.ipv4 : `${o.ipv4}:${o.port}`;
+              const prependPlus = vc.e164_leading_plus && !this.req.calledNumber.startsWith('0') ? '+' : '';
+              const transport = `transport=${protocol}`;
+              const scheme = protocol === 'tls' ? 'sips' : 'sip';
+              const u = `${scheme}:${prefix}${prependPlus}${calledNumber}@${hostport};${transport}`;
+              const obj = {
+                name: vc.name,
+                diversion: vc.diversion,
+                hostport,
+                protocol: o.protocol
+              };
+              if (vc.register_username && vc.register_password) {
+                obj.auth = {
+                  username: vc.register_username,
+                  password: vc.register_password
+                };
+              }
+              mapGateways.set(u, obj);
+              uris.push(u);
+              if (o.protocol === 'tls/srtp') {
+                /**  TODO: this is a bit of a hack in the sense that we are not
+                 * supporting a scenario where you have a carrier with several outbound
+                 * gateways, some requiring encrypted media and some not.  This should be rectified
+                 * but it will require more significant changes and right now it seems
+                 * like a rare use case -- encryption is usually an all or nothing requirement.
+                 */
+                this.logger.info({u}, 'using SRTP for outbound call');
+                this.rtpEngineOpts = makeRtpEngineOpts(this.req, false, true, true);
+              }
+            });
+            this.logger.debug({uris, voip_carrier_sid}, 'selected outbound gateways for requested carrier');
+          }
+          else {
+            this.logger.info({voip_carrier_sid}, 'no outbound gateways found for requested carrier');
          }
        } catch (err) {
          debug(err);
@@ -362,6 +380,7 @@ class CallSession extends Emitter {
              '-X-Preferred-From-User',
              'X-Preferred-From-Host',
              '-X-Jambonz-FS-UUID',
+              '-X-Voip-Carrier-Sid',
            ],
            proxyResponseHeaders: [
              'all',
@@ -1,18 +1,18 @@
 {
  "name": "sbc-outbound",
-  "version": "v0.8.2",
+  "version": "0.8.3",
  "lockfileVersion": 2,
  "requires": true,
  "packages": {
    "": {
      "name": "sbc-outbound",
-      "version": "v0.8.2",
+      "version": "0.8.3",
      "license": "MIT",
      "dependencies": {
-        "@jambonz/db-helpers": "^0.7.8",
+        "@jambonz/db-helpers": "^0.8.0",
        "@jambonz/http-health-check": "^0.0.1",
        "@jambonz/mw-registrar": "0.2.2",
-        "@jambonz/realtimedb-helpers": "^0.7.0",
+        "@jambonz/realtimedb-helpers": "^0.7.2",
        "@jambonz/rtpengine-utils": "^0.4.3",
        "@jambonz/siprec-client-utils": "^0.2.4",
        "@jambonz/stats-collector": "^0.1.8",
@@ -573,9 +573,9 @@
      }
    },
    "node_modules/@jambonz/db-helpers": {
-      "version": "0.7.9",
-      "resolved": "https://registry.npmjs.org/@jambonz/db-helpers/-/db-helpers-0.7.9.tgz",
-      "integrity": "sha512-JajIJSPXW0OTjVprDwTH8/yU/qhHY1XkXe6f5PRh0kvRt42AmYggcGKqgivUkY1seR/GVCnQccDcIA2ZEdvDUg==",
+      "version": "0.8.0",
+      "resolved": "https://registry.npmjs.org/@jambonz/db-helpers/-/db-helpers-0.8.0.tgz",
+      "integrity": "sha512-tyu5oZYCErkD0JQ1PYmfmqB1KbbJl3i6EGVYdyrCSxPunmeZ7SCfpx0CprbEM90ym3Stsgnkak9qCxS+pA6WrA==",
      "dependencies": {
        "cidr-matcher": "^2.1.1",
        "debug": "^4.3.4",
@@ -617,9 +617,9 @@
      }
    },
    "node_modules/@jambonz/realtimedb-helpers": {
-      "version": "0.7.0",
-      "resolved": "https://registry.npmjs.org/@jambonz/realtimedb-helpers/-/realtimedb-helpers-0.7.0.tgz",
-      "integrity": "sha512-hu+CcV0jzQU6J4vW8bBEz52NqEroLHOB0wjVb/VmSL4N0+MAJ1wbPUNk8go5aMk809Vr/Od2z9nHInGnTiBHzA==",
+      "version": "0.7.2",
+      "resolved": "https://registry.npmjs.org/@jambonz/realtimedb-helpers/-/realtimedb-helpers-0.7.2.tgz",
+      "integrity": "sha512-hTlMw0pmwNHTAQVm3O1asHllRSwi5C+kLXjqZN4C8bdw08f6CY48qdX/aNHLlx5TWI1I5l0ReO745KrUFVPA6w==",
      "dependencies": {
        "@jambonz/promisify-redis": "^0.0.6",
        "debug": "^4.3.4",
@@ -5235,9 +5235,9 @@
      "dev": true
    },
    "@jambonz/db-helpers": {
-      "version": "0.7.9",
-      "resolved": "https://registry.npmjs.org/@jambonz/db-helpers/-/db-helpers-0.7.9.tgz",
-      "integrity": "sha512-JajIJSPXW0OTjVprDwTH8/yU/qhHY1XkXe6f5PRh0kvRt42AmYggcGKqgivUkY1seR/GVCnQccDcIA2ZEdvDUg==",
+      "version": "0.8.0",
+      "resolved": "https://registry.npmjs.org/@jambonz/db-helpers/-/db-helpers-0.8.0.tgz",
+      "integrity": "sha512-tyu5oZYCErkD0JQ1PYmfmqB1KbbJl3i6EGVYdyrCSxPunmeZ7SCfpx0CprbEM90ym3Stsgnkak9qCxS+pA6WrA==",
      "requires": {
        "cidr-matcher": "^2.1.1",
        "debug": "^4.3.4",
@@ -5273,9 +5273,9 @@
      }
    },
    "@jambonz/realtimedb-helpers": {
-      "version": "0.7.0",
-      "resolved": "https://registry.npmjs.org/@jambonz/realtimedb-helpers/-/realtimedb-helpers-0.7.0.tgz",
-      "integrity": "sha512-hu+CcV0jzQU6J4vW8bBEz52NqEroLHOB0wjVb/VmSL4N0+MAJ1wbPUNk8go5aMk809Vr/Od2z9nHInGnTiBHzA==",
+      "version": "0.7.2",
+      "resolved": "https://registry.npmjs.org/@jambonz/realtimedb-helpers/-/realtimedb-helpers-0.7.2.tgz",
+      "integrity": "sha512-hTlMw0pmwNHTAQVm3O1asHllRSwi5C+kLXjqZN4C8bdw08f6CY48qdX/aNHLlx5TWI1I5l0ReO745KrUFVPA6w==",
      "requires": {
        "@jambonz/promisify-redis": "^0.0.6",
        "debug": "^4.3.4",
@@ -1,6 +1,6 @@
 {
  "name": "sbc-outbound",
-  "version": "v0.8.2",
+  "version": "0.8.3",
  "main": "app.js",
  "engines": {
    "node": ">= 12.0.0"
@@ -27,8 +27,8 @@
    "jslint": "eslint app.js lib"
  },
  "dependencies": {
-    "@jambonz/db-helpers": "^0.7.8",
-    "@jambonz/realtimedb-helpers": "^0.7.0",
+    "@jambonz/db-helpers": "^0.8.0",
+    "@jambonz/realtimedb-helpers": "^0.7.2",
    "@jambonz/http-health-check": "^0.0.1",
    "@jambonz/mw-registrar": "0.2.2",
    "@jambonz/rtpengine-utils": "^0.4.3",
@@ -429,7 +429,7 @@ inbound BOOLEAN NOT NULL COMMENT 'if true, whitelist this IP to allow inbound ca
 outbound BOOLEAN NOT NULL COMMENT 'if true, include in least-cost routing when placing calls to the PSTN',
 voip_carrier_sid CHAR(36) NOT NULL,
 is_active BOOLEAN NOT NULL DEFAULT 1,
-protocol ENUM('udp','tcp','tls') DEFAULT 'udp' COMMENT 'Outbound call protocol',
+protocol ENUM('udp','tcp','tls', 'tls/srtp') DEFAULT 'udp' COMMENT 'Outbound call protocol',
 PRIMARY KEY (sip_gateway_sid)
 ) COMMENT='A whitelisted sip gateway used for origination/termination';

@@ -683,4 +683,4 @@ ALTER TABLE accounts ADD FOREIGN KEY device_calling_application_sid_idxfk (devic

 ALTER TABLE accounts ADD FOREIGN KEY siprec_hook_sid_idxfk (siprec_hook_sid) REFERENCES applications (application_sid);

-SET FOREIGN_KEY_CHECKS=1;
+SET FOREIGN_KEY_CHECKS=1;
@@ -27,12 +27,23 @@ insert into voip_carriers (voip_carrier_sid, name, service_provider_sid) values
 insert into sip_gateways (sip_gateway_sid, voip_carrier_sid, ipv4, inbound, outbound) 
 values ('e71519ff-4494-4c98-a06a-324e2712d94b', '1d8ef351-062a-4487-94f8-7698d5a40d24', '172.39.0.21', true, true);

-- lcr route: first try eastco (503) then westco (200)
-insert into lcr(lcr_sid, name, is_active, service_provider_sid) values ('0eba4204-b036-4388-8f47-724c4cfb3d4f', 'default LCR', 1, '3f35518f-5a0d-4c2e-90a5-2407bb3b36f0');
-insert into lcr_routes(lcr_route_sid, lcr_sid, regex, priority) values ('0eba4204-b036-4388-8f47-724c4cfb3d4e', '0eba4204-b036-4388-8f47-724c4cfb3d4f', '.*', 1);
+-- lcr route: default eastco, but 1617 matches westco (503)
+insert into lcr(lcr_sid, account_sid) 
+values('c0b0b6a0-0b0a-4b0b-8b0b-0b0b0b0b0b0b', 'ed649e33-e771-403a-8c99-1780eabbc803');
+
+insert into lcr_routes(lcr_route_sid, lcr_sid, regex, priority) 
+values ('9eba4204-b036-4388-8f47-724c4cfb3d4e', 'c0b0b6a0-0b0a-4b0b-8b0b-0b0b0b0b0b0b', '.*', 999);

 insert into lcr_carrier_set_entry(lcr_carrier_set_entry_sid, lcr_route_sid, voip_carrier_sid, priority)
-values ('b677a7b5-bec6-4045-ae4a-a67a5ccb3448', '0eba4204-b036-4388-8f47-724c4cfb3d4e', '1d8ef351-062a-4487-94f8-7698d5a40d24', 2);
+values ('13e344a0-8a4c-4f95-8a19-ccbfc7ab053e', '9eba4204-b036-4388-8f47-724c4cfb3d4e', '1d8ef351-062a-4487-94f8-7698d5a40d24', 1);
+
+-- attach default route to lcr
+update lcr set default_carrier_set_entry_sid = '13e344a0-8a4c-4f95-8a19-ccbfc7ab053e';
+
+-- add a route based on digit match
+insert into lcr_routes(lcr_route_sid, lcr_sid, regex, priority) 
+values ('3eba4204-b036-4388-8f47-724c4cfb3d4e', 'c0b0b6a0-0b0a-4b0b-8b0b-0b0b0b0b0b0b', '1617', 1);
+
 insert into lcr_carrier_set_entry(lcr_carrier_set_entry_sid, lcr_route_sid, voip_carrier_sid, priority)
-values ('13e344a0-8a4c-4f95-8a19-ccbfc7ab053e', '0eba4204-b036-4388-8f47-724c4cfb3d4e', '287c1452-620d-4195-9f19-c9814ef90d78', 1);
+values ('b677a7b5-bec6-4045-ae4a-a67a5ccb3448', '3eba4204-b036-4388-8f47-724c4cfb3d4e', '287c1452-620d-4195-9f19-c9814ef90d78', 1);

@@ -17,29 +17,7 @@ values ('f4e1848d-3ff8-40eb-b9c1-30e1ef053f94','ed649e33-e771-403a-8c99-1780eabb
 insert into account_products(account_product_sid, account_subscription_sid, product_sid,quantity)
 values ('f23ff996-6534-4aba-8666-4b347391eca2', 'f4e1848d-3ff8-40eb-b9c1-30e1ef053f94', 'c4403cdb-8e75-4b27-9726-7d8315e3216d', 10);

-- "good" carrier - "westco" at 172.39.0.20
-insert into voip_carriers (voip_carrier_sid, name, service_provider_sid) values ('287c1452-620d-4195-9f19-c9814ef90d78', 'westco', '3f35518f-5a0d-4c2e-90a5-2407bb3b36f0');
-insert into sip_gateways (sip_gateway_sid, voip_carrier_sid, ipv4, inbound, outbound) 
-values ('124a5339-c62c-4075-9e19-f4de70a96597', '287c1452-620d-4195-9f19-c9814ef90d78', '172.39.0.20', true, true);
-
-- "bad" carrier - "eastco" at 172.39.0.21 (returns 503)
-insert into voip_carriers (voip_carrier_sid, name, service_provider_sid) values ('1d8ef351-062a-4487-94f8-7698d5a40d24', 'eastco', '3f35518f-5a0d-4c2e-90a5-2407bb3b36f0');
-insert into sip_gateways (sip_gateway_sid, voip_carrier_sid, ipv4, inbound, outbound) 
-values ('e71519ff-4494-4c98-a06a-324e2712d94b', '1d8ef351-062a-4487-94f8-7698d5a40d24', '172.39.0.21', true, true);
-
 -- "bad" carrier - "northco" at 172.39.0.22 (returns 100 Trying and never answers)
 insert into voip_carriers (voip_carrier_sid, name, service_provider_sid) values ('7b4b9c56-4d81-4f31-9d70-62cd7d82193b', 'northco', '3f35518f-5a0d-4c2e-90a5-2407bb3b36f0');
 insert into sip_gateways (sip_gateway_sid, voip_carrier_sid, ipv4, inbound, outbound) 
 values ('fcbb2109-582c-4d55-b38a-b6bc7cc4be73', '7b4b9c56-4d81-4f31-9d70-62cd7d82193b', '172.39.0.22', true, true);
-
-- lcr route: first try eastco (503) then northco (cancel), then westco (200)
-insert into lcr(lcr_sid, name, is_active, service_provider_sid) values ('0eba4204-b036-4388-8f47-724c4cfb3d4f', 'default LCR', 1, '3f35518f-5a0d-4c2e-90a5-2407bb3b36f0');
-insert into lcr_routes(lcr_route_sid, lcr_sid, regex, priority) values ('0eba4204-b036-4388-8f47-724c4cfb3d4e', '0eba4204-b036-4388-8f47-724c4cfb3d4f', '.*', 1);
-
-insert into lcr_carrier_set_entry(lcr_carrier_set_entry_sid, lcr_route_sid, voip_carrier_sid, priority)
-values ('b677a7b5-bec6-4045-ae4a-a67a5ccb3448', '0eba4204-b036-4388-8f47-724c4cfb3d4e', '1d8ef351-062a-4487-94f8-7698d5a40d24', 3);
-insert into lcr_carrier_set_entry(lcr_carrier_set_entry_sid, lcr_route_sid, voip_carrier_sid, priority)
-values ('b417ce66-a805-46b3-b296-697a6c2ca249', '0eba4204-b036-4388-8f47-724c4cfb3d4e', '7b4b9c56-4d81-4f31-9d70-62cd7d82193b', 1);
-insert into lcr_carrier_set_entry(lcr_carrier_set_entry_sid, lcr_route_sid, voip_carrier_sid, priority)
-values ('13e344a0-8a4c-4f95-8a19-ccbfc7ab053e', '0eba4204-b036-4388-8f47-724c4cfb3d4e', '287c1452-620d-4195-9f19-c9814ef90d78', 2);
-
@@ -33,7 +33,7 @@
      CSeq: 1 INVITE
      Contact: sip:sipp@[local_ip]:[local_port]
      Max-Forwards: 70
-      Subject: uac-pcap-carrier-success
+      Subject: uac-cancel
      X-Account-Sid: ed649e33-e771-403a-8c99-1780eabbc803
      X-Call-Sid: fff49e33-e771-403a-8c99-1780eabbc803
      X-Jambonz-Routing: phone
@@ -60,7 +60,7 @@

  <recv response="100" response_txn="invite"/>

-  <pause milliseconds="3000"/>
+  <pause milliseconds="1000"/>

  <send>
  <![CDATA[
@@ -0,0 +1,92 @@
+<?xml version="1.0" encoding="ISO-8859-1" ?>
+<!DOCTYPE scenario SYSTEM "sipp.dtd">
+
+<scenario name="UAC with media">
+
+  <send retrans="500">
+    <![CDATA[
+
+      INVITE sip:16173333456@127.0.0.1 SIP/2.0
+      Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch]
+      From: sipp <sip:sipp@[local_ip]:[local_port]>;tag=[pid]SIPpTag09[call_number]
+      To: <sip:16173333456@127.0.0.1>
+      Call-ID: [call_id]
+      CSeq: 1 INVITE
+      Contact: sip:sipp@[local_ip]:[local_port]
+      Max-Forwards: 70
+      X-Account-Sid: ed649e33-e771-403a-8c99-1780eabbc803
+      X-Call-Sid: fff49e33-e771-403a-8c99-1780eabbc803
+      X-Jambonz-Routing: phone
+      X-Voip-Carrier-Sid: 287c1452-620d-4195-9f19-c9814ef90d78
+      Subject: uac-pcap-carrier-success
+      Content-Type: application/sdp
+      Content-Length: [len]
+
+      v=0
+      o=user1 53655765 2353687637 IN IP[local_ip_type] [local_ip]
+      s=-
+      c=IN IP[local_ip_type] [local_ip]
+      t=0 0
+      m=audio [auto_media_port] RTP/AVP 8 101
+      a=rtpmap:8 PCMA/8000
+      a=rtpmap:101 telephone-event/8000
+      a=fmtp:101 0-11,16
+
+    ]]>
+  </send>
+
+  <recv response="100" optional="true">
+  </recv>
+
+  <recv response="180" optional="true">
+  </recv>
+
+  <recv response="200" rtd="true" crlf="true">
+  </recv>
+
+  <send>
+    <![CDATA[
+
+      ACK sip:sip:+16173333456@127.0.0.1 SIP/2.0
+      Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch]
+      From: sipp <sip:sipp@[local_ip]:[local_port]>;tag=[pid]SIPpTag09[call_number]
+      To: <sip:sip:+16173333456@127.0.0.1>[peer_tag_param]
+      Call-ID: [call_id]
+      CSeq: 1 ACK
+      Subject: uac-pcap-carrier-success
+      Content-Length: 0
+
+    ]]>
+  </send>
+
+  <!-- Play a pre-recorded PCAP file (RTP stream)                       -->
+  <nop>
+    <action>
+      <exec play_pcap_audio="pcap/g711a.pcap"/>
+    </action>
+  </nop>
+
+  <!-- Pause briefly      -->
+  <pause milliseconds="2000"/>
+
+  <!-- The 'crlf' option inserts a blank line in the statistics report. -->
+  <send retrans="500">
+    <![CDATA[
+
+      BYE sip:sip:+16173333456@127.0.0.1 SIP/2.0
+      Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch]
+      From: sipp <sip:sipp@[local_ip]:[local_port]>;tag=[pid]SIPpTag09[call_number]
+      To: <sip:sip:+16173333456@127.0.0.1>[peer_tag_param]
+      Call-ID: [call_id]
+      CSeq: 2 BYE
+      Max-Forwards: 70
+      Subject: uac-pcap-carrier-success
+      Content-Length: 0
+
+    ]]>
+  </send>
+
+  <recv response="200" crlf="true">
+  </recv>
+
+</scenario>
@@ -44,6 +44,10 @@ test('sbc-outbound tests', async(t) => {
    await sippUac('uac-pcap-carrier-success.xml');
    t.pass('successfully completed outbound call to sip trunk');

+    /* call to PSTN with no lcr configured */
+    await sippUac('uac-pcap-inbound-carrier-success.xml');
+    t.pass('successfully completed outbound call to sip trunk');
+
    /* call to PSTN with request uri we see in kubernetes */
    await sippUac('uac-pcap-carrier-success-k8s.xml');
    t.pass('successfully completed outbound call to sip trunk (k8S req uri)');
@@ -54,7 +58,7 @@ test('sbc-outbound tests', async(t) => {

    /* call to PSTN with lcr configured */
    await sippUac('uac-pcap-carrier-success.xml');
-    t.pass('successfully completed outbound lcr carrier with crankback after failure');
+    t.pass('successfully completed outbound call using LCR');

    // re-rack test data
    execSync(`mysql -h 127.0.0.1 -u root  --protocol=tcp -D jambones_test < ${__dirname}/db/jambones-sql.sql`);
@@ -87,8 +91,8 @@ test('sbc-outbound tests', async(t) => {
    await waitFor(25);

    const res = await queryCdrs({account_sid: 'ed649e33-e771-403a-8c99-1780eabbc803'});
-    console.log(`cdrs: ${JSON.stringify(res)}`);
-    t.ok(res.total === 6, 'wrote 6 cdrs');
+    console.log(`${res.total} cdrs: ${JSON.stringify(res)}`);
+    t.ok(res.total === 7, 'wrote 7 cdrs');

    srf.disconnect();
  } catch (err) {
Author	SHA1	Message	Date
Quan HL	c0d87d0b7b	fix: remove X-Voip-Carrier-Sid for outbound INVITE	2023-05-29 20:15:22 +07:00
Hoan Luu Huu	738429a46f	additional routing rule (#87 ) * additional routing rule * add testcase * update failing testcase	2023-05-29 09:06:11 -04:00
Dave Horton	9015ac4e13	0.8.3	2023-05-11 09:25:44 -04:00
Dave Horton	750294eab2	add support for tls with srtp media encryption (#83 )	2023-05-10 16:02:08 -04:00
Hoan Luu HuuandDave Horton	76558cc5c9	add protocol for outbound call (#82 ) * add protocol for outbound call * add protocol for outbound call * update db-helper version * lcr fixes * fix cancel test --------- Co-authored-by: Dave Horton <daveh@beachdognet.com>	2023-05-10 14:43:46 -04:00
Dave Horton	d604440907	update deps	2023-05-08 13:13:49 -04:00
Hoan Luu Huu	039a60c1b7	feat: lcr added (#80 ) * feat: lcr added * fix: await for async * fix: add lookupCarrierByAccountLcr to locals * fix typo * fix typo * fix typo	2023-05-08 09:06:37 -04:00