gh: run tests on PR

add optional env var to specify udp localPort to bind to
update deps
2026-10-04 18:44:38 +00:00 · 2023-01-09 10:13:53 -05:00 · 2022-12-30 10:41:39 -05:00 · 2022-12-29 09:58:44 -05:00 · 2022-12-29 09:52:06 -05:00 · 2022-12-28 11:10:15 -06:00
8 changed files with 2590 additions and 1088 deletions
@@ -1,8 +1,6 @@
 name: CI

-on:
-  push:
-  workflow_dispatch:
+on: [push, pull_request]

 jobs:
  build:
@@ -1,4 +1,4 @@
-FROM --platform=linux/amd64 node:18.9.0-alpine3.16 as base
+FROM --platform=linux/amd64 node:18.12.1-alpine3.16 as base

 RUN apk --update --no-cache add --virtual .builds-deps build-base python3

@@ -184,7 +184,6 @@ if ('test' !== process.env.NODE_ENV) {
 }

 const lookupRtpServiceEndpoints = (lookup, serviceName) => {
-  logger.debug(`dns lookup for ${serviceName}..`);
  lookup(serviceName, {family: 4, all: true}, (err, addresses) => {
    if (err) {
      logger.error({err}, `Error looking up ${serviceName}`);
@@ -431,6 +431,7 @@ class CallSession extends Emitter {
                sip_status: status
              }).catch((err) => this.logger.error({err}, 'Error writing cdr for call failure'));
            }
+            return;
          }
          else {
            this.logger.info(`got ${err.status}, cranking back to next destination`);
@@ -589,7 +590,8 @@ Duration=${payload.duration} `
        direction,
        sdp: req.body,
      };
-      if (reason && opts.flags && !opts.flags.includes('reset')) opts.flags.push('reset');
+      // DH: this was restarting ICE, which we don't want to do
+      //if (reason && opts.flags && !opts.flags.includes('reset')) opts.flags.push('reset');

      let response = await this.offer(opts);
      if ('ok' !== response.result) {
@@ -17,7 +17,8 @@ function makeRtpEngineOpts(req, srcIsUsingSrtp, dstIsUsingSrtp, teams = false) {
  }
  const common = {
    'call-id': req.get('Call-ID'),
-    'replace': ['origin', 'session-connection']
+    'replace': ['origin', 'session-connection'],
+    'record call': process.env.JAMBONES_RECORD_ALL_CALLS ? 'yes' : 'no'
  };
  return {
    common,
@@ -1,6 +1,6 @@
 {
  "name": "sbc-outbound",
-  "version": "v0.7.7",
+  "version": "v0.7.8",
  "main": "app.js",
  "engines": {
    "node": ">= 12.0.0"
@@ -28,17 +28,17 @@
  },
  "dependencies": {
    "@jambonz/db-helpers": "^0.7.3",
-    "@jambonz/realtimedb-helpers": "^0.4.35",
+    "@jambonz/realtimedb-helpers": "^0.5.7",
    "@jambonz/http-health-check": "^0.0.1",
    "@jambonz/mw-registrar": "0.2.2",
-    "@jambonz/rtpengine-utils": "^0.3.10",
-    "@jambonz/siprec-client-utils": "^0.1.4",
+    "@jambonz/rtpengine-utils": "^0.4.2",
+    "@jambonz/siprec-client-utils": "^0.2.0",
    "@jambonz/stats-collector": "^0.1.6",
    "@jambonz/time-series": "^0.2.5",
    "cidr-matcher": "^2.1.1",
    "debug": "^4.3.4",
    "drachtio-fn-b2b-sugar": "^0.0.12",
-    "drachtio-srf": "^4.5.1",
+    "drachtio-srf": "^4.5.21",
    "express": "^4.18.1",
    "pino": "^7.11.0",
    "sdp-transform": "^2.14.1"
@@ -84,7 +84,7 @@ test('sbc-outbound tests', async(t) => {

    const res = await queryCdrs({account_sid: 'ed649e33-e771-403a-8c99-1780eabbc803'});
    //console.log(`cdrs: ${JSON.stringify(res)}`);
-    t.ok(res.total === 6, 'wrote 6 cdrs');
+    t.ok(res.total === 5, 'wrote 5 cdrs');

    srf.disconnect();
  } catch (err) {
Author	SHA1	Message	Date
Dave Horton	6d44c6c986	gh: run tests on PR	2023-01-09 10:13:53 -05:00
Dave Horton	6d593cbc7d	add optional env var to specify udp localPort to bind to	2022-12-30 10:41:39 -05:00
Dave Horton	35b15c1f2c	update deps	2022-12-29 09:58:44 -05:00
Dave Horton	7f1d1d61db	update to drachtio-srf@4.5.21 with some perf fixes	2022-12-29 09:52:06 -05:00
Dave Horton	20c17fd723	update drachtio-srf	2022-12-28 11:10:15 -06:00
Dave Horton	da6fa1da1b	bump version	2022-12-24 12:07:10 -06:00
Dave Horton	f74dff3b59	bugfix: when releasing media we were restarting ICE which we dont want to do	2022-12-19 21:28:43 -05:00
Dave Horton	d9c4e01c36	add env JAMBONES_RECORD_ALL_CALLS to enable global call recording	2022-12-02 13:53:29 -05:00
Dave Horton	3d902c65a4	minor logging	2022-12-01 14:05:23 -05:00
Dave Horton	d641504797	fix test	2022-11-29 13:05:51 -05:00
Dave Horton	b871812a70	bugfix: was incorrectly making additional attempts after caller hung up or other failures on first attempt	2022-11-28 16:45:21 -05:00
Guilherme RauenandGuilherme Rauen	e123a2ef88	update node image to the latest and most secure (#56 ) Co-authored-by: Guilherme Rauen <g.rauen@cognigy.com>	2022-11-11 11:26:42 -05:00