Fix/193 (#195 )

* pass sip failure reason back to FS * Update call-session.js * update drachtio-srf dep
fix prev commit (#192 )
2026-10-04 18:44:38 +00:00 · 2025-09-12 09:21:13 -04:00 · 2025-09-04 07:57:38 -04:00 · 2025-09-03 23:35:56 -04:00 · 2025-09-03 13:53:51 -04:00 · 2025-09-02 08:02:59 -04:00
6 changed files with 49 additions and 22 deletions
@@ -3,6 +3,6 @@
  "DTLS": "off",
  "SDES": "off",
  "ICE": "remove",
-  "flags": ["media handover", "port latching"],
+  "flags": ["port latching"],
  "rtcp-mux": ["demux"]
 }
@@ -3,13 +3,13 @@
    "transport-protocol": "UDP/TLS/RTP/SAVPF",
    "ICE": "force",
    "SDES": "off",
-    "flags": ["generate mid", "SDES-no", "media handover", "port latching"],
+    "flags": ["generate mid", "SDES-no", "port latching"],
    "rtcp-mux": ["require"]  
  },
  "teams": {
    "transport-protocol": "RTP/SAVP",
    "ICE": "force",
-    "flags": ["generate mid", "media handover",
+    "flags": ["generate mid",
      "SDES-no-AES_CM_128_HMAC_SHA1_32",
      "SDES-no-F8_128_HMAC_SHA1_80",
      "SDES-no-F8_128_HMAC_SHA1_32",
@@ -8,7 +8,8 @@ const {
  isBlackListedSipGateway,
  makeFullMediaReleaseKey,
  makePartnerFullMediaReleaseKey,
-  isValidDomainOrIP
+  isValidDomainOrIP,
+  removeVideoSdp
 } = require('./utils');
 const { MediaPath } = require('./constants.json');
 const {forwardInDialogRequests} = require('drachtio-fn-b2b-sugar');
@@ -321,7 +322,7 @@ class CallSession extends Emitter {
              const prefix = vc.tech_prefix || '';
              const transport =  o.protocol?.startsWith('tls') ? 'tls' : (o.protocol || 'udp');
              const hostport = !o.port || 5060 === o.port ? o.ipv4 : `${o.ipv4}:${o.port}`;
-              const prependPlus = vc.e164_leading_plus && !this.req.calledNumber.startsWith('0') ? '+' : '';
+              const prependPlus = vc.e164_leading_plus && /^[1-9]/.test(calledNumber) ? '+' : '';
              const scheme = transport === 'tls' && !process.env.JAMBONES_USE_BEST_EFFORT_TLS && o.use_sips_scheme ?
                'sips' : 'sip';
              let u = `${scheme}:${prefix}${prependPlus}${calledNumber}@${hostport};transport=${transport}`;
@@ -496,16 +497,19 @@ class CallSession extends Emitter {
          };
        }
        else {
+          const uri = parseUri(this.req.uri);
          hdrs = {
            ...hdrs,
            'From': createBLegFromHeader({
              logger: this.logger,
              req: this.req,
+              transport: uri.params.transport,
              ...(private_network && {host: this.privateSipAddress})
            }),
            'Contact': createBLegFromHeader({
              logger: this.logger,
              req: this.req,
+              transport: uri.params.transport,
              ...(private_network && {host: this.privateSipAddress})
            })
          };
@@ -638,7 +642,7 @@ class CallSession extends Emitter {
              }, this.decrKey, {writeCallCountSP, writeCallCount, writeCallCountApp})
                .catch((err) => this.logger.error(err, 'Error decrementing call counts'));
            }
-            debug(`got final outdial error: ${err}`);
+            this.logger.debug(`got final outdial error: ${err}`);
            if (!passFailure) this.res.send(status);
            this.emit('failed');
            this.rtpEngineResource.destroy()
@@ -938,8 +942,12 @@ Duration=${payload.duration} `
        throw new Error(`_onReinvite: rtpengine failed: ${JSON.stringify(response)}`);
      }
      this.logger.debug({opts, sdp: response.sdp}, 'CallSession:_onReinvite: (answer) sending back upstream');
+      let responseSdp = response.sdp;
+      if (process.env.JAMBONES_VIDEO_CALLS_ENABLED_IN_FS) {
+        responseSdp = removeVideoSdp(responseSdp);
+      }
      res.send(200, {
-        body: response.sdp,
+        body: responseSdp,
        headers: {
          'Contact': this.contactHeader
        }
@@ -1101,11 +1109,13 @@ Duration=${payload.duration} `
          const code = arr[1];
          const arr2 = /Duration=\s*(\d+)/.exec(req.body);
          const duration = arr2 ? arr2[1] : 250;
+          const volume = 13;
          const dtmfOpts = {
            ...this.rtpEngineOpts.common,
            'from-tag': this.rtpEngineOpts.uas.tag,
            code,
-            duration
+            duration,
+            volume
          };
          const response = await this.playDTMF(dtmfOpts);
          if ('ok' !== response.result) {
@@ -3,6 +3,7 @@ const srtpCharacteristics = require('../data/srtp-transcoding');
 const debug = require('debug')('jambonz:sbc-outbound');
 const CIDRMatcher = require('cidr-matcher');
 const dns = require('dns');
+const sdpTransform = require('sdp-transform');

 function makeRtpEngineOpts(req, srcIsUsingSrtp, dstIsUsingSrtp, padCrypto, teams) {
  const from = req.getParsedHeader('from');
@@ -27,6 +28,14 @@ function makeRtpEngineOpts(req, srcIsUsingSrtp, dstIsUsingSrtp, padCrypto, teams
      srcOpts.flags.push('inject DTMF');
    }
  }
+
+  /** By default, and for backwards compatibility, use media handover
+   * set env var to true to use strict source instead (needed for rtpbleed vulnerability)
+   */
+  const enableStrictSource = !!process.env.RTPENGINE_ENABLE_STRICT_SOURCE;
+  dstOpts.flags.push(enableStrictSource ? 'strict source' : 'media handover');
+  srcOpts.flags.push(enableStrictSource ?  'strict source' : 'media handover');
+
  const common = {
    'call-id': req.get('Call-ID'),
    'replace': ['origin', 'session-connection'],
@@ -281,7 +290,7 @@ const isPrivateVoipNetwork = async(uri) => {
  if (privateNetworkCidr) {
    try {
      const matcher = new CIDRMatcher(privateNetworkCidr.split(','));
-      const arr = /sips?:.*@(.*?)(:\d+)?(;.*)$/.exec(uri);
+      const arr = /sips?:.*@(.*?)(:\d+)?(;.*)?$/.exec(uri);
      if (arr) {
        const input = arr[1];
        let addresses;
@@ -334,7 +343,12 @@ function isValidDomainOrIP(input) {

  return false; // Invalid input
 }
-
+const removeVideoSdp = (sdp) => {
+  const parsedSdp = sdpTransform.parse(sdp);
+  // Filter out video media sections, keeping only non-video media
+  parsedSdp.media = parsedSdp.media.filter((media) => media.type !== 'video');
+  return sdpTransform.write(parsedSdp);
+};
 module.exports = {
  makeRtpEngineOpts,
  selectHostPort,
@@ -349,5 +363,6 @@ module.exports = {
  isBlackListedSipGateway,
  makeFullMediaReleaseKey,
  makePartnerFullMediaReleaseKey,
-  isValidDomainOrIP
+  isValidDomainOrIP,
+  removeVideoSdp
 };
@@ -1,12 +1,12 @@
 {
  "name": "sbc-outbound",
-  "version": "0.9.4",
+  "version": "0.9.5",
  "lockfileVersion": 3,
  "requires": true,
  "packages": {
    "": {
      "name": "sbc-outbound",
-      "version": "0.9.4",
+      "version": "0.9.5",
      "license": "MIT",
      "dependencies": {
        "@babel/helpers": "^7.26.10",
@@ -21,7 +21,7 @@
        "cidr-matcher": "^2.1.1",
        "debug": "^4.3.4",
        "drachtio-fn-b2b-sugar": "^0.2.1",
-        "drachtio-srf": "^5.0.5",
+        "drachtio-srf": "^5.0.12",
        "express": "^4.19.2",
        "pino": "^8.20.0",
        "sdp-transform": "^2.15.0"
@@ -1061,10 +1061,11 @@
      "integrity": "sha512-Tpp60P6IUJDTuOq/5Z8cdskzJujfwqfOTkrwIwj7IRISpnkJnT6SyJ4PCPnGMoFjC9ddhal5KVIYtAt97ix05A=="
    },
    "node_modules/brace-expansion": {
-      "version": "1.1.11",
-      "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-1.1.11.tgz",
-      "integrity": "sha512-iCuPHDFgrHX7H2vEI/5xpz07zSHB00TpugqhmYtVmMO6518mCuRMoOYFldEBl0g187ufozdaHgWKcYFb61qGiA==",
+      "version": "1.1.12",
+      "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-1.1.12.tgz",
+      "integrity": "sha512-9T9UjW3r0UW5c1Q7GTwllptXwhvYmEzFhzMfZ9H7FQWt+uZePjZPjBP/W1ZEyZ1twGWom5/56TF4lPcqjnDHcg==",
      "dev": true,
+      "license": "MIT",
      "dependencies": {
        "balanced-match": "^1.0.0",
        "concat-map": "0.0.1"
@@ -1586,9 +1587,10 @@
      "integrity": "sha512-bMtje8GWVTze+UG6WSGnlUfBaYCuFiApNXl/XxWc+X9uATZiZkV2jIqhf+Y4SY3nS8dZclJIVKd9qwoCa+i+Vw=="
    },
    "node_modules/drachtio-srf": {
-      "version": "5.0.5",
-      "resolved": "https://registry.npmjs.org/drachtio-srf/-/drachtio-srf-5.0.5.tgz",
-      "integrity": "sha512-dKdOf+zonTvk1eVu0IVc4a/Hdah2KspXngAeLQ3NZHdAkjQCJjYQZubVP6ho2QT1pzu8wA3U4M/atL1O99Ujzw==",
+      "version": "5.0.12",
+      "resolved": "https://registry.npmjs.org/drachtio-srf/-/drachtio-srf-5.0.12.tgz",
+      "integrity": "sha512-3L5nq3uxwb+DcHaeyRBR974no5mJkFilqqhbJ2VTjpJXC/nYAU/Q468z9hq3vtq7pGjc1kORxMHgH4Y0Oj8cIw==",
+      "license": "MIT",
      "dependencies": {
        "debug": "^3.2.7",
        "delegates": "^0.1.0",
@@ -1,6 +1,6 @@
 {
  "name": "sbc-outbound",
-  "version": "0.9.4",
+  "version": "0.9.5",
  "main": "app.js",
  "engines": {
    "node": ">= 18.0.0"
@@ -39,7 +39,7 @@
    "cidr-matcher": "^2.1.1",
    "debug": "^4.3.4",
    "drachtio-fn-b2b-sugar": "^0.2.1",
-    "drachtio-srf": "^5.0.5",
+    "drachtio-srf": "^5.0.12",
    "express": "^4.19.2",
    "pino": "^8.20.0",
    "sdp-transform": "^2.15.0"
Author	SHA1	Message	Date
Sam Machin	32d82ed67d	Fix/193 (#195 ) * pass sip failure reason back to FS * Update call-session.js * update drachtio-srf dep	2025-09-12 09:21:13 -04:00
Dave Horton	c17f27ab2c	fix prev commit (#192 )	2025-09-04 07:57:38 -04:00
Dave Horton	2fc570f731	when sending to retell with user starting with call_ dont prepend plus (#191 )	2025-09-03 23:35:56 -04:00
Sam Machin	c87f831868	Fix/transport in contact (#190 ) * use the req transport param in the From and Contact headers if set. * Update call-session.js	2025-09-03 13:53:51 -04:00
Sam Machin	616228bf09	update isPrivateVoipNetwork function (#189 )	2025-09-02 08:02:59 -04:00
Dave Horton	55fef10f0e	revert change (for now) that caused audio issues when reinviting to partial media (#187 )	2025-08-18 12:45:48 -04:00
Sam Machin	9357920f76	set strict source (#185 ) * set strict source RTPBleed * change to env var for strict source * Update srtp-transcoding.json * lint * lint * reverse the logic * and argghhh * clarification * change	2025-08-03 19:44:31 -04:00
Dave Horton	6771cbdefc	bump version	2025-07-15 11:46:40 -04:00
Vinod Dharashive	e422c2ed9c	increase dtmf volume (#184 ) https://github.com/jambonz/jambonz-feature-server/issues/1272	2025-07-09 08:22:53 -04:00
rammohan-y	fd5e2f1a6c	Remove video sdp incase of reinvite (#183 ) https://github.com/jambonz/sbc-outbound/issues/182	2025-07-08 09:17:16 -04:00