include codec-accept on answer to rtpengine during reinvites (#209 )

* include codec-accept on answer to rtpengine during reinvites * attempt to simplify * fixes from testing
when far end answers with only pcma, passthrough instead of transcoding to pcmu (#208 )
2026-10-04 02:04:19 +00:00 · 2025-12-02 07:37:18 -05:00 · 2025-11-24 11:23:16 -06:00 · 2025-11-04 18:02:31 -05:00
6 changed files with 43 additions and 42 deletions
@@ -36,3 +36,4 @@ node_modules
 .DS_Store

 examples/*
+CLAUDE.md
@@ -1,10 +1,10 @@
-FROM --platform=linux/amd64 node:18.15-alpine3.16 as base
+FROM --platform=linux/amd64 node:24-alpine AS base

 RUN apk --update --no-cache add --virtual .builds-deps build-base python3

 WORKDIR /opt/app/

-FROM base as build
+FROM base AS build

 COPY package.json package-lock.json ./

@@ -18,6 +18,6 @@ COPY --from=build /opt/app /opt/app/

 ARG NODE_ENV

-ENV NODE_ENV $NODE_ENV
+ENV NODE_ENV=$NODE_ENV

 CMD [ "node", "app.js" ]
@@ -1,5 +1,4 @@
 const Emitter = require('events');
-const sdpTransform = require('sdp-transform');
 const SrsClient = require('@jambonz/siprec-client-utils');
 const {
  makeRtpEngineOpts,
@@ -9,7 +8,7 @@ const {
  makeFullMediaReleaseKey,
  makePartnerFullMediaReleaseKey,
  isValidDomainOrIP,
-  removeVideoSdp
+  removeVideoSdp,
 } = require('./utils');
 const { MediaPath } = require('./constants.json');
 const {forwardInDialogRequests} = require('drachtio-fn-b2b-sugar');
@@ -95,18 +94,6 @@ const initCdr = (req, invite) => {
  };
 };

-const updateRtpEngineFlags = (sdp, opts) => {
-  try {
-    const parsed = sdpTransform.parse(sdp);
-    const codec = parsed.media[0].rtp[0].codec;
-    if (['PCMU', 'PCMA'].includes(codec)) {
-      opts.flags.push(`codec-accept-${codec}`);
-      opts.flags.push('codec-accept-telephone-event');
-    }
-  } catch {}
-  return opts;
-};
-
 class CallSession extends Emitter {
  constructor(logger, req, res) {
    super();
@@ -396,13 +383,13 @@ class CallSession extends Emitter {
      const toPublic = uris.some((u) => u.private_network === false);
      let isOfferUpdatedToPrivate = toPrivate && !toPublic;

-      const opts = updateRtpEngineFlags(this.req.body, {
+      const opts = {
        ...this.rtpEngineOpts.common,
        ...this.rtpEngineOpts.uac.mediaOpts,
        'from-tag': this.rtpEngineOpts.uas.tag,
        direction:  ['private', toPublic ? 'public' : 'private'],
        sdp: this.req.body
-      });
+      };
      let response = await this.offer(opts);
      this.logger.debug({offer: opts, response}, 'initial offer to rtpengine');
      if ('ok' !== response.result) {
@@ -514,7 +501,7 @@ class CallSession extends Emitter {
            })
          };
          const p = proxy ? ` via ${proxy}` : '';
-          this.logger.info({uri, p}, `sending INVITE to ${uri}${p}`);
+          this.logger.info({uri, p}, `sending INVITE${p}`);
        }

        /* now launch an outbound call attempt */
@@ -554,12 +541,17 @@ class CallSession extends Emitter {
            localSdpB: response.sdp,
            localSdpA: async(sdp, res) => {
              this.rtpEngineOpts.uac.tag = res.getParsedHeader('To').params.tag;
+
              const opts = {
                ...this.rtpEngineOpts.common,
                ...this.rtpEngineOpts.uas.mediaOpts,
                'from-tag': this.rtpEngineOpts.uas.tag,
                'to-tag': this.rtpEngineOpts.uac.tag,
-                flags: ['single codec', 'inject DTMF'],
+                flags: [
+                  'single codec',
+                  'inject DTMF',
+                  'reuse codecs',
+                ],
                sdp
              };
              const response = await this.answer(opts);
@@ -16,8 +16,8 @@ function makeRtpEngineOpts(req, srcIsUsingSrtp, dstIsUsingSrtp, padCrypto, teams
  }

  const srtpOpts = teams ? srtpCopy['teams'] : srtpCopy['default'];
-  const dstOpts = dstIsUsingSrtp ? srtpOpts : rtpCopy;
-  const srcOpts = srcIsUsingSrtp ? srtpOpts : rtpCopy;
+  const dstOpts = JSON.parse(JSON.stringify(dstIsUsingSrtp ? srtpOpts : rtpCopy));
+  const srcOpts = JSON.parse(JSON.stringify(srcIsUsingSrtp ? srtpOpts : rtpCopy));

  /** Allow feature server to send DTMF to the call excepts call from/to teams */
  if (!teams) {
@@ -41,6 +41,16 @@ function makeRtpEngineOpts(req, srcIsUsingSrtp, dstIsUsingSrtp, padCrypto, teams
    'replace': ['origin', 'session-connection'],
    'record call': process.env.JAMBONES_RECORD_ALL_CALLS ? 'yes' : 'no'
  };
+
+  const codec = {
+    accept: ['PCMU', 'PCMA', 'telephone-event'],
+    ...(process.env.JAMBONES_CODEC_OFFER_WITH_ORDER &&
+      {
+        offer: process.env.JAMBONES_CODEC_OFFER_WITH_ORDER.split(','),
+        strip: 'all'
+      }),
+  };
+
  return {
    common,
    uas: {
@@ -51,8 +61,7 @@ function makeRtpEngineOpts(req, srcIsUsingSrtp, dstIsUsingSrtp, padCrypto, teams
      tag: null,
      mediaOpts: {
        ...dstOpts,
-        ...(process.env.JAMBONES_CODEC_OFFER_WITH_ORDER &&
-          { codec: { offer: process.env.JAMBONES_CODEC_OFFER_WITH_ORDER.split(','), strip: 'all' } }),
+        codec,
      }
    }
  };
@@ -349,6 +358,7 @@ const removeVideoSdp = (sdp) => {
  parsedSdp.media = parsedSdp.media.filter((media) => media.type !== 'video');
  return sdpTransform.write(parsedSdp);
 };
+
 module.exports = {
  makeRtpEngineOpts,
  selectHostPort,
@@ -364,5 +374,5 @@ module.exports = {
  makeFullMediaReleaseKey,
  makePartnerFullMediaReleaseKey,
  isValidDomainOrIP,
-  removeVideoSdp
+  removeVideoSdp,
 };
@@ -19,10 +19,10 @@
        "@jambonz/stats-collector": "^0.1.10",
        "@jambonz/time-series": "^0.2.10",
        "cidr-matcher": "^2.1.1",
-        "debug": "^4.3.4",
+        "debug": "^4.4.3",
        "drachtio-fn-b2b-sugar": "^0.2.1",
        "drachtio-srf": "^5.0.12",
-        "express": "^4.19.2",
+        "express": "^4.21.2",
        "pino": "^10.1.0",
        "sdp-transform": "^2.15.0"
      },
@@ -1527,11 +1527,12 @@
      }
    },
    "node_modules/debug": {
-      "version": "4.3.5",
-      "resolved": "https://registry.npmjs.org/debug/-/debug-4.3.5.tgz",
-      "integrity": "sha512-pt0bNEmneDIvdL1Xsd9oDQ/wrQRkXDT4AUWlNZNPKvW5x/jyO9VFXkJUP07vQ2upmw5PlaITaPKc31jK13V+jg==",
+      "version": "4.4.3",
+      "resolved": "https://registry.npmjs.org/debug/-/debug-4.4.3.tgz",
+      "integrity": "sha512-RGwwWnwQvkVfavKVt22FGLw+xYSdzARwm0ru6DhTVA3umU5hZc28V3kO4stgYryrTlLpuvgI9GiijltAjNbcqA==",
+      "license": "MIT",
      "dependencies": {
-        "ms": "2.1.2"
+        "ms": "^2.1.3"
      },
      "engines": {
        "node": ">=6.0"
@@ -2183,6 +2184,7 @@
      "version": "4.21.2",
      "resolved": "https://registry.npmjs.org/express/-/express-4.21.2.tgz",
      "integrity": "sha512-28HqgMZAmih1Czt9ny7qr6ek2qddF4FclbMzwhCREB6OFfH+rXAnuNCwo1/wFvrtbgsQDb4kSbX9de9lFbrXnA==",
+      "license": "MIT",
      "dependencies": {
        "accepts": "~1.3.8",
        "array-flatten": "1.1.1",
@@ -3644,9 +3646,10 @@
      }
    },
    "node_modules/ms": {
-      "version": "2.1.2",
-      "resolved": "https://registry.npmjs.org/ms/-/ms-2.1.2.tgz",
-      "integrity": "sha512-sGkPx+VjMtmA6MX27oA4FBFELFCZZ4S4XqeGOXCv68tT+jb3vk/RyaKWP0PTKyWtmLSM0b+adUTEvbs1PEaH2w=="
+      "version": "2.1.3",
+      "resolved": "https://registry.npmjs.org/ms/-/ms-2.1.3.tgz",
+      "integrity": "sha512-6FlzubTLZG3J2a/NVCAleEhjzq5oxgHyaCU9yYXvcLsvoVaHJq/s5xXI6/XXP6tz7R9xAOtHnSO/tXtF3WRTlA==",
+      "license": "MIT"
    },
    "node_modules/mysql2": {
      "version": "3.11.0",
@@ -4464,11 +4467,6 @@
        "node": ">= 0.8"
      }
    },
-    "node_modules/send/node_modules/ms": {
-      "version": "2.1.3",
-      "resolved": "https://registry.npmjs.org/ms/-/ms-2.1.3.tgz",
-      "integrity": "sha512-6FlzubTLZG3J2a/NVCAleEhjzq5oxgHyaCU9yYXvcLsvoVaHJq/s5xXI6/XXP6tz7R9xAOtHnSO/tXtF3WRTlA=="
-    },
    "node_modules/seq-queue": {
      "version": "0.0.5",
      "resolved": "https://registry.npmjs.org/seq-queue/-/seq-queue-0.0.5.tgz",
@@ -37,10 +37,10 @@
    "@jambonz/stats-collector": "^0.1.10",
    "@jambonz/time-series": "^0.2.10",
    "cidr-matcher": "^2.1.1",
-    "debug": "^4.3.4",
+    "debug": "^4.4.3",
    "drachtio-fn-b2b-sugar": "^0.2.1",
    "drachtio-srf": "^5.0.12",
-    "express": "^4.19.2",
+    "express": "^4.21.2",
    "pino": "^10.1.0",
    "sdp-transform": "^2.15.0"
  },
Author	SHA1	Message	Date
Dave Horton	b3fee43c7f	include codec-accept on answer to rtpengine during reinvites (#209 ) * include codec-accept on answer to rtpengine during reinvites * attempt to simplify * fixes from testing	2025-12-02 07:37:18 -05:00
Dave Horton	5fab8a7515	when far end answers with only pcma, passthrough instead of transcoding to pcmu (#208 )	2025-11-24 11:23:16 -06:00
Anton Voylenko	178105acd7	chore: bump node version (#205 )	2025-11-04 18:02:31 -05:00