Compare commits

...
3 Commits
Author SHA1 Message Date
Dave Horton 11764e40b0 0.9.10 2026-09-15 12:39:12 -04:00
Hoan Luu HuuandClaude Opus 5 b9e9fe305a Fix/siprec survives fs transfer (#232)
* fix: keep siprec recording alive across a feature server transfer

A cross-feature-server move (enqueue/dequeue or conference) re-negotiates the
feature-server leg in _onFeatureServerTransfer, but nothing rebuilt the rtpengine
subscription the SIPREC recording forks from, so the recorder went silent from the
moment the call moved. The fresh destroy handler installed on the new leg also
dropped the _stopRecording() call the original handlers have, so the SIPREC dialog
was never BYEd and the recorder had to wait out its media timeout.

Rebuild the subscription after the transfer re-negotiates media, and stop the
recording when the transferred leg ends. The resubscribe call is guarded so this
is safe to deploy before @jambonz/siprec-client-utils is bumped.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix: drop the siprec re-subscribe, keep the missing teardown

The cross-feature-server move was tested on a real two-feature-server cluster
(inbound path): the rtpengine subscription survives the REFER on its own, so
resubscribe() was fixing a fault that does not exist. rtpengine keeps
non-offer-answer subscriptions across an answer.

What does fail, and what this branch still fixes, is the teardown: the destroy
handler installed on the transferred leg never stopped the recording, so the
recorder was left without a BYE. Verified on the inbound path; the outbound
transfer path has the identical handler and the same omission.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-07 18:42:47 +01:00
Dave Horton fec25d5d15 0.9.9 2026-08-20 09:16:55 -04:00
3 changed files with 4 additions and 3 deletions
+1
View File
@@ -1266,6 +1266,7 @@ Duration=${payload.duration} `
this.activeCallIds.delete(this.req.get('Call-ID'));
if (this.activeCallIds.size === 0) this.idleEmitter.emit('idle');
uac.other.destroy();
this._stopRecording();
if (this.req.locals.cdr) {
const now = Date.now();
const day = new Date();
+2 -2
View File
@@ -1,12 +1,12 @@
{
"name": "sbc-outbound",
"version": "0.9.8",
"version": "0.9.10",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "sbc-outbound",
"version": "0.9.8",
"version": "0.9.10",
"license": "MIT",
"dependencies": {
"@babel/helpers": "^7.26.10",
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "sbc-outbound",
"version": "0.9.8",
"version": "0.9.10",
"main": "app.js",
"engines": {
"node": ">= 20.0.0"