fix(github): resolve flake8 errors and improve check metadata

Fix E225 (missing whitespace around =) in provider.py and W292
(missing trailing newline) in check file. Update metadata CheckTitle
to describe PASS state and Recommendation URL to point to Prowler Hub.

prowler/providers/common/provider.py

@@ -238,8 +238,8 @@ class Provider(ABC):
                         fixer_config=fixer_config,
                     )
                 elif "github" in provider_class_name.lower():
-                    orgs=[]
-                    repos=[]
+                    orgs = []
+                    repos = []
 
                     if getattr(arguments, "organization", None):
                         orgs.extend(arguments.organization)
@@ -250,8 +250,8 @@ class Provider(ABC):
                     if getattr(arguments, "repositories", None):
                         repos.extend(arguments.repositories)
 
-                    orgs=list(dict.fromkeys(orgs))
-                    repos=list(dict.fromkeys(repos))
+                    orgs = list(dict.fromkeys(orgs))
+                    repos = list(dict.fromkeys(repos))
 
                     provider_class(
                         personal_access_token=arguments.personal_access_token,

prowler/providers/github/services/organization/organization_repository_deletion_limited/organization_repository_deletion_limited.metadata.json

@@ -1,7 +1,7 @@
 {
   "Provider": "github",
   "CheckID": "organization_repository_deletion_limited",
-  "CheckTitle": "Ensure repository deletion is limited to trusted organization users",
+  "CheckTitle": "Organization repository deletion and transfer is restricted to owners",
   "CheckType": [],
   "ServiceName": "organization",
   "SubServiceName": "",
@@ -21,7 +21,7 @@
     },
     "Recommendation": {
       "Text": "Disable member repository deletion/transfer privileges so only organization owners can delete or transfer repositories.",
-      "Url": "https://docs.github.com/en/organizations/managing-organization-settings/setting-permissions-for-deleting-or-transferring-repositories"
+      "Url": "https://hub.prowler.com/check/organization_repository_deletion_limited"
     }
   },
   "Categories": [
@@ -33,4 +33,4 @@
   "AdditionalURLs": [
     "https://docs.github.com/en/organizations/managing-organization-settings/setting-permissions-for-deleting-or-transferring-repositories"
   ]
-}
+}

prowler/providers/github/services/organization/organization_repository_deletion_limited/organization_repository_deletion_limited.py

@@ -21,15 +21,11 @@ class organization_repository_deletion_limited(Check):
 
             if members_can_delete is False:
                 report.status = "PASS"
-                report.status_extended = (
-                    f"Organization {org.name} restricts repository deletion/transfer to trusted users."
-                )
+                report.status_extended = f"Organization {org.name} restricts repository deletion/transfer to trusted users."
             else:
                 report.status = "FAIL"
-                report.status_extended = (
-                    f"Organization {org.name} allows members to delete/transfer repositories."
-                )
+                report.status_extended = f"Organization {org.name} allows members to delete/transfer repositories."
 
             findings.append(report)
 
-        return findings
+        return findings