ben.carrasco/prowler
1
0 Fork 0
mirror of https://github.com/prowler-cloud/prowler.git synced 2026-10-18 17:34:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: enhance entra_organization_admin_consent_workflow_enabled rename

Browse Source
This commit is contained in:
HugoPBrito committed 2025-03-13 20:04:48 +01:00
1 parent 1ab91b0cae
commit f0d4c2cfda
4 files changed
+20 -20
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

prowler/providers/microsoft365/services/entra/entra_organization_admin_consent_workflow_enabled/__init__.py → prowler/providers/microsoft365/services/entra/entra_enterprise_app_admin_consent_workflow_enabled/__init__.py
View File
File renamed without changes.
prowler/providers/microsoft365/services/entra/entra_organization_admin_consent_workflow_enabled/entra_organization_admin_consent_workflow_enabled.metadata.json → prowler/providers/microsoft365/services/entra/entra_enterprise_app_admin_consent_workflow_enabled/entra_enterprise_app_admin_consent_workflow_enabled.metadata.json
+2 -2
View File
@@ -1,13 +1,13 @@
{
"Provider": "microsoft365",
"CheckID": "entra_organization_admin_consent_workflow_enabled",
"CheckID": "entra_enterprise_app_admin_consent_workflow_enabled",
"CheckTitle": "Ensure the admin consent workflow is enabled.",
"CheckType": [],
"ServiceName": "entra",
"SubServiceName": "",
"ResourceIdTemplate": "",
"Severity": "high",
"ResourceType": "Organization Settings",
"ResourceType": "Enterprise Applications Settings",
"Description": "Ensure that the admin consent workflow is enabled in Microsoft Entra to allow users to request admin approval for applications requiring consent.",
"Risk": "If the admin consent workflow is not enabled, users may be blocked from accessing applications that require admin consent, leading to potential work disruptions or unauthorized workarounds.",
"RelatedUrl": "https://learn.microsoft.com/en-us/entra/identity/enterprise-apps/configure-admin-consent-workflow",
prowler/providers/microsoft365/services/entra/entra_organization_admin_consent_workflow_enabled/entra_organization_admin_consent_workflow_enabled.py → prowler/providers/microsoft365/services/entra/entra_enterprise_app_admin_consent_workflow_enabled/entra_enterprise_app_admin_consent_workflow_enabled.py
+1 -1
View File
@@ -4,7 +4,7 @@ from prowler.lib.check.models import Check, CheckReportMicrosoft365
from prowler.providers.microsoft365.services.entra.entra_client import entra_client
class entra_organization_admin_consent_workflow_enabled(Check):
class entra_enterprise_app_admin_consent_workflow_enabled(Check):
"""
Ensure the admin consent workflow is enabled in Microsoft Entra.
tests/providers/microsoft365/services/entra/entra_organization_admin_consent_workflow_enabled/entra_organization_admin_consent_workflow_enabled_test.py → tests/providers/microsoft365/services/entra/entra_enterprise_app_admin_consent_workflow_enabled/entra_enterprise_app_admin_consent_workflow_enabled_test.py
+17 -17
View File
@@ -9,7 +9,7 @@ from tests.providers.microsoft365.microsoft365_fixtures import (
)
class Test_entra_organization_admin_consent_workflow_enabled:
class Test_entra_enterprise_app_admin_consent_workflow_enabled:
def test_admin_consent_enabled(self):
"""
Test when admin_consent_enabled is True:
@@ -23,12 +23,12 @@ class Test_entra_organization_admin_consent_workflow_enabled:
return_value=set_mocked_microsoft365_provider(),
),
mock.patch(
"prowler.providers.microsoft365.services.entra.entra_organization_admin_consent_workflow_enabled.entra_organization_admin_consent_workflow_enabled.entra_client",
"prowler.providers.microsoft365.services.entra.entra_enterprise_app_admin_consent_workflow_enabled.entra_enterprise_app_admin_consent_workflow_enabled.entra_client",
new=entra_client,
),
):
from prowler.providers.microsoft365.services.entra.entra_organization_admin_consent_workflow_enabled.entra_organization_admin_consent_workflow_enabled import (
entra_organization_admin_consent_workflow_enabled,
from prowler.providers.microsoft365.services.entra.entra_enterprise_app_admin_consent_workflow_enabled.entra_enterprise_app_admin_consent_workflow_enabled import (
entra_enterprise_app_admin_consent_workflow_enabled,
)
entra_client.admin_consent_policy = AdminConsentPolicy(
@@ -39,7 +39,7 @@ class Test_entra_organization_admin_consent_workflow_enabled:
)
entra_client.tenant_domain = DOMAIN
check = entra_organization_admin_consent_workflow_enabled()
check = entra_enterprise_app_admin_consent_workflow_enabled()
result = check.execute()
assert len(result) == 1
@@ -65,12 +65,12 @@ class Test_entra_organization_admin_consent_workflow_enabled:
return_value=set_mocked_microsoft365_provider(),
),
mock.patch(
"prowler.providers.microsoft365.services.entra.entra_organization_admin_consent_workflow_enabled.entra_organization_admin_consent_workflow_enabled.entra_client",
"prowler.providers.microsoft365.services.entra.entra_enterprise_app_admin_consent_workflow_enabled.entra_enterprise_app_admin_consent_workflow_enabled.entra_client",
new=entra_client,
),
):
from prowler.providers.microsoft365.services.entra.entra_organization_admin_consent_workflow_enabled.entra_organization_admin_consent_workflow_enabled import (
entra_organization_admin_consent_workflow_enabled,
from prowler.providers.microsoft365.services.entra.entra_enterprise_app_admin_consent_workflow_enabled.entra_enterprise_app_admin_consent_workflow_enabled import (
entra_enterprise_app_admin_consent_workflow_enabled,
)
entra_client.admin_consent_policy = AdminConsentPolicy(
@@ -81,7 +81,7 @@ class Test_entra_organization_admin_consent_workflow_enabled:
)
entra_client.tenant_domain = DOMAIN
check = entra_organization_admin_consent_workflow_enabled()
check = entra_enterprise_app_admin_consent_workflow_enabled()
result = check.execute()
assert len(result) == 1
@@ -107,12 +107,12 @@ class Test_entra_organization_admin_consent_workflow_enabled:
return_value=set_mocked_microsoft365_provider(),
),
mock.patch(
"prowler.providers.microsoft365.services.entra.entra_organization_admin_consent_workflow_enabled.entra_organization_admin_consent_workflow_enabled.entra_client",
"prowler.providers.microsoft365.services.entra.entra_enterprise_app_admin_consent_workflow_enabled.entra_enterprise_app_admin_consent_workflow_enabled.entra_client",
new=entra_client,
),
):
from prowler.providers.microsoft365.services.entra.entra_organization_admin_consent_workflow_enabled.entra_organization_admin_consent_workflow_enabled import (
entra_organization_admin_consent_workflow_enabled,
from prowler.providers.microsoft365.services.entra.entra_enterprise_app_admin_consent_workflow_enabled.entra_enterprise_app_admin_consent_workflow_enabled import (
entra_enterprise_app_admin_consent_workflow_enabled,
)
entra_client.admin_consent_policy = AdminConsentPolicy(
@@ -123,7 +123,7 @@ class Test_entra_organization_admin_consent_workflow_enabled:
)
entra_client.tenant_domain = DOMAIN
check = entra_organization_admin_consent_workflow_enabled()
check = entra_enterprise_app_admin_consent_workflow_enabled()
result = check.execute()
assert len(result) == 1
@@ -151,15 +151,15 @@ class Test_entra_organization_admin_consent_workflow_enabled:
return_value=set_mocked_microsoft365_provider(),
),
mock.patch(
"prowler.providers.microsoft365.services.entra.entra_organization_admin_consent_workflow_enabled.entra_organization_admin_consent_workflow_enabled.entra_client",
"prowler.providers.microsoft365.services.entra.entra_enterprise_app_admin_consent_workflow_enabled.entra_enterprise_app_admin_consent_workflow_enabled.entra_client",
new=entra_client,
),
):
from prowler.providers.microsoft365.services.entra.entra_organization_admin_consent_workflow_enabled.entra_organization_admin_consent_workflow_enabled import (
entra_organization_admin_consent_workflow_enabled,
from prowler.providers.microsoft365.services.entra.entra_enterprise_app_admin_consent_workflow_enabled.entra_enterprise_app_admin_consent_workflow_enabled import (
entra_enterprise_app_admin_consent_workflow_enabled,
)
check = entra_organization_admin_consent_workflow_enabled()
check = entra_enterprise_app_admin_consent_workflow_enabled()
result = check.execute()
assert len(result) == 0